From: Nathan Fontenot <nfont@austin.ibm.com>
To: Andrew Morton <akpm00@gmail.com>
Cc: Greg KH <gregkh@suse.de>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memory hotplug: Correct page reservation checking
Date: Tue, 04 Oct 2011 09:19:00 -0500 [thread overview]
Message-ID: <4E8B15D4.9080104@austin.ibm.com> (raw)
In-Reply-To: <20111003175022.50cbef7f.akpm00@gmail.com>
On 10/03/2011 07:50 PM, Andrew Morton wrote:
> On Mon, 26 Sep 2011 10:22:33 -0500
> Nathan Fontenot <nfont@austin.ibm.com> wrote:
>
>> The check to ensure that pages of recently added memory sections are correctly
>> marked as reserved before trying to online the memory is broken. The request
>> to online the memory fails with the following:
>>
>> kernel: section number XXX page number 256 not reserved, was it already online?
>>
>> This updates the page reservation checking to check the pages of each memory
>> section of the memory block being onlined individually.
>
> Why was this only noticed now? Is there something unusual about the
> way in which you're using it, or has nobody ever used this code, or...?
>
As far as I know it is only the powerpc/pseries code that uses the feature that
allows memory blocks in sysfs to span multiple memory sections. We do this
because on pseries memory add/remove is done on a per LMB basis and we can have
machine where an LMB spans multiple memory sections.
This was just noticed due to a lack of testing between the 2.6.38/39 kernels where
this feature originally went in and the current mainline kernel.
-Nathan
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Fontenot <nfont@austin.ibm.com>
To: Andrew Morton <akpm00@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Greg KH <gregkh@suse.de>
Subject: Re: [PATCH] memory hotplug: Correct page reservation checking
Date: Tue, 04 Oct 2011 09:19:00 -0500 [thread overview]
Message-ID: <4E8B15D4.9080104@austin.ibm.com> (raw)
In-Reply-To: <20111003175022.50cbef7f.akpm00@gmail.com>
On 10/03/2011 07:50 PM, Andrew Morton wrote:
> On Mon, 26 Sep 2011 10:22:33 -0500
> Nathan Fontenot <nfont@austin.ibm.com> wrote:
>
>> The check to ensure that pages of recently added memory sections are correctly
>> marked as reserved before trying to online the memory is broken. The request
>> to online the memory fails with the following:
>>
>> kernel: section number XXX page number 256 not reserved, was it already online?
>>
>> This updates the page reservation checking to check the pages of each memory
>> section of the memory block being onlined individually.
>
> Why was this only noticed now? Is there something unusual about the
> way in which you're using it, or has nobody ever used this code, or...?
>
As far as I know it is only the powerpc/pseries code that uses the feature that
allows memory blocks in sysfs to span multiple memory sections. We do this
because on pseries memory add/remove is done on a per LMB basis and we can have
machine where an LMB spans multiple memory sections.
This was just noticed due to a lack of testing between the 2.6.38/39 kernels where
this feature originally went in and the current mainline kernel.
-Nathan
next prev parent reply other threads:[~2011-10-04 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 15:22 [PATCH] memory hotplug: Correct page reservation checking Nathan Fontenot
2011-10-04 0:50 ` Andrew Morton
2011-10-04 0:50 ` Andrew Morton
2011-10-04 14:19 ` Nathan Fontenot [this message]
2011-10-04 14:19 ` Nathan Fontenot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8B15D4.9080104@austin.ibm.com \
--to=nfont@austin.ibm.com \
--cc=akpm00@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.