All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Xen Devel <xen-devel@lists.xensource.com>,
	QEMU-devel <qemu-devel@nongnu.org>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH RFC V1 00/11] Xen PCI Passthrough
Date: Tue, 04 Oct 2011 19:03:59 +0200	[thread overview]
Message-ID: <4E8B3C7F.4020300@redhat.com> (raw)
In-Reply-To: <4E8B1FBC.2080904@codemonkey.ws>

On 10/04/2011 05:01 PM, Anthony Liguori wrote:
>> We also have pci passthrough in qemu-kvm (I think based on the same 
>> Neocleus
>> code). Rather than having two pci assignment implementations, I think 
>> we should
>> have just one, with the differences (programming the hypervisor) 
>> abstracted at
>> that level.
>
>
> I agree in principle but how close is qemu-kvm pci passthrough to a 
> mergable state?  Would it make sense to merge the Xen code first and 
> then abstract it?

Merging either implementation and abstracting it would risk regressions 
in the other.

How about merging both, with the ABIs (command line and qmp) tagged as 
experimental, and then doing a merge in the same style as 
i386+x86_64->x86 or the two kvm implementations in qemu?  We can pick 
one implementation as the merge target and port fixes from the other.

-- 
error compiling committee.c: too many arguments to function

WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Xen Devel <xen-devel@lists.xensource.com>,
	QEMU-devel <qemu-devel@nongnu.org>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH RFC V1 00/11] Xen PCI Passthrough
Date: Tue, 04 Oct 2011 19:03:59 +0200	[thread overview]
Message-ID: <4E8B3C7F.4020300@redhat.com> (raw)
In-Reply-To: <4E8B1FBC.2080904@codemonkey.ws>

On 10/04/2011 05:01 PM, Anthony Liguori wrote:
>> We also have pci passthrough in qemu-kvm (I think based on the same 
>> Neocleus
>> code). Rather than having two pci assignment implementations, I think 
>> we should
>> have just one, with the differences (programming the hypervisor) 
>> abstracted at
>> that level.
>
>
> I agree in principle but how close is qemu-kvm pci passthrough to a 
> mergable state?  Would it make sense to merge the Xen code first and 
> then abstract it?

Merging either implementation and abstracting it would risk regressions 
in the other.

How about merging both, with the ABIs (command line and qmp) tagged as 
experimental, and then doing a merge in the same style as 
i386+x86_64->x86 or the two kvm implementations in qemu?  We can pick 
one implementation as the merge target and port fixes from the other.

-- 
error compiling committee.c: too many arguments to function

  parent reply	other threads:[~2011-10-04 17:04 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-04 14:51 [Qemu-devel] [PATCH RFC V1 00/11] Xen PCI Passthrough Anthony PERARD
2011-10-04 14:51 ` Anthony PERARD
2011-10-04 14:51 ` [Qemu-devel] [PATCH RFC V1 01/11] Introduce HostPCIDevice to access a pci device on the host Anthony PERARD
2011-10-04 14:51   ` Anthony PERARD
2011-10-04 18:21   ` [Qemu-devel] " Jan Kiszka
2011-10-04 18:21     ` Jan Kiszka
2011-10-12 16:56     ` [Qemu-devel] " Anthony PERARD
2011-10-12 16:56       ` Anthony PERARD
2011-10-04 18:36   ` [Qemu-devel] " Stefano Stabellini
2011-10-04 18:36     ` Stefano Stabellini
2011-10-04 14:51 ` [Qemu-devel] [PATCH RFC V1 02/11] qemu-timer: Introduce qemu_run_one_timer Anthony PERARD
2011-10-04 14:51   ` Anthony PERARD
2011-10-04 17:27   ` [Qemu-devel] " Jan Kiszka
2011-10-04 17:27     ` Jan Kiszka
2011-10-04 17:52     ` [Qemu-devel] " Stefano Stabellini
2011-10-04 17:52       ` Stefano Stabellini
2011-10-04 18:20     ` [Qemu-devel] " Anthony Liguori
2011-10-04 18:20       ` Anthony Liguori
2011-10-04 14:51 ` [Qemu-devel] [PATCH RFC V1 03/11] pci_ids: Add INTEL_82599_VF id Anthony PERARD
2011-10-04 14:51   ` Anthony PERARD
2011-10-04 14:51 ` [Qemu-devel] [PATCH RFC V1 04/11] pci_regs: Fix value of PCI_EXP_TYPE_RC_EC Anthony PERARD
2011-10-04 14:51   ` Anthony PERARD
2011-10-04 14:51 ` [Qemu-devel] [PATCH RFC V1 05/11] pci_regs: Add PCI_EXP_TYPE_PCIE_BRIDGE Anthony PERARD
2011-10-04 14:51   ` Anthony PERARD
2011-10-04 14:51 ` [Qemu-devel] [PATCH RFC V1 06/11] pci.c: Add pci_check_bar_overlap Anthony PERARD
2011-10-04 14:51   ` Anthony PERARD
2011-10-04 14:51 ` [Qemu-devel] [PATCH RFC V1 07/11] host-pci-device: Add host_pci_find_ext_cap_offset Anthony PERARD
2011-10-04 14:51   ` Anthony PERARD
2011-10-05 11:07   ` [Qemu-devel] " Stefano Stabellini
2011-10-05 11:07     ` Stefano Stabellini
2011-10-04 14:51 ` [Qemu-devel] [PATCH RFC V1 08/11] Introduce Xen PCI Passthrough, qdevice (1/3) Anthony PERARD
2011-10-04 14:51   ` Anthony PERARD
2011-10-05 11:51   ` [Qemu-devel] " Stefano Stabellini
2011-10-05 11:51     ` Stefano Stabellini
2011-10-04 14:51 ` [Qemu-devel] [PATCH RFC V1 09/11] Introduce Xen PCI Passthrough, PCI config space helpers (2/3) Anthony PERARD
2011-10-04 14:51   ` Anthony PERARD
2011-10-04 14:51 ` [Qemu-devel] [PATCH RFC V1 10/11] Introduce Xen PCI Passthrough, MSI (3/3) Anthony PERARD
2011-10-04 14:51   ` Anthony PERARD
2011-10-05 11:51   ` [Qemu-devel] " Stefano Stabellini
2011-10-05 11:51     ` Stefano Stabellini
2011-10-04 14:51 ` [Qemu-devel] [PATCH RFC V1 11/11] config/make: Introduce --enable-xen-pci-passthrough, built it Anthony PERARD
2011-10-04 14:51   ` Anthony PERARD
2011-10-05 11:55   ` [Qemu-devel] " Stefano Stabellini
2011-10-05 11:55     ` Stefano Stabellini
2011-10-04 14:58 ` [Qemu-devel] [Xen-devel] [PATCH RFC V1 00/11] Xen PCI Passthrough Avi Kivity
2011-10-04 14:58   ` Avi Kivity
2011-10-04 15:01   ` [Qemu-devel] " Anthony Liguori
2011-10-04 15:01     ` Anthony Liguori
2011-10-04 15:05     ` [Qemu-devel] " Stefano Stabellini
2011-10-04 15:05       ` Stefano Stabellini
2011-10-04 16:33       ` [Qemu-devel] " Alex Williamson
2011-10-04 16:33         ` Alex Williamson
2011-10-04 16:56         ` [Qemu-devel] " Stefano Stabellini
2011-10-04 16:56           ` Stefano Stabellini
2011-10-04 17:01         ` [Qemu-devel] " Avi Kivity
2011-10-04 17:01           ` Avi Kivity
2011-10-04 17:41           ` [Qemu-devel] " Jan Kiszka
2011-10-04 17:41             ` Jan Kiszka
2011-10-04 17:03     ` Avi Kivity [this message]
2011-10-04 17:03       ` Avi Kivity
2011-10-04 18:19       ` [Qemu-devel] " Stefano Stabellini
2011-10-04 18:19         ` Stefano Stabellini
2011-10-04 18:24         ` [Qemu-devel] " Avi Kivity
2011-10-04 18:24           ` Avi Kivity
2011-10-04 17:21     ` [Qemu-devel] " Jan Kiszka
2011-10-04 17:21       ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8B3C7F.4020300@redhat.com \
    --to=avi@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=anthony.perard@citrix.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.