From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, B13201@freescale.com
Subject: Re: [PATCH] KVM: PPC: E500: Support hugetlbfs
Date: Wed, 05 Oct 2011 19:53:53 +0000 [thread overview]
Message-ID: <4E8CB5D1.1050701@freescale.com> (raw)
In-Reply-To: <C80D9E39-F4CC-4FE1-B943-A80E0600570A@suse.de>
On 10/05/2011 01:55 PM, Alexander Graf wrote:
>
> On 05.10.2011, at 18:06, Scott Wood wrote:
>
>> Any reason for __ilog2() rather than ilog2()? Shouldn't make a
>> difference, just curious about avoiding the public interface.
>
> I grep'ed through the kernel tree and only found __ilog2 defined as well as mostly users for __ilog2, so I figured there's got to be a reason ;)
ilog2() is defined in include/linux/ilog2.h. It produces constant
output if the input is constant, and appears to be the "front door" to
__ilog2_u32/__ilog2_u64. Plain __ilog2 is older and powerpc-specific,
which is probably why there are more users of that in arch/powerpc.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: <kvm@vger.kernel.org>, <kvm-ppc@vger.kernel.org>, <B13201@freescale.com>
Subject: Re: [PATCH] KVM: PPC: E500: Support hugetlbfs
Date: Wed, 5 Oct 2011 14:53:53 -0500 [thread overview]
Message-ID: <4E8CB5D1.1050701@freescale.com> (raw)
In-Reply-To: <C80D9E39-F4CC-4FE1-B943-A80E0600570A@suse.de>
On 10/05/2011 01:55 PM, Alexander Graf wrote:
>
> On 05.10.2011, at 18:06, Scott Wood wrote:
>
>> Any reason for __ilog2() rather than ilog2()? Shouldn't make a
>> difference, just curious about avoiding the public interface.
>
> I grep'ed through the kernel tree and only found __ilog2 defined as well as mostly users for __ilog2, so I figured there's got to be a reason ;)
ilog2() is defined in include/linux/ilog2.h. It produces constant
output if the input is constant, and appears to be the "front door" to
__ilog2_u32/__ilog2_u64. Plain __ilog2 is older and powerpc-specific,
which is probably why there are more users of that in arch/powerpc.
-Scott
next prev parent reply other threads:[~2011-10-05 19:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 23:35 [PATCH] KVM: PPC: E500: Support hugetlbfs Alexander Graf
2011-09-19 23:35 ` Alexander Graf
2011-09-20 17:54 ` Scott Wood
2011-09-20 17:54 ` Scott Wood
2011-09-24 7:44 ` Alexander Graf
2011-09-24 7:44 ` Alexander Graf
2011-09-26 20:28 ` Scott Wood
2011-09-26 20:28 ` Scott Wood
2011-09-22 6:50 ` Liu Yu-B13201
2011-09-24 7:47 ` Alexander Graf
2011-09-24 7:47 ` Alexander Graf
2011-09-26 20:04 ` Scott Wood
2011-09-26 20:04 ` Scott Wood
2011-10-05 14:37 ` Alexander Graf
2011-10-05 14:37 ` Alexander Graf
2011-10-05 16:06 ` Scott Wood
2011-10-05 16:06 ` Scott Wood
2011-10-05 18:55 ` Alexander Graf
2011-10-05 18:55 ` Alexander Graf
2011-10-05 19:53 ` Scott Wood [this message]
2011-10-05 19:53 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8CB5D1.1050701@freescale.com \
--to=scottwood@freescale.com \
--cc=B13201@freescale.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.