From: Jonathan Cameron <jic23@cam.ac.uk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Bryan Freed <bfreed@chromium.org>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] Staging: iio/light/tsl2563: unlock on an error path
Date: Thu, 06 Oct 2011 11:24:20 +0000 [thread overview]
Message-ID: <4E8D8FE4.9080907@cam.ac.uk> (raw)
In-Reply-To: <20111006061503.GA14701@elgon.mountain>
On 10/06/11 07:15, Dan Carpenter wrote:
> We need to unlock here before returning.
Thanks
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
>
> diff --git a/drivers/staging/iio/light/tsl2563.c b/drivers/staging/iio/light/tsl2563.c
> index 3707772..8977f58 100644
> --- a/drivers/staging/iio/light/tsl2563.c
> +++ b/drivers/staging/iio/light/tsl2563.c
> @@ -518,7 +518,8 @@ static int tsl2563_read_raw(struct iio_dev *indio_dev,
> ret = IIO_VAL_INT;
> break;
> default:
> - return -EINVAL;
> + ret = -EINVAL;
> + goto error_ret;
> }
>
> error_ret:
>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@cam.ac.uk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Bryan Freed <bfreed@chromium.org>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] Staging: iio/light/tsl2563: unlock on an error path
Date: Thu, 06 Oct 2011 12:24:20 +0100 [thread overview]
Message-ID: <4E8D8FE4.9080907@cam.ac.uk> (raw)
In-Reply-To: <20111006061503.GA14701@elgon.mountain>
On 10/06/11 07:15, Dan Carpenter wrote:
> We need to unlock here before returning.
Thanks
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
>
> diff --git a/drivers/staging/iio/light/tsl2563.c b/drivers/staging/iio/light/tsl2563.c
> index 3707772..8977f58 100644
> --- a/drivers/staging/iio/light/tsl2563.c
> +++ b/drivers/staging/iio/light/tsl2563.c
> @@ -518,7 +518,8 @@ static int tsl2563_read_raw(struct iio_dev *indio_dev,
> ret = IIO_VAL_INT;
> break;
> default:
> - return -EINVAL;
> + ret = -EINVAL;
> + goto error_ret;
> }
>
> error_ret:
>
next prev parent reply other threads:[~2011-10-06 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 6:15 [patch 1/2] Staging: iio/light/tsl2563: unlock on an error path Dan Carpenter
2011-10-06 6:15 ` Dan Carpenter
2011-10-06 11:24 ` Jonathan Cameron [this message]
2011-10-06 11:24 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8D8FE4.9080907@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=Michael.Hennerich@analog.com \
--cc=arnd@arndb.de \
--cc=bfreed@chromium.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.