From: Juergen Gross <juergen.gross@ts.fujitsu.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] Avoid relative XEN_ROOT specification
Date: Fri, 07 Oct 2011 09:55:43 +0200 [thread overview]
Message-ID: <4E8EB07F.70702@ts.fujitsu.com> (raw)
In-Reply-To: <1317973890.21903.280.camel@zakaz.uk.xensource.com>
On 10/07/2011 09:51 AM, Ian Campbell wrote:
> On Fri, 2011-10-07 at 05:42 +0100, Juergen Gross wrote:
>> XEN_ROOT must be set to an absolute path to avoid out of the tree references
> How about:
>
> # HG changeset patch
> # User Ian Campbell<ian.campbell@citrix.com>
> # Date 1317973741 -3600
> # Node ID d0327c39dff8abdc224e3c19f31e11f0fbeb5c16
> # Parent f17f0df2a2ede01a8c35dc4768a532a4438b1c02
> tools: error out on non-absolute $(XEN_ROOT)
>
> Signed-off-by: Ian Campbell<ian.campbell@citrix.com>
Acked-by: juergen.gross@ts.fujitsu.com
> diff -r f17f0df2a2ed -r d0327c39dff8 tools/Rules.mk
> --- a/tools/Rules.mk Wed Oct 05 10:43:41 2011 +0100
> +++ b/tools/Rules.mk Fri Oct 07 08:49:01 2011 +0100
> @@ -3,6 +3,10 @@
> # `all' is the default target
> all:
>
> +ifeq ($(filter /%,$(XEN_ROOT)),)
> +$(error XEN_ROOT must be absolute)
> +endif
> +
> include $(XEN_ROOT)/Config.mk
>
> export _INSTALL := $(INSTALL)
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
>
--
Juergen Gross Principal Developer Operating Systems
PDG ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28 Internet: ts.fujitsu.com
D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html
next prev parent reply other threads:[~2011-10-07 7:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 4:42 [PATCH] Avoid relative XEN_ROOT specification Juergen Gross
2011-10-07 7:51 ` Ian Campbell
2011-10-07 7:55 ` Juergen Gross [this message]
2011-10-07 8:00 ` Keir Fraser
2011-10-07 8:04 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8EB07F.70702@ts.fujitsu.com \
--to=juergen.gross@ts.fujitsu.com \
--cc=Ian.Campbell@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.