* [PATCH] Avoid relative XEN_ROOT specification
@ 2011-10-07 4:42 Juergen Gross
2011-10-07 7:51 ` Ian Campbell
0 siblings, 1 reply; 5+ messages in thread
From: Juergen Gross @ 2011-10-07 4:42 UTC (permalink / raw)
To: xen-devel
[-- Attachment #1: Type: text/plain, Size: 212 bytes --]
XEN_ROOT must be set to an absolute path to avoid out of the tree references
Signed-off-by: juergen.gross@ts.fujitsu.com
1 file changed, 1 insertion(+), 1 deletion(-)
tools/libfsimage/xfs/Makefile | 2 +-
[-- Attachment #2: xen-staging.hg.patch --]
[-- Type: text/x-patch, Size: 679 bytes --]
# HG changeset patch
# User Juergen Gross <juergen.gross@ts.fujitsu.com>
# Date 1317962555 -7200
# Node ID 67f2c8de11ecb6d05e2239340ebbf83208c44863
# Parent 159be83e5fe9111bb30d8b1f83127f5724d44424
Avoid relative XEN_ROOT specification
XEN_ROOT must be set to an absolute path to avoid out of the tree references
Signed-off-by: juergen.gross@ts.fujitsu.com
diff -r 159be83e5fe9 -r 67f2c8de11ec tools/libfsimage/xfs/Makefile
--- a/tools/libfsimage/xfs/Makefile Thu Oct 06 19:44:40 2011 +0100
+++ b/tools/libfsimage/xfs/Makefile Fri Oct 07 06:42:35 2011 +0200
@@ -1,4 +1,4 @@ XEN_ROOT = ../../..
-XEN_ROOT = ../../..
+XEN_ROOT = $(CURDIR)/../../..
LIB_SRCS-y = fsys_xfs.c
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Avoid relative XEN_ROOT specification
2011-10-07 4:42 [PATCH] Avoid relative XEN_ROOT specification Juergen Gross
@ 2011-10-07 7:51 ` Ian Campbell
2011-10-07 7:55 ` Juergen Gross
2011-10-07 8:00 ` Keir Fraser
0 siblings, 2 replies; 5+ messages in thread
From: Ian Campbell @ 2011-10-07 7:51 UTC (permalink / raw)
To: Juergen Gross; +Cc: xen-devel@lists.xensource.com
On Fri, 2011-10-07 at 05:42 +0100, Juergen Gross wrote:
> XEN_ROOT must be set to an absolute path to avoid out of the tree references
How about:
# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1317973741 -3600
# Node ID d0327c39dff8abdc224e3c19f31e11f0fbeb5c16
# Parent f17f0df2a2ede01a8c35dc4768a532a4438b1c02
tools: error out on non-absolute $(XEN_ROOT)
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
diff -r f17f0df2a2ed -r d0327c39dff8 tools/Rules.mk
--- a/tools/Rules.mk Wed Oct 05 10:43:41 2011 +0100
+++ b/tools/Rules.mk Fri Oct 07 08:49:01 2011 +0100
@@ -3,6 +3,10 @@
# `all' is the default target
all:
+ifeq ($(filter /%,$(XEN_ROOT)),)
+$(error XEN_ROOT must be absolute)
+endif
+
include $(XEN_ROOT)/Config.mk
export _INSTALL := $(INSTALL)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Avoid relative XEN_ROOT specification
2011-10-07 7:51 ` Ian Campbell
@ 2011-10-07 7:55 ` Juergen Gross
2011-10-07 8:00 ` Keir Fraser
1 sibling, 0 replies; 5+ messages in thread
From: Juergen Gross @ 2011-10-07 7:55 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel@lists.xensource.com
On 10/07/2011 09:51 AM, Ian Campbell wrote:
> On Fri, 2011-10-07 at 05:42 +0100, Juergen Gross wrote:
>> XEN_ROOT must be set to an absolute path to avoid out of the tree references
> How about:
>
> # HG changeset patch
> # User Ian Campbell<ian.campbell@citrix.com>
> # Date 1317973741 -3600
> # Node ID d0327c39dff8abdc224e3c19f31e11f0fbeb5c16
> # Parent f17f0df2a2ede01a8c35dc4768a532a4438b1c02
> tools: error out on non-absolute $(XEN_ROOT)
>
> Signed-off-by: Ian Campbell<ian.campbell@citrix.com>
Acked-by: juergen.gross@ts.fujitsu.com
> diff -r f17f0df2a2ed -r d0327c39dff8 tools/Rules.mk
> --- a/tools/Rules.mk Wed Oct 05 10:43:41 2011 +0100
> +++ b/tools/Rules.mk Fri Oct 07 08:49:01 2011 +0100
> @@ -3,6 +3,10 @@
> # `all' is the default target
> all:
>
> +ifeq ($(filter /%,$(XEN_ROOT)),)
> +$(error XEN_ROOT must be absolute)
> +endif
> +
> include $(XEN_ROOT)/Config.mk
>
> export _INSTALL := $(INSTALL)
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
>
--
Juergen Gross Principal Developer Operating Systems
PDG ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28 Internet: ts.fujitsu.com
D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Avoid relative XEN_ROOT specification
2011-10-07 7:51 ` Ian Campbell
2011-10-07 7:55 ` Juergen Gross
@ 2011-10-07 8:00 ` Keir Fraser
2011-10-07 8:04 ` Ian Campbell
1 sibling, 1 reply; 5+ messages in thread
From: Keir Fraser @ 2011-10-07 8:00 UTC (permalink / raw)
To: Ian Campbell, Juergen Gross; +Cc: xen-devel@lists.xensource.com
On 07/10/2011 08:51, "Ian Campbell" <Ian.Campbell@citrix.com> wrote:
> On Fri, 2011-10-07 at 05:42 +0100, Juergen Gross wrote:
>> XEN_ROOT must be set to an absolute path to avoid out of the tree references
>
> How about:
>
> # HG changeset patch
> # User Ian Campbell <ian.campbell@citrix.com>
> # Date 1317973741 -3600
> # Node ID d0327c39dff8abdc224e3c19f31e11f0fbeb5c16
> # Parent f17f0df2a2ede01a8c35dc4768a532a4438b1c02
> tools: error out on non-absolute $(XEN_ROOT)
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Why not put this in root Config.mk? The restriction applies outside tools/
as well.
-- Keir
> diff -r f17f0df2a2ed -r d0327c39dff8 tools/Rules.mk
> --- a/tools/Rules.mk Wed Oct 05 10:43:41 2011 +0100
> +++ b/tools/Rules.mk Fri Oct 07 08:49:01 2011 +0100
> @@ -3,6 +3,10 @@
> # `all' is the default target
> all:
>
> +ifeq ($(filter /%,$(XEN_ROOT)),)
> +$(error XEN_ROOT must be absolute)
> +endif
> +
> include $(XEN_ROOT)/Config.mk
>
> export _INSTALL := $(INSTALL)
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Avoid relative XEN_ROOT specification
2011-10-07 8:00 ` Keir Fraser
@ 2011-10-07 8:04 ` Ian Campbell
0 siblings, 0 replies; 5+ messages in thread
From: Ian Campbell @ 2011-10-07 8:04 UTC (permalink / raw)
To: Keir Fraser; +Cc: Juergen Gross, xen-devel@lists.xensource.com
On Fri, 2011-10-07 at 09:00 +0100, Keir Fraser wrote:
> On 07/10/2011 08:51, "Ian Campbell" <Ian.Campbell@citrix.com> wrote:
>
> > On Fri, 2011-10-07 at 05:42 +0100, Juergen Gross wrote:
> >> XEN_ROOT must be set to an absolute path to avoid out of the tree references
> >
> > How about:
> >
> > # HG changeset patch
> > # User Ian Campbell <ian.campbell@citrix.com>
> > # Date 1317973741 -3600
> > # Node ID d0327c39dff8abdc224e3c19f31e11f0fbeb5c16
> > # Parent f17f0df2a2ede01a8c35dc4768a532a4438b1c02
> > tools: error out on non-absolute $(XEN_ROOT)
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> Why not put this in root Config.mk?
Didn't think of it...
> The restriction applies outside tools/ as well.
Seems to work.
# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1317974632 -3600
# Node ID 02be23c18197d1bdea51031efb8c69ce32bcd7b3
# Parent f17f0df2a2ede01a8c35dc4768a532a4438b1c02
tools: error out on non-absolute $(XEN_ROOT)
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
diff -r f17f0df2a2ed -r 02be23c18197 Config.mk
--- a/Config.mk Wed Oct 05 10:43:41 2011 +0100
+++ b/Config.mk Fri Oct 07 09:03:52 2011 +0100
@@ -1,5 +1,9 @@
# -*- mode: Makefile; -*-
+ifeq ($(filter /%,$(XEN_ROOT)),)
+$(error XEN_ROOT must be absolute)
+endif
+
-include $(XEN_ROOT)/.config
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-10-07 8:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-07 4:42 [PATCH] Avoid relative XEN_ROOT specification Juergen Gross
2011-10-07 7:51 ` Ian Campbell
2011-10-07 7:55 ` Juergen Gross
2011-10-07 8:00 ` Keir Fraser
2011-10-07 8:04 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.