From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: linux-iio@vger.kernel.org, Device-drivers-devel@blackfin.uclinux.org
Subject: Re: [PATCH] staging:iio: fix removal path to allow correct freeing.
Date: Tue, 11 Oct 2011 13:54:20 +0200 [thread overview]
Message-ID: <4E942E6C.4080001@metafoo.de> (raw)
In-Reply-To: <4E941167.8060403@cam.ac.uk>
On 10/11/2011 11:50 AM, Jonathan Cameron wrote:
> On 10/10/11 17:41, Jonathan Cameron wrote:
>> On 10/10/11 16:17, Jonathan Cameron wrote:
>>> Fix a dumb lack of consideration of the effect of combining
>>> the iio_device_unregister and iio_free_device calls into
>>> one. There is no valid place to free some of the sysfs
>>> array elements.
>> My continued testing indicates another dragon hiding somewhere.
>> It's of the that lovely type that causes segfaults scattered
>> all over the kernel. Will continue tomorrow.
> One dragon found. Stupid size of available_scanmasks bug
> on allocation in max1363. I'll send a patch out later.
>
> Now I can hammer probe and remove without problem.
>
> Testing from others of this patch would be welcomed.
>
> Jonathan
It seems to work fine under normal conditions, but I'm wondering if it is
possible to create a sitution in which we still have reference to the iio
device pending when we unbind the parent device. In this case
iio_free_device
would be called before iio_release_device.
- Lars
next prev parent reply other threads:[~2011-10-11 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 15:17 [PATCH] staging:iio: fix nasty freeing messup on exit Jonathan Cameron
2011-10-10 15:17 ` [PATCH] staging:iio: fix removal path to allow correct freeing Jonathan Cameron
2011-10-10 16:41 ` Jonathan Cameron
2011-10-11 9:50 ` Jonathan Cameron
2011-10-11 11:54 ` Lars-Peter Clausen [this message]
2011-10-11 15:07 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E942E6C.4080001@metafoo.de \
--to=lars@metafoo.de \
--cc=Device-drivers-devel@blackfin.uclinux.org \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.