From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: aliguori@us.ibm.com, joerg.roedel@amd.com, agraf@suse.de,
qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>,
eduard.munteanu@linux360.ro, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 1/9] Add stub functions for PCI device models to do PCI DMA
Date: Wed, 12 Oct 2011 11:08:17 +0200 [thread overview]
Message-ID: <4E955901.6090500@redhat.com> (raw)
In-Reply-To: <20111012084437.GC7514@redhat.com>
Hi,
>> Yes.. as do the stX_pci_dma() helpers. They assume LE, rather than
>> having two variants, because PCI is an LE spec, and all normal PCI
>> devices work in LE.
>
> IMO, not really. PCI devices do DMA any way they like. LE is
> probably more common because both ARM and x86 processors are LE.
Also having _le_ in the function name makes explicitly clear that the
functions read/write little endian values and byteswaps if needed, which
makes the code more readable. I'd suggest to add it even if there is no
need for a _be_ companion as devices needing that are rare.
cheers,
Gerd
next prev parent reply other threads:[~2011-10-12 9:08 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 4:34 [Qemu-devel] [0/9] Preliminary work for IOMMU emulation support; the easy bits (v2) David Gibson
2011-09-05 4:34 ` [Qemu-devel] [PATCH 1/9] Add stub functions for PCI device models to do PCI DMA David Gibson
2011-10-02 10:25 ` Michael S. Tsirkin
2011-10-02 10:29 ` Avi Kivity
2011-10-02 10:52 ` Michael S. Tsirkin
2011-10-02 10:58 ` Avi Kivity
2011-10-02 11:17 ` Michael S. Tsirkin
2011-10-02 11:28 ` Alexander Graf
2011-10-02 11:43 ` Michael S. Tsirkin
2011-10-02 12:01 ` Avi Kivity
2011-10-02 12:14 ` Michael S. Tsirkin
2011-10-02 12:26 ` Avi Kivity
2011-10-03 13:17 ` Anthony Liguori
2011-10-12 3:09 ` David Gibson
2011-10-12 9:12 ` Michael S. Tsirkin
2011-10-14 2:14 ` David Gibson
2011-10-16 12:50 ` Michael S. Tsirkin
2011-10-16 13:15 ` Avi Kivity
2011-10-18 1:46 ` David Gibson
2011-10-19 0:31 ` Rusty Russell
2011-10-19 1:22 ` Michael S. Tsirkin
2011-10-19 9:10 ` Avi Kivity
2011-10-20 2:58 ` David Gibson
2011-10-12 3:07 ` David Gibson
2011-10-12 7:22 ` Michael S. Tsirkin
2011-10-12 15:43 ` David Gibson
2011-10-12 15:45 ` David Gibson
2011-10-12 3:11 ` David Gibson
2011-10-12 8:44 ` Michael S. Tsirkin
2011-10-12 9:08 ` Gerd Hoffmann [this message]
2011-10-03 13:10 ` Anthony Liguori
2011-09-05 4:34 ` [Qemu-devel] [PATCH 2/9] rtl8139: Use PCI DMA stub functions David Gibson
2011-09-05 4:34 ` [Qemu-devel] [PATCH 3/9] eepro100: " David Gibson
2011-10-02 11:45 ` Michael S. Tsirkin
2011-10-14 2:15 ` David Gibson
2011-09-05 4:34 ` [Qemu-devel] [PATCH 4/9] ac97: " David Gibson
2011-09-05 4:35 ` [Qemu-devel] [PATCH 5/9] es1370: " David Gibson
2011-09-05 4:35 ` [Qemu-devel] [PATCH 6/9] e1000: " David Gibson
2011-09-05 4:35 ` [Qemu-devel] [PATCH 7/9] lsi53c895a: " David Gibson
2011-09-05 4:35 ` [Qemu-devel] [PATCH 8/9] pcnet-pci: " David Gibson
2011-09-05 4:35 ` [Qemu-devel] [PATCH 9/9] intel-hda: " David Gibson
2011-09-16 6:58 ` [Qemu-devel] [0/9] Preliminary work for IOMMU emulation support; the easy bits (v2) David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E955901.6090500@redhat.com \
--to=kraxel@redhat.com \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=eduard.munteanu@linux360.ro \
--cc=joerg.roedel@amd.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.