From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: balbi@ti.com
Cc: Tony Lindgren <tony@atomide.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFT/PATCH 7/7] arm: omap: smartreflex: micro-optimization for sanity check
Date: Wed, 12 Oct 2011 15:32:17 +0400 [thread overview]
Message-ID: <4E957AC1.904@ru.mvista.com> (raw)
In-Reply-To: <20111011121922.GM10155@legolas.emea.dhcp.ti.com>
Hello.
On 11-10-2011 16:19, Felipe Balbi wrote:
>> On 10-10-2011 16:26, Felipe Balbi wrote:
>>> val&& (val != 1) == val> 1
>>> Signed-off-by: Felipe Balbi<balbi@ti.com>
>>> ---
>>> arch/arm/mach-omap2/smartreflex.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
>>> index 7bdabfa..4b0d6a8 100644
>>> --- a/arch/arm/mach-omap2/smartreflex.c
>>> +++ b/arch/arm/mach-omap2/smartreflex.c
>>> @@ -866,7 +866,7 @@ static int omap_sr_autocomp_store(void *data, u64 val)
>>> }
>>>
>>> /* Sanity check */
>>> - if (val&& (val != 1)) {
>>> + if (val> 1) {
>>> pr_warning("%s: Invalid argument %lld\n", __func__, val);
>> The format specified should be "%llu"?
> and what does that have to do with $SUBJECT ??
Well, nothing. Just an idea for another patch I guess.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@ru.mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFT/PATCH 7/7] arm: omap: smartreflex: micro-optimization for sanity check
Date: Wed, 12 Oct 2011 15:32:17 +0400 [thread overview]
Message-ID: <4E957AC1.904@ru.mvista.com> (raw)
In-Reply-To: <20111011121922.GM10155@legolas.emea.dhcp.ti.com>
Hello.
On 11-10-2011 16:19, Felipe Balbi wrote:
>> On 10-10-2011 16:26, Felipe Balbi wrote:
>>> val&& (val != 1) == val> 1
>>> Signed-off-by: Felipe Balbi<balbi@ti.com>
>>> ---
>>> arch/arm/mach-omap2/smartreflex.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
>>> index 7bdabfa..4b0d6a8 100644
>>> --- a/arch/arm/mach-omap2/smartreflex.c
>>> +++ b/arch/arm/mach-omap2/smartreflex.c
>>> @@ -866,7 +866,7 @@ static int omap_sr_autocomp_store(void *data, u64 val)
>>> }
>>>
>>> /* Sanity check */
>>> - if (val&& (val != 1)) {
>>> + if (val> 1) {
>>> pr_warning("%s: Invalid argument %lld\n", __func__, val);
>> The format specified should be "%llu"?
> and what does that have to do with $SUBJECT ??
Well, nothing. Just an idea for another patch I guess.
WBR, Sergei
next prev parent reply other threads:[~2011-10-12 11:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 12:26 [RFT/PATCH 1/7] OMAP3+: PM: SR: add suspend/resume handlers Felipe Balbi
2011-10-10 12:26 ` Felipe Balbi
2011-10-10 12:26 ` [RFT/PATCH 2/7] arm: omap: smartreflex: add missing platform_set_drvdata() Felipe Balbi
2011-10-10 12:26 ` Felipe Balbi
2011-10-10 12:26 ` [RFT/PATCH 3/7] arm: omap: smartreflex: use dev_get_drvdata() Felipe Balbi
2011-10-10 12:26 ` Felipe Balbi
2011-10-10 12:26 ` [RFT/PATCH 4/7] arm: omap: smartreflex: move late_initcall() closer to its argument Felipe Balbi
2011-10-10 12:26 ` Felipe Balbi
2011-10-10 12:26 ` [RFT/PATCH 5/7] arm: omap: smartreflex: clean ups all over Felipe Balbi
2011-10-10 12:26 ` Felipe Balbi
2011-10-10 12:26 ` [RFT/PATCH 6/7] arm: omap: smartreflex: fix IRQ handling bug Felipe Balbi
2011-10-10 12:26 ` Felipe Balbi
2011-10-11 11:23 ` Sergei Shtylyov
2011-10-11 11:23 ` Sergei Shtylyov
2011-10-11 12:19 ` Felipe Balbi
2011-10-11 12:19 ` Felipe Balbi
2011-10-10 12:26 ` [RFT/PATCH 7/7] arm: omap: smartreflex: micro-optimization for sanity check Felipe Balbi
2011-10-10 12:26 ` Felipe Balbi
2011-10-11 11:22 ` Sergei Shtylyov
2011-10-11 11:22 ` Sergei Shtylyov
2011-10-11 12:19 ` Felipe Balbi
2011-10-11 12:19 ` Felipe Balbi
2011-10-12 11:32 ` Sergei Shtylyov [this message]
2011-10-12 11:32 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E957AC1.904@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.