From: Stefan Weil <sw@weilnetz.de>
To: Avi Kivity <avi@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] 2 MiB alignment in qemu_vmalloc()
Date: Wed, 12 Oct 2011 20:05:37 +0200 [thread overview]
Message-ID: <4E95D6F1.4070402@weilnetz.de> (raw)
Hello Avi,
commit 36b58628 increased the alignment for some large memory
blocks (typically the system RAM) to 2 MiB (QEMU_VMALLOC_ALIGN)
on x86_64 Linux hosts.
As far as I know, this was only required for KVM.
There is a bad side effect of this increase: the Valgrind tool
only supports an alignment of up to 1 MiB. It aborts execution
with current QEMU for any target (even non-KVM targets).
It might be possible to modify Valgrind (as far as I know this
is already discussed), and of course I can also patch my local
QEMU. Nevertheless, I think the alignment should be reduced
again when there is no KVM support or KVM is disabled.
Maybe the large alignment has other unwanted side effects.
The code is in oslib-posix.c (target independent) and needs
something like kvm_enabled() (currently a macro). What would
you suggest? Maybe you can provide a patch.
Kind regards,
Stefan
next reply other threads:[~2011-10-12 18:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 18:05 Stefan Weil [this message]
2011-10-12 20:02 ` [Qemu-devel] 2 MiB alignment in qemu_vmalloc() Alexander Graf
2011-10-12 20:41 ` Stefan Weil
2011-10-12 20:47 ` Alexander Graf
2011-10-12 21:19 ` Stefan Weil
2011-10-12 21:30 ` Alexander Graf
2011-10-13 7:56 ` Gerd Hoffmann
2011-10-13 13:23 ` Paolo Bonzini
2011-10-16 8:41 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E95D6F1.4070402@weilnetz.de \
--to=sw@weilnetz.de \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.