All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Alexander Graf <agraf@suse.de>
Cc: Avi Kivity <avi@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] 2 MiB alignment in qemu_vmalloc()
Date: Wed, 12 Oct 2011 22:41:35 +0200	[thread overview]
Message-ID: <4E95FB7F.2010303@weilnetz.de> (raw)
In-Reply-To: <D77A33DB-3BED-47C4-8056-0EC953DEAAD9@suse.de>

Am 12.10.2011 22:02, schrieb Alexander Graf:
> Actually, I'd much rather prefer to keep the differences between KVM 
> and non-KVM low here. THP can potentially also work on TCG, so the 
> alignment isn't completely moot here. Though it's certainly a lot less 
> useful, as code isn't directly executed from there and we the rest of 
> the overhead is a lot higher either way (especially the softmmu one).
> Either way, why does valgrind break when we enforce big alignment? That really sounds more like a valgrind bug than anything else. Memalign is there for exactly that reason, no?
>
>
> Alex

Actually, there is even a difference between KVM (x86_64) and KVM (non 
x86_64)
in the current code: only x86_64 hosts use the 2 MiB alignment.

Valgrind breaks because it has an assertion which limits the alignment.
This limitation was already discussed in 2008 and still exists in latest
Ubuntu and other distributions (and also in latest Valgrind SVN trunk).

Therefore I don't expect that it will be fixed soon.

See these bug reports, for example:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=489297
http://bugs.kde.org/show_bug.cgi?id=203877

Cheers,
Stefan

  reply	other threads:[~2011-10-12 20:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-12 18:05 [Qemu-devel] 2 MiB alignment in qemu_vmalloc() Stefan Weil
2011-10-12 20:02 ` Alexander Graf
2011-10-12 20:41   ` Stefan Weil [this message]
2011-10-12 20:47     ` Alexander Graf
2011-10-12 21:19       ` Stefan Weil
2011-10-12 21:30         ` Alexander Graf
2011-10-13  7:56         ` Gerd Hoffmann
2011-10-13 13:23           ` Paolo Bonzini
2011-10-16  8:41   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E95FB7F.2010303@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=agraf@suse.de \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.