From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Rajeshwari Shinde <rajeshwari.s@samsung.com>,
kgene.kim@samsung.com, linux-samsung-soc@vger.kernel.org,
linux-mmc@vger.kernel.org, cjb@laptop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V4 3/3] ARM: SAMSUNG: Add lookup of sdhci-s3c clocks using generic names
Date: Thu, 13 Oct 2011 11:40:33 +0200 [thread overview]
Message-ID: <4E96B211.1090908@samsung.com> (raw)
In-Reply-To: <20111013085521.GJ21648@n2100.arm.linux.org.uk>
On 10/13/2011 10:55 AM, Russell King - ARM Linux wrote:
> On Thu, Oct 13, 2011 at 09:55:04AM +0200, Sylwester Nawrocki wrote:
>> Yes, it allowed to add clkdev support with minimal changes required.
>>
>> But let's see what happens when the works on common struct clk for all
>> architectures are more or less completed and we convert Samsung platforms
>> to use it;)
>
> The common struct clk shouldn't have much to do with the clkdev part of
> it - clkdev just provides a method to associate a struct clk with the
> drivers request. The common struct clk doesn't change that.
Indeed. I was just wondering where we end up with the arch struct clk attribute
which is specific to clkdev processes.
It could just go into the hardware-specific data, although it doesn't sound
like a perfectly right approach.
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 3/3] ARM: SAMSUNG: Add lookup of sdhci-s3c clocks using generic names
Date: Thu, 13 Oct 2011 11:40:33 +0200 [thread overview]
Message-ID: <4E96B211.1090908@samsung.com> (raw)
In-Reply-To: <20111013085521.GJ21648@n2100.arm.linux.org.uk>
On 10/13/2011 10:55 AM, Russell King - ARM Linux wrote:
> On Thu, Oct 13, 2011 at 09:55:04AM +0200, Sylwester Nawrocki wrote:
>> Yes, it allowed to add clkdev support with minimal changes required.
>>
>> But let's see what happens when the works on common struct clk for all
>> architectures are more or less completed and we convert Samsung platforms
>> to use it;)
>
> The common struct clk shouldn't have much to do with the clkdev part of
> it - clkdev just provides a method to associate a struct clk with the
> drivers request. The common struct clk doesn't change that.
Indeed. I was just wondering where we end up with the arch struct clk attribute
which is specific to clkdev processes.
It could just go into the hardware-specific data, although it doesn't sound
like a perfectly right approach.
next prev parent reply other threads:[~2011-10-13 9:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 9:43 [PATCH V3 0/3] ARM: SAMSUNG: Add support for sdhci clock lookup using generic names Rajeshwari Shinde
2011-10-12 9:43 ` Rajeshwari Shinde
2011-10-12 9:43 ` [PATCH V3 1/3] SDHCI: S3C: Use generic clock names for sdhci bus clock options Rajeshwari Shinde
2011-10-12 9:43 ` Rajeshwari Shinde
2011-10-12 9:43 ` [PATCH V3 2/3] ARM: SAMSUNG: Remove SDHCI bus clocks from platform data Rajeshwari Shinde
2011-10-12 9:43 ` Rajeshwari Shinde
2011-10-12 9:43 ` [PATCH V4 3/3] ARM: SAMSUNG: Add lookup of sdhci-s3c clocks using generic names Rajeshwari Shinde
2011-10-12 9:43 ` Rajeshwari Shinde
2011-10-12 10:24 ` Sylwester Nawrocki
2011-10-12 10:24 ` Sylwester Nawrocki
2011-10-12 12:36 ` Rajeshwari Birje
2011-10-12 12:36 ` Rajeshwari Birje
2011-10-12 16:19 ` Sylwester Nawrocki
2011-10-12 16:19 ` Sylwester Nawrocki
2011-10-13 7:16 ` Rajeshwari Birje
2011-10-13 7:16 ` Rajeshwari Birje
2011-10-13 7:55 ` Sylwester Nawrocki
2011-10-13 7:55 ` Sylwester Nawrocki
2011-10-13 8:55 ` Russell King - ARM Linux
2011-10-13 8:55 ` Russell King - ARM Linux
2011-10-13 9:40 ` Sylwester Nawrocki [this message]
2011-10-13 9:40 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E96B211.1090908@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=cjb@laptop.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rajeshwari.s@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.