All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Bharat Bhushan <r65777@freescale.com>
Cc: kvm-ppc@vger.kernel.org, bharatb.yadav@gmail.com,
	Bharat Bhushan <bharat.bhushan@freescale.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH V2] PPC: Fix race in mtmsr paravirt implementation
Date: Thu, 13 Oct 2011 10:11:33 +0000	[thread overview]
Message-ID: <4E96B955.6090803@suse.de> (raw)
In-Reply-To: <1318499228-14372-1-git-send-email-bharat.bhushan@freescale.com>

On 10/13/2011 11:47 AM, Bharat Bhushan wrote:
> The current implementation of mtmsr and mtmsrd are racy in that it does:
>
>    * check (int_pending = 0)
>    --->  host sets int_pending = 1<---
>    * write shared page
>    * done
>
> while instead we should check for int_pending after the shared page is written.
>
> Signed-off-by: Bharat Bhushan<bharat.bhushan@freescale.com>

Thanks, applied to kvm-ppc-next.


Alex


WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Bharat Bhushan <r65777@freescale.com>
Cc: kvm-ppc@vger.kernel.org, bharatb.yadav@gmail.com,
	Bharat Bhushan <bharat.bhushan@freescale.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH V2] PPC: Fix race in mtmsr paravirt implementation
Date: Thu, 13 Oct 2011 12:11:33 +0200	[thread overview]
Message-ID: <4E96B955.6090803@suse.de> (raw)
In-Reply-To: <1318499228-14372-1-git-send-email-bharat.bhushan@freescale.com>

On 10/13/2011 11:47 AM, Bharat Bhushan wrote:
> The current implementation of mtmsr and mtmsrd are racy in that it does:
>
>    * check (int_pending == 0)
>    --->  host sets int_pending = 1<---
>    * write shared page
>    * done
>
> while instead we should check for int_pending after the shared page is written.
>
> Signed-off-by: Bharat Bhushan<bharat.bhushan@freescale.com>

Thanks, applied to kvm-ppc-next.


Alex


  reply	other threads:[~2011-10-13 10:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-13  9:59 [PATCH V2] PPC: Fix race in mtmsr paravirt implementation Bharat Bhushan
2011-10-13 10:11 ` Alexander Graf [this message]
2011-10-13 10:11   ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E96B955.6090803@suse.de \
    --to=agraf@suse.de \
    --cc=bharat.bhushan@freescale.com \
    --cc=bharatb.yadav@gmail.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=r65777@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.