All of lore.kernel.org
 help / color / mirror / Atom feed
From: Asias He <asias.hejun@gmail.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Ingo Molnar <mingo@elte.hu>,
	Sasha Levin <levinsasha928@gmail.com>,
	kvm@vger.kernel.org, gorcunov@gmail.com
Subject: Re: [PATCH 5/7] kvm tools: Add help and info messages to 'kvm setup'
Date: Fri, 14 Oct 2011 09:02:51 +0800	[thread overview]
Message-ID: <4E978A3B.5070608@gmail.com> (raw)
In-Reply-To: <CAOJsxLHDSLEV_Kx5TXY0ou0z-jL_Vy7dPpOHW3BO0YEsMmiK+g@mail.gmail.com>

On 10/14/2011 02:22 AM, Pekka Enberg wrote:
> On Thu, Oct 13, 2011 at 7:52 PM, Ingo Molnar <mingo@elte.hu> wrote:
>>>> Btw., will 'kvm run' select the last-created rootfs by default?
>>>
>>> No, it runs rootfs that's named 'default'. We can change that but
>>> I'm not completely convinced running that last-created rootfs is
>>> the right thing to do here. Hmm.
>>
>> I'm not convinced either - just wanted to raise the issue.
> 
> Right. So 'kvm run' is supposed to setup and launch a 'default' rootfs
> if no rootfs is specified.
> 
>> Also, i raised this in the other thread, why not use .kvmtool of the
>> current directory? That way it's cwd local like Git and perf. A 'kvm
>> run' (union?) mount the cwd or so - so this would be a natural
>> equivalent to chroot. The $HOME/.kvmtool is a Qemu-ish global
>> workflow.
> 
> Yeah, that definitely makes sense. 'kvm setup rootfs' wouldn't create
> rootfs under $HOME/.kvmtool/rootfs but under $(PWD)/rootfs.

I also think $(PWD)/rootfs is much better than $HOME/.kvmtool/rootfs.
I think 'kvm setup $absolute_rootfs_path' make sense as well.

> I guess we'll lose the ability to 'kvm list' all available rootfs
> directories, though?

User can create and put the rootfs directories where he/she likes. We do
not need to track where the rootfs directories is, thus we do not need
to 'kvm list' them.

-- 
Asias He

  reply	other threads:[~2011-10-14  1:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-13  9:32 [PATCH 1/7] kvm tools: Fix spelling mistake Sasha Levin
2011-10-13  9:32 ` [PATCH 2/7] kvm tools: Use compat message per device instead of per instance Sasha Levin
2011-10-13  9:32 ` [PATCH 3/7] kvm tools: Improve compat message Sasha Levin
2011-10-13  9:32 ` [PATCH 4/7] kvm tools: Add basic help when starting 'kvm' without args Sasha Levin
2011-10-13  9:32 ` [PATCH 5/7] kvm tools: Add help and info messages to 'kvm setup' Sasha Levin
2011-10-13 10:00   ` Ingo Molnar
2011-10-13 10:08     ` Sasha Levin
2011-10-13 16:38     ` Pekka Enberg
2011-10-13 16:52       ` Ingo Molnar
2011-10-13 18:22         ` Pekka Enberg
2011-10-14  1:02           ` Asias He [this message]
2011-10-14  6:08             ` Ingo Molnar
2011-10-14  6:20               ` Pekka Enberg
2011-10-14  6:51                 ` Ingo Molnar
2011-10-13  9:32 ` [PATCH 6/7] kvm tools: Modify 'kvm setup' parameters Sasha Levin
2011-10-13  9:32 ` [PATCH 7/7] kvm tools: Add option to list rootfs in 'kvm list' Sasha Levin
2011-10-13 16:40   ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E978A3B.5070608@gmail.com \
    --to=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=mingo@elte.hu \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.