From: Jens Axboe <axboe@kernel.dk>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: add a "struct page_frag" type containing a page, offset and length
Date: Fri, 14 Oct 2011 08:42:44 +0200 [thread overview]
Message-ID: <4E97D9E4.4090202@kernel.dk> (raw)
In-Reply-To: <1318500176-10728-1-git-send-email-ian.campbell@citrix.com>
On 2011-10-13 12:02, Ian Campbell wrote:
> A few network drivers currently use skb_frag_struct for this purpose but I have
> patches which add additional fields and semantics there which these other uses
> do not want.
>
> A structure for reference sub-page regions seems like a generally useful thing
> so do so instead of adding a network subsystem specific structure.
Looks good to me, I can switch struct bio_vec over to this once it's in.
Acked-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: add a "struct page_frag" type containing a page, offset and length
Date: Fri, 14 Oct 2011 08:42:44 +0200 [thread overview]
Message-ID: <4E97D9E4.4090202@kernel.dk> (raw)
In-Reply-To: <1318500176-10728-1-git-send-email-ian.campbell@citrix.com>
On 2011-10-13 12:02, Ian Campbell wrote:
> A few network drivers currently use skb_frag_struct for this purpose but I have
> patches which add additional fields and semantics there which these other uses
> do not want.
>
> A structure for reference sub-page regions seems like a generally useful thing
> so do so instead of adding a network subsystem specific structure.
Looks good to me, I can switch struct bio_vec over to this once it's in.
Acked-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-10-14 6:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 10:02 [PATCH] mm: add a "struct page_frag" type containing a page, offset and length Ian Campbell
2011-10-13 10:02 ` Ian Campbell
2011-10-13 20:33 ` David Rientjes
2011-10-13 20:33 ` David Rientjes
2011-10-13 20:37 ` David Miller
2011-10-13 20:37 ` David Miller
2011-10-13 20:49 ` David Rientjes
2011-10-13 20:49 ` David Rientjes
2011-10-13 20:51 ` David Miller
2011-10-13 20:51 ` David Miller
2011-10-13 21:22 ` Andrew Morton
2011-10-13 21:22 ` Andrew Morton
2011-10-14 6:56 ` Ian Campbell
2011-10-14 6:56 ` Ian Campbell
2011-10-18 8:49 ` Ian Campbell
2011-10-18 8:49 ` Ian Campbell
2011-10-20 5:36 ` David Rientjes
2011-10-20 5:36 ` David Rientjes
2011-10-20 5:44 ` Andrew Morton
2011-10-20 5:44 ` Andrew Morton
2011-10-20 8:59 ` David Miller
2011-10-20 8:59 ` David Miller
2011-10-20 9:04 ` Ian Campbell
2011-10-20 9:04 ` Ian Campbell
2011-10-14 6:42 ` Jens Axboe [this message]
2011-10-14 6:42 ` Jens Axboe
2011-10-14 9:17 ` David Rientjes
2011-10-14 9:17 ` David Rientjes
2011-10-14 9:54 ` Jens Axboe
2011-10-14 9:54 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E97D9E4.4090202@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=ian.campbell@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.