All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: [RFC PATCH] return -EINVAL when trying to kick/kill a nonexistent domain watchdog
Date: Fri, 14 Oct 2011 12:02:11 +0200	[thread overview]
Message-ID: <4E9808A3.9090501@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

... to be more in-line with the NR_DOMAIN_WATCHDOG_TIMERS check at the 
top of domain_watchdog(), and also to follow the timer_(delete|settime) 
POSIX API's EINVAL return value.

Signed-off-by: Laszlo Ersek <lersek@redhat.com>

[-- Attachment #2: einval_upstream.patch --]
[-- Type: text/plain, Size: 404 bytes --]

diff -r 4b0907c6a08c xen/common/schedule.c
--- a/xen/common/schedule.c	Tue Oct 11 12:02:58 2011 +0100
+++ b/xen/common/schedule.c	Fri Oct 14 11:55:00 2011 +0200
@@ -763,7 +763,7 @@ static long domain_watchdog(struct domai
     if ( !test_bit(id, &d->watchdog_inuse_map) )
     {
         spin_unlock(&d->watchdog_lock);
-        return -EEXIST;
+        return -EINVAL;
     }
 
     if ( timeout == 0 )

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

                 reply	other threads:[~2011-10-14 10:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E9808A3.9090501@redhat.com \
    --to=lersek@redhat.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.