* [BUG] remote-curl.c: honor pushurl
@ 2011-10-14 15:37 Michael Schubert
2011-10-14 15:48 ` Jeff King
0 siblings, 1 reply; 2+ messages in thread
From: Michael Schubert @ 2011-10-14 15:37 UTC (permalink / raw)
To: git; +Cc: rctay89
When doing a push (fetch, ..) over http(s), git calls git-remote-http to
communicate with the server.
git-remote-http <remote> [<url>]
Git correctly honors a configured pushurl and passes it to git-remote-http,
but git-remote-http is initiating the http connection with the url defined
for remote (remote->url) rather than the passed url. This undermines the
purpose of a config like
url = https://example.com/repo.git
pushurl = https://user@example.com/repo.git
Introduced around 888692b7 - CC'ing Tay Ray Chuan. (I don't know if it was
working before, though.)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [BUG] remote-curl.c: honor pushurl
2011-10-14 15:37 [BUG] remote-curl.c: honor pushurl Michael Schubert
@ 2011-10-14 15:48 ` Jeff King
0 siblings, 0 replies; 2+ messages in thread
From: Jeff King @ 2011-10-14 15:48 UTC (permalink / raw)
To: Michael Schubert; +Cc: git, rctay89
On Fri, Oct 14, 2011 at 05:37:40PM +0200, Michael Schubert wrote:
> When doing a push (fetch, ..) over http(s), git calls git-remote-http to
> communicate with the server.
>
> git-remote-http <remote> [<url>]
>
> Git correctly honors a configured pushurl and passes it to git-remote-http,
> but git-remote-http is initiating the http connection with the url defined
> for remote (remote->url) rather than the passed url. This undermines the
> purpose of a config like
>
> url = https://example.com/repo.git
> pushurl = https://user@example.com/repo.git
>
> Introduced around 888692b7 - CC'ing Tay Ray Chuan. (I don't know if it was
> working before, though.)
Already noticed and fixed last week.
See this thread, starting at the focused message.
http://thread.gmane.org/gmane.comp.version-control.git/182752/focus=182872
-Peff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-14 15:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-14 15:37 [BUG] remote-curl.c: honor pushurl Michael Schubert
2011-10-14 15:48 ` Jeff King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.