* [Qemu-trivial] [PATCH] target_sparc: Fix use of free() instead of g_free()
@ 2011-10-16 18:10 ` Stefan Weil
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Weil @ 2011-10-16 18:10 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Stefan Weil
This error was reported by cppcheck.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
target-sparc/helper.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-sparc/helper.c b/target-sparc/helper.c
index c80531a..ca9bf6b 100644
--- a/target-sparc/helper.c
+++ b/target-sparc/helper.c
@@ -1200,8 +1200,8 @@ static int cpu_sparc_register(CPUSPARCState *env, const char *cpu_model)
static void cpu_sparc_close(CPUSPARCState *env)
{
- free(env->def);
- free(env);
+ g_free(env->def);
+ g_free(env);
}
CPUSPARCState *cpu_sparc_init(const char *cpu_model)
--
1.7.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Qemu-devel] [PATCH] target_sparc: Fix use of free() instead of g_free()
@ 2011-10-16 18:10 ` Stefan Weil
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Weil @ 2011-10-16 18:10 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Stefan Weil
This error was reported by cppcheck.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
target-sparc/helper.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-sparc/helper.c b/target-sparc/helper.c
index c80531a..ca9bf6b 100644
--- a/target-sparc/helper.c
+++ b/target-sparc/helper.c
@@ -1200,8 +1200,8 @@ static int cpu_sparc_register(CPUSPARCState *env, const char *cpu_model)
static void cpu_sparc_close(CPUSPARCState *env)
{
- free(env->def);
- free(env);
+ g_free(env->def);
+ g_free(env);
}
CPUSPARCState *cpu_sparc_init(const char *cpu_model)
--
1.7.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] target_sparc: Fix use of free() instead of g_free()
2011-10-16 18:10 ` [Qemu-devel] " Stefan Weil
@ 2011-10-17 7:17 ` Ray Wang
-1 siblings, 0 replies; 4+ messages in thread
From: Ray Wang @ 2011-10-17 7:17 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
On 10/17/2011 02:10 AM, Stefan Weil wrote:
> This error was reported by cppcheck.
>
> Signed-off-by: Stefan Weil<sw@weilnetz.de>
> ---
> target-sparc/helper.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-sparc/helper.c b/target-sparc/helper.c
> index c80531a..ca9bf6b 100644
> --- a/target-sparc/helper.c
> +++ b/target-sparc/helper.c
> @@ -1200,8 +1200,8 @@ static int cpu_sparc_register(CPUSPARCState *env, const char *cpu_model)
>
> static void cpu_sparc_close(CPUSPARCState *env)
> {
> - free(env->def);
> - free(env);
> + g_free(env->def);
> + g_free(env);
> }
>
> CPUSPARCState *cpu_sparc_init(const char *cpu_model)
Reviewed-by: Ray Wang<raywang@linux.vnet.ibm.com>
--
Regards,
Ray Wang
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] target_sparc: Fix use of free() instead of g_free()
@ 2011-10-17 7:17 ` Ray Wang
0 siblings, 0 replies; 4+ messages in thread
From: Ray Wang @ 2011-10-17 7:17 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
On 10/17/2011 02:10 AM, Stefan Weil wrote:
> This error was reported by cppcheck.
>
> Signed-off-by: Stefan Weil<sw@weilnetz.de>
> ---
> target-sparc/helper.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-sparc/helper.c b/target-sparc/helper.c
> index c80531a..ca9bf6b 100644
> --- a/target-sparc/helper.c
> +++ b/target-sparc/helper.c
> @@ -1200,8 +1200,8 @@ static int cpu_sparc_register(CPUSPARCState *env, const char *cpu_model)
>
> static void cpu_sparc_close(CPUSPARCState *env)
> {
> - free(env->def);
> - free(env);
> + g_free(env->def);
> + g_free(env);
> }
>
> CPUSPARCState *cpu_sparc_init(const char *cpu_model)
Reviewed-by: Ray Wang<raywang@linux.vnet.ibm.com>
--
Regards,
Ray Wang
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-17 7:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-16 18:10 [Qemu-trivial] [PATCH] target_sparc: Fix use of free() instead of g_free() Stefan Weil
2011-10-16 18:10 ` [Qemu-devel] " Stefan Weil
2011-10-17 7:17 ` [Qemu-trivial] " Ray Wang
2011-10-17 7:17 ` Ray Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.