All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Vadim Rozenfeld <vrozenfe@redhat.com>
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH RFC v1 1/2] hyper-v: introduce Hyper-V support infrastructure.
Date: Mon, 17 Oct 2011 11:30:18 +0200	[thread overview]
Message-ID: <4E9BF5AA.9070501@redhat.com> (raw)
In-Reply-To: <1318843022-20344-2-git-send-email-vrozenfe@redhat.com>

Am 17.10.2011 11:17, schrieb Vadim Rozenfeld:
> with the following series of patches we are starting to implement
> some basic Microsoft Hyper-V Enlightenment functionality, like relaxed
> timing, spinlock, and virtual apic support.
> 
> For more Hyper-V related information please see:
> "Hypervisor Functional Specification v2.0: For Windows Server 2008 R2" at
> http://www.microsoft.com/download/en/details.aspx?displaylang=en&id=18673
> ---
>  Makefile.target                    |    2 +
>  default-configs/i386-softmmu.mak   |    1 +
>  default-configs/x86_64-softmmu.mak |    1 +
>  target-i386/cpuid.c                |   14 +++++++
>  target-i386/hyperv.c               |   69 ++++++++++++++++++++++++++++++++++++
>  target-i386/hyperv.h               |   30 +++++++++++++++
>  6 files changed, 117 insertions(+), 0 deletions(-)
>  create mode 100644 target-i386/hyperv.c
>  create mode 100644 target-i386/hyperv.h
> 
> diff --git a/Makefile.target b/Makefile.target
> index 40cc592..2c8e1b8 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -202,6 +202,8 @@ obj-$(CONFIG_NO_KVM) += kvm-stub.o
>  obj-y += memory.o
>  LIBS+=-lz
>  
> +obj-$(CONFIG_HYPERV) += hyperv.o
> +

The patch doesn't look to me as if it could build successfully without
CONFIG_HYPERV. An option with only one working value seems a bit pointless.

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Wolf <kwolf@redhat.com>
To: Vadim Rozenfeld <vrozenfe@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH RFC v1 1/2] hyper-v: introduce Hyper-V support infrastructure.
Date: Mon, 17 Oct 2011 11:30:18 +0200	[thread overview]
Message-ID: <4E9BF5AA.9070501@redhat.com> (raw)
In-Reply-To: <1318843022-20344-2-git-send-email-vrozenfe@redhat.com>

Am 17.10.2011 11:17, schrieb Vadim Rozenfeld:
> with the following series of patches we are starting to implement
> some basic Microsoft Hyper-V Enlightenment functionality, like relaxed
> timing, spinlock, and virtual apic support.
> 
> For more Hyper-V related information please see:
> "Hypervisor Functional Specification v2.0: For Windows Server 2008 R2" at
> http://www.microsoft.com/download/en/details.aspx?displaylang=en&id=18673
> ---
>  Makefile.target                    |    2 +
>  default-configs/i386-softmmu.mak   |    1 +
>  default-configs/x86_64-softmmu.mak |    1 +
>  target-i386/cpuid.c                |   14 +++++++
>  target-i386/hyperv.c               |   69 ++++++++++++++++++++++++++++++++++++
>  target-i386/hyperv.h               |   30 +++++++++++++++
>  6 files changed, 117 insertions(+), 0 deletions(-)
>  create mode 100644 target-i386/hyperv.c
>  create mode 100644 target-i386/hyperv.h
> 
> diff --git a/Makefile.target b/Makefile.target
> index 40cc592..2c8e1b8 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -202,6 +202,8 @@ obj-$(CONFIG_NO_KVM) += kvm-stub.o
>  obj-y += memory.o
>  LIBS+=-lz
>  
> +obj-$(CONFIG_HYPERV) += hyperv.o
> +

The patch doesn't look to me as if it could build successfully without
CONFIG_HYPERV. An option with only one working value seems a bit pointless.

Kevin

  reply	other threads:[~2011-10-17  9:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-17  9:17 [PATCH RFC v1 0/2] Initial support for Microsoft Hyper-V Vadim Rozenfeld
2011-10-17  9:17 ` [Qemu-devel] " Vadim Rozenfeld
2011-10-17  9:17 ` [PATCH RFC v1 1/2] hyper-v: introduce Hyper-V support infrastructure Vadim Rozenfeld
2011-10-17  9:17   ` [Qemu-devel] " Vadim Rozenfeld
2011-10-17  9:30   ` Kevin Wolf [this message]
2011-10-17  9:30     ` Kevin Wolf
2011-10-17  9:37   ` Jan Kiszka
2011-10-17  9:37     ` [Qemu-devel] " Jan Kiszka
2011-10-17  9:17 ` [PATCH RFC v1 2/2] hyper-v: initialize Hyper-V CPUID leafs Vadim Rozenfeld
2011-10-17  9:17   ` [Qemu-devel] " Vadim Rozenfeld
2011-10-17  9:40   ` Paolo Bonzini
2011-10-17  9:40     ` [Qemu-devel] " Paolo Bonzini
2011-10-17 10:41     ` Avi Kivity
2011-10-17 10:41       ` [Qemu-devel] " Avi Kivity
2011-10-17 10:42       ` Paolo Bonzini
2011-10-17 10:42         ` [Qemu-devel] " Paolo Bonzini
2011-10-17 13:57         ` Avi Kivity
2011-10-17 13:57           ` [Qemu-devel] " Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E9BF5AA.9070501@redhat.com \
    --to=kwolf@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vrozenfe@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.