From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, Dmitry Koshelev <karaghiozis@gmail.com>,
qemu-devel@nongnu.org, paul@codesourcery.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] arm gic saving/loading fix
Date: Mon, 17 Oct 2011 13:31:22 +0200 [thread overview]
Message-ID: <4E9C120A.7040508@suse.de> (raw)
In-Reply-To: <CAFEAcA_6gLx3sD5r0cperWBbjYDTgmn5V-7dkUj-8g+PFEZP5Q@mail.gmail.com>
Am 17.10.2011 13:17, schrieb Peter Maydell:
> On 17 October 2011 11:54, Andreas Färber <afaerber@suse.de> wrote:
>> Am 17.10.2011 12:48, schrieb Dmitry Koshelev:
>>> irq_target field saving/loading is in the wrong loop
>>>
>>> Signed-off-by: Dmitry Koshelev <karagiozis@gmail.com>
>>
>> Reviewed-by: Andreas Färber <afaerber@suse.de>
>
> Doesn't it need a vmstate version bump too?
Sorry, you're right. Still reading my way into savevm code. arm_gic fix
is correct but due to GIC_NIRQ vs. NUM_CPU(), no reordering of the code
can really avoid a version bump here.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746, AG Nürnberg
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, Dmitry Koshelev <karaghiozis@gmail.com>,
qemu-devel@nongnu.org, paul@codesourcery.com
Subject: Re: [Qemu-devel] [PATCH] arm gic saving/loading fix
Date: Mon, 17 Oct 2011 13:31:22 +0200 [thread overview]
Message-ID: <4E9C120A.7040508@suse.de> (raw)
In-Reply-To: <CAFEAcA_6gLx3sD5r0cperWBbjYDTgmn5V-7dkUj-8g+PFEZP5Q@mail.gmail.com>
Am 17.10.2011 13:17, schrieb Peter Maydell:
> On 17 October 2011 11:54, Andreas Färber <afaerber@suse.de> wrote:
>> Am 17.10.2011 12:48, schrieb Dmitry Koshelev:
>>> irq_target field saving/loading is in the wrong loop
>>>
>>> Signed-off-by: Dmitry Koshelev <karagiozis@gmail.com>
>>
>> Reviewed-by: Andreas Färber <afaerber@suse.de>
>
> Doesn't it need a vmstate version bump too?
Sorry, you're right. Still reading my way into savevm code. arm_gic fix
is correct but due to GIC_NIRQ vs. NUM_CPU(), no reordering of the code
can really avoid a version bump here.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746, AG Nürnberg
next prev parent reply other threads:[~2011-10-17 11:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 10:48 [Qemu-trivial] [Qemu-devel] [PATCH] arm gic saving/loading fix Dmitry Koshelev
2011-10-17 10:48 ` Dmitry Koshelev
2011-10-17 10:54 ` [Qemu-trivial] " Andreas Färber
2011-10-17 10:54 ` Andreas Färber
2011-10-17 11:17 ` [Qemu-trivial] " Peter Maydell
2011-10-17 11:17 ` Peter Maydell
2011-10-17 11:31 ` Andreas Färber [this message]
2011-10-17 11:31 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9C120A.7040508@suse.de \
--to=afaerber@suse.de \
--cc=karaghiozis@gmail.com \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.