Re: [PATCH 0/1] IMSM do not assume prev + current map in same state means reshape

[Jes Sorensen <Jes.Sorensen@redhat.com>]

On 10/18/11 09:09, Kwolek, Adam wrote:
> 
> 
>> -----Original Message-----
>> From: Jes.Sorensen@redhat.com [mailto:Jes.Sorensen@redhat.com]
>> I believe there is a bug in the current IMSM code. It makes the assumption
>> that if the state of the previous map and the current map are the same, it
>> means we are trying to reshape the array. However if you have a large array
>> and just installed on it, and it was still resyncing when you rebooted, it will
>> come up in the same state and 'mdadm -Aa' will fail with an error that it is
>> lacking a resync file.
>>
>> This is what prevents an update Fedora 15 system from booting, such as
>> https://bugzilla.redhat.com/show_bug.cgi?id=736387
>>
>> If I am missing something here, I'd appreciate to hear about it.
>>
>> Thanks,
>> Jes
> 
> 
> Hi,
> There is bug there as you pointed in your email, but it is already fixed in Neil's repository by commit :
> 	imsm: fix: stopped resync does not continue after auto-assemblation
> 	b601104eb4a4733a838fb86e9e279fed14ce9d3f
> 
> Your patch "IMSM do not assume prev + current map in same state means reshape" can break
> e.g chunk size migration when number of disks doesn't change. 
> 
> Correct fix is pointed above and it tests migration type.

Interesting, this fix went in just after I started doing my testing so I
don't seem to have it in my tree. Missed it by a day or two :(

I'll refresh and try it out.

Jes