All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Cc: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
	<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [RFC] [PATCH] ARM: tegra: emc: device tree bindings
Date: Wed, 19 Oct 2011 09:36:42 -0500	[thread overview]
Message-ID: <4E9EE07A.20301@gmail.com> (raw)
In-Reply-To: <CAOesGMj8TREZ94RFhE3Qy=eaytOuB0YKBWw6--HAERoMB9m7Qg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 10/18/2011 10:28 PM, Olof Johansson wrote:
> On Tue, Oct 18, 2011 at 7:37 PM, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> On 10/18/2011 04:01 PM, Stephen Warren wrote:
>>> I only suggested the well-known-named sub-nodes in order to eliminate
>>> the need for a compatible property.
>>>
>>> My inclination is that if we use compatible to distinguish the tables
>>> from anything else, there's little point having the extra level of nodes;
>>> we may as well lay it out as in your original patch, just with an explicit
>>> nvidia,ram-code property in each table (or omitted/ignored when not using
>>> it) instead of reg?
>>
>> Node names should be generic like serial or ethernet. Compatible is used
>> to specify the specific model.
> 
> In cases where unit addresses can be used to separate out identical
> entries, yes. For something like this, there's no logical addressing
> of the tables so something else must be used to distinguish them.

Using the frequency as was previously proposed would work assuming that
is unique.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] [PATCH] ARM: tegra: emc: device tree bindings
Date: Wed, 19 Oct 2011 09:36:42 -0500	[thread overview]
Message-ID: <4E9EE07A.20301@gmail.com> (raw)
In-Reply-To: <CAOesGMj8TREZ94RFhE3Qy=eaytOuB0YKBWw6--HAERoMB9m7Qg@mail.gmail.com>

On 10/18/2011 10:28 PM, Olof Johansson wrote:
> On Tue, Oct 18, 2011 at 7:37 PM, Rob Herring <robherring2@gmail.com> wrote:
>> On 10/18/2011 04:01 PM, Stephen Warren wrote:
>>> I only suggested the well-known-named sub-nodes in order to eliminate
>>> the need for a compatible property.
>>>
>>> My inclination is that if we use compatible to distinguish the tables
>>> from anything else, there's little point having the extra level of nodes;
>>> we may as well lay it out as in your original patch, just with an explicit
>>> nvidia,ram-code property in each table (or omitted/ignored when not using
>>> it) instead of reg?
>>
>> Node names should be generic like serial or ethernet. Compatible is used
>> to specify the specific model.
> 
> In cases where unit addresses can be used to separate out identical
> entries, yes. For something like this, there's no logical addressing
> of the tables so something else must be used to distinguish them.

Using the frequency as was previously proposed would work assuming that
is unique.

Rob

  parent reply	other threads:[~2011-10-19 14:36 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-17 17:52 [RFC] [PATCH] ARM: tegra: emc: device tree bindings Olof Johansson
2011-10-17 17:52 ` Olof Johansson
     [not found] ` <1318873976-25335-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-10-17 18:16   ` Anton Staaf
2011-10-17 18:16     ` Anton Staaf
2011-10-18 18:30   ` Stephen Warren
2011-10-18 18:30     ` Stephen Warren
     [not found]     ` <74CDBE0F657A3D45AFBB94109FB122FF173CA2CBFB-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-10-18 18:42       ` Olof Johansson
2011-10-18 18:42         ` Olof Johansson
     [not found]         ` <CAOesGMh387Oghyd_TobnTOja6tU2uU5kt-86_HwQe7nFiL+svw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-10-18 18:54           ` Stephen Warren
2011-10-18 18:54             ` Stephen Warren
     [not found]             ` <74CDBE0F657A3D45AFBB94109FB122FF173CA2CC18-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-10-18 20:53               ` Olof Johansson
2011-10-18 20:53                 ` Olof Johansson
     [not found]                 ` <CAOesGMghu6Bn3RrFKEUBKkUNS_K8Y0ho3Y2uFZh_LXbfT80hFw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-10-18 21:01                   ` Stephen Warren
2011-10-18 21:01                     ` Stephen Warren
     [not found]                     ` <74CDBE0F657A3D45AFBB94109FB122FF173CA2CCA9-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-10-19  2:37                       ` Rob Herring
2011-10-19  2:37                         ` Rob Herring
     [not found]                         ` <4E9E3801.6080707-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-10-19  3:28                           ` Olof Johansson
2011-10-19  3:28                             ` Olof Johansson
     [not found]                             ` <CAOesGMj8TREZ94RFhE3Qy=eaytOuB0YKBWw6--HAERoMB9m7Qg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-10-19 14:31                               ` Segher Boessenkool
2011-10-19 14:31                                 ` Segher Boessenkool
2011-10-19 14:36                               ` Rob Herring [this message]
2011-10-19 14:36                                 ` Rob Herring
     [not found]                                 ` <4E9EE07A.20301-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-10-19 15:06                                   ` Olof Johansson
2011-10-19 15:06                                     ` Olof Johansson
     [not found]                                     ` <CAOesGMhfAxrG4pMQ86XFzmBnHwBgrD=45eTvmA0-G2gTjaSL6Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-10-19 15:11                                       ` Stephen Warren
2011-10-19 15:11                                         ` Stephen Warren
     [not found]                                         ` <74CDBE0F657A3D45AFBB94109FB122FF173D51BDEB-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-10-19 15:19                                           ` Olof Johansson
2011-10-19 15:19                                             ` Olof Johansson
2011-10-19 20:13                                       ` Segher Boessenkool
2011-10-19 20:13                                         ` Segher Boessenkool
     [not found]                                         ` <E8310825-036A-4541-9D8F-6DCED9CA88AA-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2011-10-19 20:17                                           ` Stephen Warren
2011-10-19 20:17                                             ` Stephen Warren
2011-10-19 20:17                                           ` Olof Johansson
2011-10-19 20:17                                             ` Olof Johansson
2011-10-19  3:28                       ` Olof Johansson
2011-10-19  3:28                         ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E9EE07A.20301@gmail.com \
    --to=robherring2-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
    --cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.