All of lore.kernel.org
 help / color / mirror / Atom feed
From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] [ALSA] hwdep: silence integer overflow warning
Date: Thu, 20 Oct 2011 07:39:23 +0000	[thread overview]
Message-ID: <4E9FD02B.6030307@bfs.de> (raw)
In-Reply-To: <20111020060910.GA6101@elgon.mountain>



Am 20.10.2011 08:09, schrieb Dan Carpenter:
> Smatch complains that if device is INT_MAX then device + 1 can
> overflow.  It just means we would have an annoying loop while we
> check all the devices from -2147483648 to SNDRV_MINOR_HWDEPS.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/sound/core/hwdep.c b/sound/core/hwdep.c
> index c7ceb28..edfdf6d 100644
> --- a/sound/core/hwdep.c
> +++ b/sound/core/hwdep.c
> @@ -273,7 +273,14 @@ static int snd_hwdep_control_ioctl(struct snd_card *card,
>  			if (get_user(device, (int __user *)arg))
>  				return -EFAULT;
>  			mutex_lock(&register_mutex);
> -			device = device < 0 ? 0 : device + 1;
> +
> +			if (device < 0)
> +				device = 0;
> +			else if (device > SNDRV_MINOR_HWDEPS)
> +				device = SNDRV_MINOR_HWDEPS;
> +			else
> +				device++;
> +
>  			while (device < SNDRV_MINOR_HWDEPS) {
>  				if (snd_hwdep_search(card, device))
>  					break;

I am not sure how SNDRV_MINOR_HWDEPS is used further but:
		else if (device < SNDRV_MINOR_HWDEPS)
				device++;
	        else
	              device = SNDRV_MINOR_HWDEPS;

that cuts the corner case device = SNDRV_MINOR_HWDEPS.

re,
 wh



> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

  reply	other threads:[~2011-10-20  7:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-20  6:09 [patch] [ALSA] hwdep: silence integer overflow warning Dan Carpenter
2011-10-20  6:09 ` Dan Carpenter
2011-10-20  7:39 ` walter harms [this message]
2011-10-28  6:45   ` Dan Carpenter
2011-10-28  6:45     ` Dan Carpenter
2011-10-28  7:33     ` walter harms
2011-10-28  7:33       ` walter harms
2011-10-28  8:55       ` Dan Carpenter
2011-10-28  8:55         ` Dan Carpenter
2011-10-28  6:46   ` [patch v2] " Dan Carpenter
2011-10-28  6:46     ` Dan Carpenter
2011-10-31  8:55     ` Takashi Iwai
2011-10-31  8:55       ` [alsa-devel] " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E9FD02B.6030307@bfs.de \
    --to=wharms@bfs.de \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.