From: walter harms <wharms@bfs.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Takashi Iwai <tiwai@suse.de>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [ALSA] hwdep: silence integer overflow warning
Date: Fri, 28 Oct 2011 09:33:11 +0200 [thread overview]
Message-ID: <4EAA5AB7.9000903@bfs.de> (raw)
In-Reply-To: <20111028064525.GA14707@longonot.mountain>
Am 28.10.2011 08:45, schrieb Dan Carpenter:
> On Thu, Oct 20, 2011 at 09:39:23AM +0200, walter harms wrote:
>> I am not sure how SNDRV_MINOR_HWDEPS is used further
>
> Either device = SNDRV_MINOR_HWDEPS or device = SNDRV_MINOR_HWDEPS + 1
> are fine (equivalent) but it's a fair point. Your version is nicer.
>
> I'll redo the patch.
>
An other question is:
Should the user be informed that the device is modified ?
The Problem i see is that a user parameter is silently modified
and buggy code will come through.
re,
wh
WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Takashi Iwai <tiwai@suse.de>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [ALSA] hwdep: silence integer overflow warning
Date: Fri, 28 Oct 2011 07:33:11 +0000 [thread overview]
Message-ID: <4EAA5AB7.9000903@bfs.de> (raw)
In-Reply-To: <20111028064525.GA14707@longonot.mountain>
Am 28.10.2011 08:45, schrieb Dan Carpenter:
> On Thu, Oct 20, 2011 at 09:39:23AM +0200, walter harms wrote:
>> I am not sure how SNDRV_MINOR_HWDEPS is used further
>
> Either device = SNDRV_MINOR_HWDEPS or device = SNDRV_MINOR_HWDEPS + 1
> are fine (equivalent) but it's a fair point. Your version is nicer.
>
> I'll redo the patch.
>
An other question is:
Should the user be informed that the device is modified ?
The Problem i see is that a user parameter is silently modified
and buggy code will come through.
re,
wh
next prev parent reply other threads:[~2011-10-28 7:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 6:09 [patch] [ALSA] hwdep: silence integer overflow warning Dan Carpenter
2011-10-20 6:09 ` Dan Carpenter
2011-10-20 7:39 ` walter harms
2011-10-28 6:45 ` Dan Carpenter
2011-10-28 6:45 ` Dan Carpenter
2011-10-28 7:33 ` walter harms [this message]
2011-10-28 7:33 ` walter harms
2011-10-28 8:55 ` Dan Carpenter
2011-10-28 8:55 ` Dan Carpenter
2011-10-28 6:46 ` [patch v2] " Dan Carpenter
2011-10-28 6:46 ` Dan Carpenter
2011-10-31 8:55 ` Takashi Iwai
2011-10-31 8:55 ` [alsa-devel] " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAA5AB7.9000903@bfs.de \
--to=wharms@bfs.de \
--cc=alsa-devel@alsa-project.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.