Re: [Qemu-devel] [PATCH] hw/9pfs: Fix broken compilation caused by wrong trace events

[Stefan Weil <sw@weilnetz.de>]

Am 20.10.2011 21:48, schrieb Stefan Weil:
> Commit c572f23a3e7180dbeab5e86583e43ea2afed6271 added trace events
> with mismatching format string and arguments.
>
> gcc reports these errors:
>
> In file included from trace.c:2:0:
> trace.h: In function ‘trace_v9fs_attach’:
> trace.h:2850:9: error: too many arguments for format [-Werror=format-extra-args]
> trace.h: In function ‘trace_v9fs_wstat’:
> trace.h:3039:9: error: too many arguments for format [-Werror=format-extra-args]
> trace.h: In function ‘trace_v9fs_mkdir’:
> trace.h:3088:9: error: too many arguments for format [-Werror=format-extra-args]
> trace.h: In function ‘trace_v9fs_mkdir_return’:
> trace.h:3095:9: error: too many arguments for format [-Werror=format-extra-args]
>
> Fix the format strings and also use %u instead of %d for unsigned values
> in the changed strings. There are more minor errors of this kind
> which I did not fix because that would make the review more difficult.
>
> Cc: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  trace-events |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/trace-events b/trace-events
> index fc13733..bd9c5de 100644
> --- a/trace-events
> +++ b/trace-events
...
> +v9fs_mkdir_return(uint16_t tag, uint8_t id, int8_t type, int32_t version, int64_t path, int err) "tag %u id %u qid={type %d version %d path %"PRId64" err %d}"
>

The position of } was wrong here. Please ignore this patch, I'll send a
new one.

- Stefan W.