All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 4/6] tcg: Add interpreter for bytecode
Date: Fri, 21 Oct 2011 08:03:33 +0200	[thread overview]
Message-ID: <4EA10B35.4080802@weilnetz.de> (raw)
In-Reply-To: <alpine.LNX.2.00.1110210133160.5076@linmac>

Am 20.10.2011 23:36, schrieb malc:
> On Thu, 20 Oct 2011, Stefan Weil wrote:
>
> [..snip..]
>
>> +/* Trace message to see program flow. */
>> +#if defined(CONFIG_DEBUG_TCG_INTERPRETER)
>> +#define TRACE() \
>> +    loglevel \
>> +    ? fprintf(stderr, "TCG %s:%u: %s()\n", __FILE__, __LINE__, __func__) \
>> +    : (void)0
> This is wrong, fprintf's return value is int and not void. Similar issue
> was present today on comp.std.c
> http://groups.google.com/group/comp.std.c/browse_thread/thread/4e01fece59a80572#
>
> [..snip..]

You are right, but it does not matter. TRACE() is never used in
assignments, and gcc accepts the statement as it is.

Nevertheless, I' ll fix it in the next release.

Thanks,
Stefan

  reply	other threads:[~2011-10-21  6:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-20 21:11 [Qemu-devel] [PATCH v2 0/6] tcg/interpreter: Add TCG + interpreter for bytecode Stefan Weil
2011-10-20 21:11 ` [Qemu-devel] [PATCH v2 1/6] tcg: TCG targets may define tcg_qemu_tb_exec Stefan Weil
2011-10-20 21:11 ` [Qemu-devel] [PATCH v2 2/6] tcg: Make ARRAY_SIZE(tcg_op_defs) globally available Stefan Weil
2011-10-20 21:11 ` [Qemu-devel] [PATCH v2 3/6] tcg: Add bytecode generator for tcg interpreter Stefan Weil
2011-10-20 21:11 ` [Qemu-devel] [PATCH v2 4/6] tcg: Add interpreter for bytecode Stefan Weil
2011-10-20 21:36   ` malc
2011-10-21  6:03     ` Stefan Weil [this message]
2011-10-20 21:11 ` [Qemu-devel] [PATCH v2 5/6] tcg: Add tci disassembler Stefan Weil
2011-10-20 21:11 ` [Qemu-devel] [PATCH v2 6/6] tcg: Add tcg interpreter to configure / make Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA10B35.4080802@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=av1474@comtv.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.