From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Pavel Borzenkov <pavel.borzenkov@gmail.com>
Subject: Re: [Qemu-trivial] [PATCH] qed: don't pass NULL to memcpy
Date: Fri, 21 Oct 2011 08:35:16 +0200 [thread overview]
Message-ID: <4EA112A4.5000106@redhat.com> (raw)
In-Reply-To: <20111020172301.GA14359@stefanha-thinkpad.localdomain>
On 10/20/2011 07:23 PM, Stefan Hajnoczi wrote:
> On Tue, Oct 18, 2011 at 09:17:35PM +0400, Pavel Borzenkov wrote:
>> Spotted by Clang Analyzer
>>
>> Signed-off-by: Pavel Borzenkov<pavel.borzenkov@gmail.com>
>> ---
>> block/qed.c | 6 ++++--
>> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> Thanks, applied to the trivial patches tree:
> http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches
I think there are other places in the tree where we assume that
"memcpy(dest, NULL, 0);" works.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Pavel Borzenkov <pavel.borzenkov@gmail.com>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] qed: don't pass NULL to memcpy
Date: Fri, 21 Oct 2011 08:35:16 +0200 [thread overview]
Message-ID: <4EA112A4.5000106@redhat.com> (raw)
In-Reply-To: <20111020172301.GA14359@stefanha-thinkpad.localdomain>
On 10/20/2011 07:23 PM, Stefan Hajnoczi wrote:
> On Tue, Oct 18, 2011 at 09:17:35PM +0400, Pavel Borzenkov wrote:
>> Spotted by Clang Analyzer
>>
>> Signed-off-by: Pavel Borzenkov<pavel.borzenkov@gmail.com>
>> ---
>> block/qed.c | 6 ++++--
>> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> Thanks, applied to the trivial patches tree:
> http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches
I think there are other places in the tree where we assume that
"memcpy(dest, NULL, 0);" works.
Paolo
next prev parent reply other threads:[~2011-10-21 6:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 17:17 [Qemu-trivial] [PATCH] qed: don't pass NULL to memcpy Pavel Borzenkov
2011-10-18 17:17 ` [Qemu-devel] " Pavel Borzenkov
2011-10-20 17:23 ` [Qemu-trivial] " Stefan Hajnoczi
2011-10-20 17:23 ` [Qemu-devel] " Stefan Hajnoczi
2011-10-21 6:35 ` Paolo Bonzini [this message]
2011-10-21 6:35 ` Paolo Bonzini
2011-10-21 8:31 ` [Qemu-trivial] [Qemu-devel] " Markus Armbruster
2011-10-21 8:31 ` [Qemu-devel] [Qemu-trivial] " Markus Armbruster
2011-10-21 9:06 ` [Qemu-trivial] [Qemu-devel] " Pavel Borzenkov
2011-10-21 9:06 ` [Qemu-devel] [Qemu-trivial] " Pavel Borzenkov
2011-10-21 9:08 ` [Qemu-trivial] [Qemu-devel] " Pavel Borzenkov
2011-10-21 9:08 ` [Qemu-devel] [Qemu-trivial] " Pavel Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA112A4.5000106@redhat.com \
--to=pbonzini@redhat.com \
--cc=pavel.borzenkov@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.