* [U-Boot] [PATCH 1/2] rtc: Make mc13783-rtc driver generic
@ 2011-10-24 16:37 Fabio Estevam
2011-10-24 16:37 ` [U-Boot] [PATCH 2/2] mx51evk: Add RTC support Fabio Estevam
2011-10-25 8:03 ` [U-Boot] [PATCH 1/2] rtc: Make mc13783-rtc driver generic Stefano Babic
0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2011-10-24 16:37 UTC (permalink / raw)
To: u-boot
Rename mc13783-rtc so that it can be used for both MC13783 and MC13892 PMICs.
efikamx board, for example, does use a MC13892 PMIC, but the RTC selection is currently made as:
#define CONFIG_RTC_MC13783
,which is not very obvious.
Let the MC13783 and MC13892 RTC be selected by:
#define CONFIG_RTC_MC13XXX
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
README | 2 +-
drivers/rtc/Makefile | 2 +-
include/configs/efikamx.h | 2 +-
include/configs/imx31_litekit.h | 2 +-
include/configs/mx31ads.h | 2 +-
include/configs/mx31pdk.h | 2 +-
include/configs/qong.h | 2 +-
include/configs/vision2.h | 2 +-
8 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/README b/README
index eb9ade9..1e20452 100644
--- a/README
+++ b/README
@@ -841,7 +841,7 @@ The following options need to be configured:
CONFIG_RTC_MPC8xx - use internal RTC of MPC8xx
CONFIG_RTC_PCF8563 - use Philips PCF8563 RTC
- CONFIG_RTC_MC13783 - use MC13783 RTC
+ CONFIG_RTC_MC13XXX - use MC13783 or MC13892 RTC
CONFIG_RTC_MC146818 - use MC146818 RTC
CONFIG_RTC_DS1307 - use Maxim, Inc. DS1307 RTC
CONFIG_RTC_DS1337 - use Maxim, Inc. DS1337 RTC
diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile
index df440c6..a16f590 100644
--- a/drivers/rtc/Makefile
+++ b/drivers/rtc/Makefile
@@ -50,7 +50,7 @@ COBJS-$(CONFIG_RTC_M41T62) += m41t62.o
COBJS-$(CONFIG_RTC_M41T94) += m41t94.o
COBJS-$(CONFIG_RTC_M48T35A) += m48t35ax.o
COBJS-$(CONFIG_RTC_MAX6900) += max6900.o
-COBJS-$(CONFIG_RTC_MC13783) += mc13783-rtc.o
+COBJS-$(CONFIG_RTC_MC13XXX) += mc13xxx-rtc.o
COBJS-$(CONFIG_RTC_MC146818) += mc146818.o
COBJS-$(CONFIG_MCFRTC) += mcfrtc.o
COBJS-$(CONFIG_RTC_MK48T59) += mk48t59.o
diff --git a/include/configs/efikamx.h b/include/configs/efikamx.h
index 7e4b424..68bede9 100644
--- a/include/configs/efikamx.h
+++ b/include/configs/efikamx.h
@@ -132,7 +132,7 @@
#define CONFIG_FSL_PMIC_CLK 25000000
#define CONFIG_FSL_PMIC_MODE (SPI_MODE_0 | SPI_CS_HIGH)
#define CONFIG_FSL_PMIC_BITLEN 32
-#define CONFIG_RTC_MC13783
+#define CONFIG_RTC_MC13XXX
#endif
/*
diff --git a/include/configs/imx31_litekit.h b/include/configs/imx31_litekit.h
index 89e71c0..1455ea2 100644
--- a/include/configs/imx31_litekit.h
+++ b/include/configs/imx31_litekit.h
@@ -81,7 +81,7 @@
#define CONFIG_FSL_PMIC_CLK 1000000
#define CONFIG_FSL_PMIC_MODE (SPI_MODE_0 | SPI_CS_HIGH)
#define CONFIG_FSL_PMIC_BITLEN 32
-#define CONFIG_RTC_MC13783
+#define CONFIG_RTC_MC13XXX
/* allow to overwrite serial and ethaddr */
#define CONFIG_ENV_OVERWRITE
diff --git a/include/configs/mx31ads.h b/include/configs/mx31ads.h
index c9d80ef..7e011ae 100644
--- a/include/configs/mx31ads.h
+++ b/include/configs/mx31ads.h
@@ -78,7 +78,7 @@
#define CONFIG_FSL_PMIC_CLK 1000000
#define CONFIG_FSL_PMIC_MODE (SPI_MODE_0 | SPI_CS_HIGH)
#define CONFIG_FSL_PMIC_BITLEN 32
-#define CONFIG_RTC_MC13783
+#define CONFIG_RTC_MC13XXX
/* allow to overwrite serial and ethaddr */
#define CONFIG_ENV_OVERWRITE
diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h
index b72f30b..9d64827 100644
--- a/include/configs/mx31pdk.h
+++ b/include/configs/mx31pdk.h
@@ -79,7 +79,7 @@
#define CONFIG_FSL_PMIC_CLK 1000000
#define CONFIG_FSL_PMIC_MODE (SPI_MODE_0 | SPI_CS_HIGH)
#define CONFIG_FSL_PMIC_BITLEN 32
-#define CONFIG_RTC_MC13783
+#define CONFIG_RTC_MC13XXX
/* allow to overwrite serial and ethaddr */
#define CONFIG_ENV_OVERWRITE
diff --git a/include/configs/qong.h b/include/configs/qong.h
index 4820914..4409186 100644
--- a/include/configs/qong.h
+++ b/include/configs/qong.h
@@ -58,7 +58,7 @@
#define CONFIG_MXC_SPI
#define CONFIG_DEFAULT_SPI_BUS 1
#define CONFIG_DEFAULT_SPI_MODE (SPI_MODE_0 | SPI_CS_HIGH)
-#define CONFIG_RTC_MC13783
+#define CONFIG_RTC_MC13XXX
#define CONFIG_PMIC
#define CONFIG_PMIC_SPI
diff --git a/include/configs/vision2.h b/include/configs/vision2.h
index a2a9f3f..5a4cd66 100644
--- a/include/configs/vision2.h
+++ b/include/configs/vision2.h
@@ -95,7 +95,7 @@
#define CONFIG_FSL_PMIC_CLK 2500000
#define CONFIG_FSL_PMIC_MODE SPI_MODE_0
#define CONFIG_FSL_PMIC_BITLEN 32
-#define CONFIG_RTC_MC13783
+#define CONFIG_RTC_MC13XXX
/*
* MMC Configs
--
1.6.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 2/2] mx51evk: Add RTC support
2011-10-24 16:37 [U-Boot] [PATCH 1/2] rtc: Make mc13783-rtc driver generic Fabio Estevam
@ 2011-10-24 16:37 ` Fabio Estevam
2011-10-25 8:04 ` Stefano Babic
2011-10-25 8:03 ` [U-Boot] [PATCH 1/2] rtc: Make mc13783-rtc driver generic Stefano Babic
1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2011-10-24 16:37 UTC (permalink / raw)
To: u-boot
MX51EVK has a MC13892 PMIC. Add RTC support.
Tested via 'date' command that reads the PMIC RTC registers:
MX51EVK U-Boot > date
Date: 1970-01-01 (Thursday) Time: 0:40:35
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
include/configs/mx51evk.h | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/include/configs/mx51evk.h b/include/configs/mx51evk.h
index 2c449b8..67b5f0b 100644
--- a/include/configs/mx51evk.h
+++ b/include/configs/mx51evk.h
@@ -79,6 +79,7 @@
#define CONFIG_FSL_PMIC_CLK 2500000
#define CONFIG_FSL_PMIC_MODE (SPI_MODE_0 | SPI_CS_HIGH)
#define CONFIG_FSL_PMIC_BITLEN 32
+#define CONFIG_RTC_MC13XXX
/*
* MMC Configs
@@ -124,6 +125,8 @@
#undef CONFIG_CMD_IMLS
+#define CONFIG_CMD_DATE
+
#define CONFIG_BOOTDELAY 3
#define CONFIG_ETHPRIME "FEC0"
--
1.6.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 1/2] rtc: Make mc13783-rtc driver generic
2011-10-24 16:37 [U-Boot] [PATCH 1/2] rtc: Make mc13783-rtc driver generic Fabio Estevam
2011-10-24 16:37 ` [U-Boot] [PATCH 2/2] mx51evk: Add RTC support Fabio Estevam
@ 2011-10-25 8:03 ` Stefano Babic
1 sibling, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2011-10-25 8:03 UTC (permalink / raw)
To: u-boot
On 10/24/2011 06:37 PM, Fabio Estevam wrote:
> Rename mc13783-rtc so that it can be used for both MC13783 and MC13892 PMICs.
>
> efikamx board, for example, does use a MC13892 PMIC, but the RTC selection is currently made as:
>
> #define CONFIG_RTC_MC13783
>
> ,which is not very obvious.
>
> Let the MC13783 and MC13892 RTC be selected by:
>
> #define CONFIG_RTC_MC13XXX
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> README | 2 +-
> drivers/rtc/Makefile | 2 +-
> include/configs/efikamx.h | 2 +-
> include/configs/imx31_litekit.h | 2 +-
> include/configs/mx31ads.h | 2 +-
> include/configs/mx31pdk.h | 2 +-
> include/configs/qong.h | 2 +-
> include/configs/vision2.h | 2 +-
> 8 files changed, 8 insertions(+), 8 deletions(-)
Well, I do not see that drivers/rtc/mc13783-rtc.c becomes
drivers/rtc/mc13xxx-rtc.c. You patch misses something, I suppose.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 2/2] mx51evk: Add RTC support
2011-10-24 16:37 ` [U-Boot] [PATCH 2/2] mx51evk: Add RTC support Fabio Estevam
@ 2011-10-25 8:04 ` Stefano Babic
0 siblings, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2011-10-25 8:04 UTC (permalink / raw)
To: u-boot
On 10/24/2011 06:37 PM, Fabio Estevam wrote:
> MX51EVK has a MC13892 PMIC. Add RTC support.
>
> Tested via 'date' command that reads the PMIC RTC registers:
>
> MX51EVK U-Boot > date
> Date: 1970-01-01 (Thursday) Time: 0:40:35
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> include/configs/mx51evk.h | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/include/configs/mx51evk.h b/include/configs/mx51evk.h
> index 2c449b8..67b5f0b 100644
> --- a/include/configs/mx51evk.h
> +++ b/include/configs/mx51evk.h
> @@ -79,6 +79,7 @@
> #define CONFIG_FSL_PMIC_CLK 2500000
> #define CONFIG_FSL_PMIC_MODE (SPI_MODE_0 | SPI_CS_HIGH)
> #define CONFIG_FSL_PMIC_BITLEN 32
> +#define CONFIG_RTC_MC13XXX
>
> /*
> * MMC Configs
> @@ -124,6 +125,8 @@
>
> #undef CONFIG_CMD_IMLS
>
> +#define CONFIG_CMD_DATE
> +
> #define CONFIG_BOOTDELAY 3
>
> #define CONFIG_ETHPRIME "FEC0"
After fixing PATCH 1/2,
Acked-by: Stefano Babic <sbabic@denx.de>
Best regrads,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-25 8:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-24 16:37 [U-Boot] [PATCH 1/2] rtc: Make mc13783-rtc driver generic Fabio Estevam
2011-10-24 16:37 ` [U-Boot] [PATCH 2/2] mx51evk: Add RTC support Fabio Estevam
2011-10-25 8:04 ` Stefano Babic
2011-10-25 8:03 ` [U-Boot] [PATCH 1/2] rtc: Make mc13783-rtc driver generic Stefano Babic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.