From: "Cousson, Benoit" <b-cousson@ti.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Tony Lindgren <tony@atomide.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>
Subject: Re: [PATCH] of: Add a reg-names property to name reg entries
Date: Tue, 25 Oct 2011 15:40:36 +0200 [thread overview]
Message-ID: <4EA6BC54.7030007@ti.com> (raw)
In-Reply-To: <440786C5-FA1C-4750-9990-0BA5AABC2190@kernel.crashing.org>
On 10/25/2011 12:29 PM, Segher Boessenkool wrote:
>>> + compatible = "ti,mcasp";
>>> + reg =<0 0x10 0x10>,<0 0x20 0x10>,
>>> + <1 0x10 0x10>,<1 0x20 0x10>;
>>> + reg-names = "mpu", "dat",
>>> + "dma", "dma_dat";
>>
>> Hmm for some systems looks like this can also solve how to pass the
>> mux signal names cleanly from DT.
>
> What problem does any of this solve? The device binding for the
> "mcasp" device will have to describe the possible "reg-names", and
> what those mean; but the binding already has to describe its "reg"
> property anyway.
What this solve is the ability to use the platform_get_resource_byname
directly to retrieve the proper register base address. The binding is
just a text description that the driver will not be able to use
directly. It will have to get the resource using an abstract index.
It thus removes a level of indirection that is error prone and useless
most of the time.
Benoit
WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Cousson, Benoit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] of: Add a reg-names property to name reg entries
Date: Tue, 25 Oct 2011 15:40:36 +0200 [thread overview]
Message-ID: <4EA6BC54.7030007@ti.com> (raw)
In-Reply-To: <440786C5-FA1C-4750-9990-0BA5AABC2190@kernel.crashing.org>
On 10/25/2011 12:29 PM, Segher Boessenkool wrote:
>>> + compatible = "ti,mcasp";
>>> + reg =<0 0x10 0x10>,<0 0x20 0x10>,
>>> + <1 0x10 0x10>,<1 0x20 0x10>;
>>> + reg-names = "mpu", "dat",
>>> + "dma", "dma_dat";
>>
>> Hmm for some systems looks like this can also solve how to pass the
>> mux signal names cleanly from DT.
>
> What problem does any of this solve? The device binding for the
> "mcasp" device will have to describe the possible "reg-names", and
> what those mean; but the binding already has to describe its "reg"
> property anyway.
What this solve is the ability to use the platform_get_resource_byname
directly to retrieve the proper register base address. The binding is
just a text description that the driver will not be able to use
directly. It will have to get the resource using an abstract index.
It thus removes a level of indirection that is error prone and useless
most of the time.
Benoit
next prev parent reply other threads:[~2011-10-25 13:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 15:54 [PATCH] of: Add a reg-names property to name reg entries Benoit Cousson
2011-10-24 15:54 ` Benoit Cousson
2011-10-24 22:19 ` Grant Likely
2011-10-24 22:19 ` Grant Likely
2011-10-24 22:56 ` Cousson, Benoit
2011-10-24 22:56 ` Cousson, Benoit
2011-10-25 4:49 ` Grant Likely
2011-10-25 4:49 ` Grant Likely
2011-10-25 8:26 ` Tony Lindgren
2011-10-25 8:26 ` Tony Lindgren
2011-10-25 10:29 ` Segher Boessenkool
2011-10-25 10:29 ` Segher Boessenkool
2011-10-25 13:40 ` Cousson, Benoit [this message]
2011-10-25 13:40 ` Cousson, Benoit
[not found] ` <4EA6BC54.7030007-l0cyMroinI0@public.gmane.org>
2011-10-25 14:17 ` Segher Boessenkool
2011-10-25 14:17 ` Segher Boessenkool
2011-10-25 16:10 ` Cousson, Benoit
2011-10-25 16:10 ` Cousson, Benoit
2011-10-26 3:57 ` Segher Boessenkool
2011-10-26 3:57 ` Segher Boessenkool
2011-10-26 12:23 ` Tony Lindgren
2011-10-26 12:23 ` Tony Lindgren
2011-10-26 17:40 ` Cousson, Benoit
2011-10-26 17:40 ` Cousson, Benoit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA6BC54.7030007@ti.com \
--to=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=segher@kernel.crashing.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.