* [PATCH] mmc: debugfs: parse all ext_csd via debug_fs @ 2011-10-24 15:04 Giuseppe CAVALLARO 2011-10-25 11:43 ` Sebastian Rasmussen 2011-10-27 7:16 ` [PATCH] mmc: debugfs: parse ext_csd via debug_fs (v2) Giuseppe CAVALLARO 0 siblings, 2 replies; 15+ messages in thread From: Giuseppe CAVALLARO @ 2011-10-24 15:04 UTC (permalink / raw) To: linux-mmc; +Cc: Giuseppe Cavallaro This patch enhances the debug information reported for the mmc card by parsing the extended CSD registers obviously according to all the current specifications. I have no HW to test eMMC 4.5 at this moment. In any case, the patch supports JEDEC Standard No. 84-B45. No issues on JESD84-A441 and older specs raised on my side. Output from /sys/kernel/debug/mmc0/mmc0:0001/ext_csd looks like this: Extended CSD rev 1.5 (MMC 4.41) s_cmd_set: 0x01 hpi_features: 0x00 blops_support: 0x00 ini_timeout_ap: 0x0a pwr_cl_ddr_52_360 0x00 [snip] Reported-by: Youssef Triki <youssef.triki@st.com> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> --- drivers/mmc/core/debugfs.c | 266 ++++++++++++++++++++++++++++++++++++++------ 1 files changed, 232 insertions(+), 34 deletions(-) diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c index 0b9a4aa..3771624 100644 --- a/drivers/mmc/core/debugfs.c +++ b/drivers/mmc/core/debugfs.c @@ -223,19 +223,13 @@ static int mmc_dbg_card_status_get(void *data, u64 *val) DEFINE_SIMPLE_ATTRIBUTE(mmc_dbg_card_status_fops, mmc_dbg_card_status_get, NULL, "%08llx\n"); -#define EXT_CSD_STR_LEN 1025 - -static int mmc_ext_csd_open(struct inode *inode, struct file *filp) +static int mmc_ext_csd_read(struct seq_file *s, void *data) { - struct mmc_card *card = inode->i_private; - char *buf; - ssize_t n = 0; + struct mmc_card *card = s->private; u8 *ext_csd; - int err, i; - - buf = kmalloc(EXT_CSD_STR_LEN + 1, GFP_KERNEL); - if (!buf) - return -ENOMEM; + u8 ext_csd_rev; + int err; + const char *str; ext_csd = kmalloc(512, GFP_KERNEL); if (!ext_csd) { @@ -249,41 +243,245 @@ static int mmc_ext_csd_open(struct inode *inode, struct file *filp) if (err) goto out_free; - for (i = 511; i >= 0; i--) - n += sprintf(buf + n, "%02x", ext_csd[i]); - n += sprintf(buf + n, "\n"); - BUG_ON(n != EXT_CSD_STR_LEN); + ext_csd_rev = ext_csd[192]; - filp->private_data = buf; - kfree(ext_csd); - return 0; + if (ext_csd_rev > 6) + goto out_free; + + switch (ext_csd_rev) { + case 6: + str = "4.5"; + break; + case 5: + str = "4.41"; + break; + case 3: + str = "4.3"; + break; + case 2: + str = "4.2"; + break; + case 1: + str = "4.1"; + break; + default: + goto out_free; + } + seq_printf(s, "Extended CSD rev 1.%d (MMC %s)\n", ext_csd_rev, str); + + if (ext_csd_rev < 3) + goto out_free; /* No ext_csd */ + + /* Parse the Extended CSD registers. + * Reserved bit should be read as "0" in case of spec older + * than A441. + */ + seq_printf(s, "s_cmd_set: 0x%02x\n", ext_csd[504]); + seq_printf(s, "hpi_features: 0x%02x\n", ext_csd[503]); + seq_printf(s, "blops_support: 0x%02x\n", ext_csd[502]); + + if (ext_csd_rev >= 6) { /* eMMC 4.5 */ + unsigned int cache_size = ext_csd[249] << 0 | + ext_csd[250] << 8 | + ext_csd[251] << 16 | + ext_csd[252] << 24; + seq_printf(s, "max_packed_reads: 0x%02x\n", ext_csd[501]); + seq_printf(s, "max_packed_writes: 0x%02x\n", ext_csd[500]); + seq_printf(s, "data_tag_support: 0x%02x\n", ext_csd[499]); + seq_printf(s, "tag_unit_size: 0x%02x\n", ext_csd[498]); + seq_printf(s, "tag_res_size: 0x%02x\n", ext_csd[497]); + seq_printf(s, "context_capability: 0x%02x\n", ext_csd[496]); + seq_printf(s, "large_unit_size_m1: 0x%02x\n", ext_csd[495]); + seq_printf(s, "ext_support: 0x%02x\n", ext_csd[494]); + if (cache_size) + seq_printf(s, "cache_size[]: %d KiB\n", cache_size); + else + seq_printf(s, "No cache existing\n"); + + seq_printf(s, "generic_cmd6_time: 0x%02x\n", ext_csd[248]); + seq_printf(s, "power_off_long_time: 0x%02x\n", ext_csd[247]); + } + + /* A441: Reserved [501:247] + A43: reserved [246:229] */ + if (ext_csd_rev >= 5) { + seq_printf(s, "ini_timeout_ap: 0x%02x\n", ext_csd[241]); + /* A441: reserved [240] */ + seq_printf(s, "pwr_cl_ddr_52_360 0x%02x\n", ext_csd[239]); + seq_printf(s, "pwr_cl_ddr_52_195 0x%02x\n", ext_csd[238]); + + /* A441: reserved [237-236] */ + + if (ext_csd_rev >= 6) { + seq_printf(s, "pwr_cl_200_360 0x%02x\n", ext_csd[237]); + seq_printf(s, "pwr_cl_200_195 0x%02x\n", ext_csd[236]); + } + + seq_printf(s, "min_perf_ddr_w_8_52 0x%02x\n", ext_csd[235]); + seq_printf(s, "min_perf_ddr_r_8_52 0x%02x\n", ext_csd[234]); + /* A441: reserved [233] */ + seq_printf(s, "trim_mult 0x%02x\n", ext_csd[232]); + seq_printf(s, "sec_feature_support 0x%02x\n", ext_csd[231]); + } + if (ext_csd_rev == 5) { /* Obsolete in 4.5 */ + seq_printf(s, "sec_erase_mult 0x%02x\n", ext_csd[230]); + seq_printf(s, "sec_trim_mult 0x%02x\n", ext_csd[229]); + } + seq_printf(s, "boot_info 0x%02x\n", ext_csd[228]); + /* A441/A43: reserved [227] */ + seq_printf(s, "boot_size_multi 0x%02x\n", ext_csd[226]); + seq_printf(s, "acc_size 0x%02x\n", ext_csd[225]); + seq_printf(s, "hc_erase_grp_size 0x%02x\n", ext_csd[224]); + seq_printf(s, "erase_timeout_mult 0x%02x\n", ext_csd[223]); + seq_printf(s, "rel_wr_sec_c 0x%02x\n", ext_csd[222]); + seq_printf(s, "hc_wp_grp_size 0x%02x\n", ext_csd[221]); + seq_printf(s, "s_c_vcc 0x%02x\n", ext_csd[220]); + seq_printf(s, "s_c_vccq 0x%02x\n", ext_csd[219]); + /* A441/A43: reserved [218] */ + seq_printf(s, "s_a_timeout 0x%02x\n", ext_csd[217]); + /* A441/A43: reserved [216] */ + seq_printf(s, "sec_count 0x%02x\n", (ext_csd[215] << 24) | + (ext_csd[214] << 16) | (ext_csd[213] << 8) | + ext_csd[212]); + /* A441/A43: reserved [211] */ + seq_printf(s, "min_perf_w_8_52 0x%02x\n", ext_csd[210]); + seq_printf(s, "min_perf_r_8_52 0x%02x\n", ext_csd[209]); + seq_printf(s, "min_perf_w_8_26_4_52 0x%02x\n", ext_csd[208]); + seq_printf(s, "min_perf_r_8_26_4_52 0x%02x\n", ext_csd[207]); + seq_printf(s, "min_perf_w_4_26 0x%02x\n", ext_csd[206]); + seq_printf(s, "min_perf_r_4_26 0x%02x\n", ext_csd[205]); + /* A441/A43: reserved [204] */ + seq_printf(s, "pwr_cl_26_360 0x%02x\n", ext_csd[203]); + seq_printf(s, "pwr_cl_52_360 0x%02x\n", ext_csd[202]); + seq_printf(s, "pwr_cl_26_195 0x%02x\n", ext_csd[201]); + seq_printf(s, "pwr_cl_52_195 0x%02x\n", ext_csd[200]); + + /* A43: reserved [199:198] */ + if (ext_csd_rev >= 5) { + seq_printf(s, "partition_switch_time 0x%02x\n", ext_csd[199]); + seq_printf(s, "out_of_interrupt_time 0x%02x\n", ext_csd[198]); + } + + /* A441/A43: reserved [197] [195] [193] [190] [188] + * [186] [184] [182] [180] [176] */ + + if (ext_csd_rev >= 6) + seq_printf(s, "driver_strength 0x%02x\n", ext_csd[197]); + + seq_printf(s, "card_type 0x%02x\n", ext_csd[196]); + seq_printf(s, "csd_structure 0x%02x\n", ext_csd[194]); + seq_printf(s, "ext_csd_rev 0x%02x\n", ext_csd[192]); + seq_printf(s, "cmd_set 0x%02x\n", ext_csd[191]); + seq_printf(s, "cmd_set_rev 0x%02x\n", ext_csd[189]); + seq_printf(s, "power_class 0x%02x\n", ext_csd[187]); + seq_printf(s, "hs_timing 0x%02x\n", ext_csd[185]); + seq_printf(s, "bus_width 0x%02x\n", ext_csd[183]); + seq_printf(s, "erased_mem_cont 0x%02x\n", ext_csd[181]); + seq_printf(s, "partition_config 0x%02x\n", ext_csd[179]); + seq_printf(s, "boot_config_prot 0x%02x\n", ext_csd[178]); + seq_printf(s, "boot_bus_width 0x%02x\n", ext_csd[177]); + seq_printf(s, "erase_group_def 0x%02x\n", ext_csd[175]); + + /* A43: reserved [174:0] / A441: reserved [174] */ + if (ext_csd_rev >= 5) { + seq_printf(s, "boot_wp 0x%02x\n", ext_csd[173]); + /* A441: reserved [172] */ + seq_printf(s, "user_wp 0x%02x\n", ext_csd[171]); + /* A441: reserved [170] */ + seq_printf(s, "fw_config 0x%02x\n", ext_csd[169]); + seq_printf(s, "rpmb_size_mult 0x%02x\n", ext_csd[168]); + seq_printf(s, "wr_rel_set 0x%02x\n", ext_csd[167]); + seq_printf(s, "wr_rel_param 0x%02x\n", ext_csd[166]); + /* A441: reserved [165] */ + seq_printf(s, "bkops_start 0x%02x\n", ext_csd[164]); + seq_printf(s, "bkops_en 0x%02x\n", ext_csd[163]); + seq_printf(s, "rst_n_function 0x%02x\n", ext_csd[162]); + seq_printf(s, "hpi_mgmt 0x%02x\n", ext_csd[161]); + seq_printf(s, "partitioning_support 0x%02x\n", ext_csd[160]); + seq_printf(s, "max_enh_size_mult[2] 0x%02x\n", ext_csd[159]); + seq_printf(s, "max_enh_size_mult[1] 0x%02x\n", ext_csd[158]); + seq_printf(s, "max_enh_size_mult[0] 0x%02x\n", ext_csd[157]); + seq_printf(s, "partitions_attribute 0x%02x\n", ext_csd[156]); + seq_printf(s, "partition_setting_completed 0x%02x\n", + ext_csd[155]); + seq_printf(s, "gp_size_mult_4[2] 0x%02x\n", ext_csd[154]); + seq_printf(s, "gp_size_mult_4[1] 0x%02x\n", ext_csd[153]); + seq_printf(s, "gp_size_mult_4[0] 0x%02x\n", ext_csd[152]); + seq_printf(s, "gp_size_mult_3[2] 0x%02x\n", ext_csd[151]); + seq_printf(s, "gp_size_mult_3[1] 0x%02x\n", ext_csd[150]); + seq_printf(s, "gp_size_mult_3[0] 0x%02x\n", ext_csd[149]); + seq_printf(s, "gp_size_mult_2[2] 0x%02x\n", ext_csd[148]); + seq_printf(s, "gp_size_mult_2[1] 0x%02x\n", ext_csd[147]); + seq_printf(s, "gp_size_mult_2[0] 0x%02x\n", ext_csd[146]); + seq_printf(s, "gp_size_mult_1[2] 0x%02x\n", ext_csd[145]); + seq_printf(s, "gp_size_mult_1[1] 0x%02x\n", ext_csd[144]); + seq_printf(s, "gp_size_mult_1[0] 0x%02x\n", ext_csd[143]); + seq_printf(s, "enh_size_mult[2] 0x%02x\n", ext_csd[142]); + seq_printf(s, "enh_size_mult[1] 0x%02x\n", ext_csd[141]); + seq_printf(s, "enh_size_mult[0] 0x%02x\n", ext_csd[140]); + seq_printf(s, "enh_start_addr[3] 0x%02x\n", ext_csd[139]); + seq_printf(s, "enh_start_addr[2] 0x%02x\n", ext_csd[138]); + seq_printf(s, "enh_start_addr[1] 0x%02x\n", ext_csd[137]); + seq_printf(s, "enh_start_addr[0] 0x%02x\n", ext_csd[136]); + /* A441: reserved [135] */ + seq_printf(s, "sec_bad_blk_mgmnt 0x%02x\n", ext_csd[134]); + /* A441: reserved [133:0] */ + } + /* B45 */ + if (ext_csd_rev >= 6) { + int j; + seq_printf(s, "tcase_support 0x%02x\n", ext_csd[132]); + seq_printf(s, "program_cid_csd_ddr_support 0x%02x\n", + ext_csd[130]); + + seq_printf(s, "vendor_specific_field:\n"); + for (j = 127; j >= 64; j--) + seq_printf(s, "\t[%d] 0x%02x\n", j, ext_csd[j]); + + seq_printf(s, "native_sector_size 0x%02x\n", ext_csd[63]); + seq_printf(s, "use_native_sector 0x%02x\n", ext_csd[62]); + seq_printf(s, "data_sector_size 0x%02x\n", ext_csd[61]); + seq_printf(s, "ini_timeout_emu 0x%02x\n", ext_csd[60]); + seq_printf(s, "class_6_ctrl 0x%02x\n", ext_csd[59]); + seq_printf(s, "dyncap_needed 0x%02x\n", ext_csd[58]); + seq_printf(s, "exception_events_ctrl[1] 0x%02x\n", ext_csd[57]); + seq_printf(s, "exception_events_ctrl[0] 0x%02x\n", ext_csd[56]); + seq_printf(s, "exception_events_status[1] 0x%02x\n", + ext_csd[55]); + seq_printf(s, "exception_events_status[0] 0x%02x\n", + ext_csd[54]); + seq_printf(s, "ext_partition_attribute[1] 0x%02x\n", + ext_csd[53]); + seq_printf(s, "ext_partition_attribute[0] 0x%02x\n", + ext_csd[52]); + + seq_printf(s, "context_conf:\n"); + for (j = 51; j >= 37; j--) + seq_printf(s, "\t[%d] 0x%02x\n", j, ext_csd[j]); + + seq_printf(s, "packed_command_status 0x%02x\n", ext_csd[36]); + seq_printf(s, "packed_failure_index 0x%02x\n", ext_csd[35]); + seq_printf(s, "power_off_notification 0x%02x\n", ext_csd[34]); + seq_printf(s, "cache_ctrl 0x%02x\n", ext_csd[33]); + seq_printf(s, "flush_cache 0x%02x\n", ext_csd[32]); + /*Reserved [31:0] */ + } out_free: - kfree(buf); kfree(ext_csd); return err; } -static ssize_t mmc_ext_csd_read(struct file *filp, char __user *ubuf, - size_t cnt, loff_t *ppos) +static int mmc_ext_csd_open(struct inode *inode, struct file *file) { - char *buf = filp->private_data; - - return simple_read_from_buffer(ubuf, cnt, ppos, - buf, EXT_CSD_STR_LEN); -} - -static int mmc_ext_csd_release(struct inode *inode, struct file *file) -{ - kfree(file->private_data); - return 0; + return single_open(file, mmc_ext_csd_read, inode->i_private); } static const struct file_operations mmc_dbg_ext_csd_fops = { .open = mmc_ext_csd_open, - .read = mmc_ext_csd_read, - .release = mmc_ext_csd_release, - .llseek = default_llseek, + .read = seq_read, + .llseek = seq_lseek, + .release = single_release, }; void mmc_add_card_debugfs(struct mmc_card *card) -- 1.7.4.4 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH] mmc: debugfs: parse all ext_csd via debug_fs 2011-10-24 15:04 [PATCH] mmc: debugfs: parse all ext_csd via debug_fs Giuseppe CAVALLARO @ 2011-10-25 11:43 ` Sebastian Rasmussen 2011-10-26 11:27 ` Giuseppe CAVALLARO 2011-11-12 1:12 ` Linus Walleij 2011-10-27 7:16 ` [PATCH] mmc: debugfs: parse ext_csd via debug_fs (v2) Giuseppe CAVALLARO 1 sibling, 2 replies; 15+ messages in thread From: Sebastian Rasmussen @ 2011-10-25 11:43 UTC (permalink / raw) To: Giuseppe CAVALLARO; +Cc: linux-mmc > This patch enhances the debug information reported > for the mmc card by parsing the extended CSD registers > obviously according to all the current specifications. Does this belong kernel or in userspace? I'm not sure, and I'm hoping that any of the old-timers here chime in on it. Anyway I supply you with a few comments on you patch below... BTW, you are parsing EXT_CSD here, but then one really should expand CSD, SCR, CID as well. One of those contains a numerical customer id which leads me to believe that it would require some kind of list of number->name to make it accessible to users, something akin to the lspci database. I did write an initial draft of such a userspace tool at my old employers over at ST-Ericsson and tried to open source it just before I resigned, but I don't know whether it has made it through the legal barrier yet. I'll let you know if I see it. > I have no HW to test eMMC 4.5 at this moment. In any case, > the patch supports JEDEC Standard No. 84-B45. > No issues on JESD84-A441 and older specs raised on my side. > > Output from /sys/kernel/debug/mmc0/mmc0:0001/ext_csd > looks like this: > > Extended CSD rev 1.5 (MMC 4.41) > s_cmd_set: 0x01 > hpi_features: 0x00 > blops_support: 0x00 > ini_timeout_ap: 0x0a > pwr_cl_ddr_52_360 0x00 > [snip] > > Reported-by: Youssef Triki <youssef.triki@st.com> > Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> > --- > drivers/mmc/core/debugfs.c | 266 ++++++++++++++++++++++++++++++++++++++------ > 1 files changed, 232 insertions(+), 34 deletions(-) > > diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c > index 0b9a4aa..3771624 100644 > --- a/drivers/mmc/core/debugfs.c > +++ b/drivers/mmc/core/debugfs.c > @@ -223,19 +223,13 @@ static int mmc_dbg_card_status_get(void *data, u64 *val) > DEFINE_SIMPLE_ATTRIBUTE(mmc_dbg_card_status_fops, mmc_dbg_card_status_get, > NULL, "%08llx\n"); > > -#define EXT_CSD_STR_LEN 1025 > - > -static int mmc_ext_csd_open(struct inode *inode, struct file *filp) > +static int mmc_ext_csd_read(struct seq_file *s, void *data) > { > - struct mmc_card *card = inode->i_private; > - char *buf; > - ssize_t n = 0; > + struct mmc_card *card = s->private; > u8 *ext_csd; > - int err, i; > - > - buf = kmalloc(EXT_CSD_STR_LEN + 1, GFP_KERNEL); > - if (!buf) > - return -ENOMEM; > + u8 ext_csd_rev; > + int err; > + const char *str; > > ext_csd = kmalloc(512, GFP_KERNEL); > if (!ext_csd) { > @@ -249,41 +243,245 @@ static int mmc_ext_csd_open(struct inode *inode, struct file *filp) > if (err) > goto out_free; > > - for (i = 511; i >= 0; i--) > - n += sprintf(buf + n, "%02x", ext_csd[i]); > - n += sprintf(buf + n, "\n"); > - BUG_ON(n != EXT_CSD_STR_LEN); > + ext_csd_rev = ext_csd[192]; > > - filp->private_data = buf; > - kfree(ext_csd); > - return 0; > + if (ext_csd_rev > 6) > + goto out_free; Isn't the goto in default case of the switch below enough? > + > + switch (ext_csd_rev) { > + case 6: > + str = "4.5"; > + break; > + case 5: > + str = "4.41"; > + break; > + case 3: > + str = "4.3"; > + break; > + case 2: > + str = "4.2"; > + break; > + case 1: > + str = "4.1"; > + break; case 0: str = "4.0"; break; > + default: > + goto out_free; > + } > + seq_printf(s, "Extended CSD rev 1.%d (MMC %s)\n", ext_csd_rev, str); > + > + if (ext_csd_rev < 3) > + goto out_free; /* No ext_csd */ > + > + /* Parse the Extended CSD registers. > + * Reserved bit should be read as "0" in case of spec older > + * than A441. > + */ > + seq_printf(s, "s_cmd_set: 0x%02x\n", ext_csd[504]); > + seq_printf(s, "hpi_features: 0x%02x\n", ext_csd[503]); > + seq_printf(s, "blops_support: 0x%02x\n", ext_csd[502]); bkops > + > + if (ext_csd_rev >= 6) { /* eMMC 4.5 */ > + unsigned int cache_size = ext_csd[249] << 0 | should this be declared u32? > + ext_csd[250] << 8 | > + ext_csd[251] << 16 | > + ext_csd[252] << 24; > + seq_printf(s, "max_packed_reads: 0x%02x\n", ext_csd[501]); > + seq_printf(s, "max_packed_writes: 0x%02x\n", ext_csd[500]); > + seq_printf(s, "data_tag_support: 0x%02x\n", ext_csd[499]); > + seq_printf(s, "tag_unit_size: 0x%02x\n", ext_csd[498]); > + seq_printf(s, "tag_res_size: 0x%02x\n", ext_csd[497]); > + seq_printf(s, "context_capability: 0x%02x\n", ext_csd[496]); capabilities > + seq_printf(s, "large_unit_size_m1: 0x%02x\n", ext_csd[495]); > + seq_printf(s, "ext_support: 0x%02x\n", ext_csd[494]); > + if (cache_size) > + seq_printf(s, "cache_size[]: %d KiB\n", cache_size); why the brackets? > + else > + seq_printf(s, "No cache existing\n"); I think "cache_size: 0 KiB\n" be more appropriate. The fact that 0 should be interpreted as "no cache exists" should be done by the one/sw reading this file. Also just printing the cache_size as given is simpler. Also I think you could treat cache_size the same as sec_count below and not declare a local variable. > + > + seq_printf(s, "generic_cmd6_time: 0x%02x\n", ext_csd[248]); > + seq_printf(s, "power_off_long_time: 0x%02x\n", ext_csd[247]); > + } > + > + /* A441: Reserved [501:247] > + A43: reserved [246:229] */ > + if (ext_csd_rev >= 5) { > + seq_printf(s, "ini_timeout_ap: 0x%02x\n", ext_csd[241]); > + /* A441: reserved [240] */ > + seq_printf(s, "pwr_cl_ddr_52_360 0x%02x\n", ext_csd[239]); You lost the colon after the property name starting from this line. I sugges you keep it. (I had to read the spec to know that these were actually called properities, who knew?) > + seq_printf(s, "pwr_cl_ddr_52_195 0x%02x\n", ext_csd[238]); > + > + /* A441: reserved [237-236] */ > + > + if (ext_csd_rev >= 6) { > + seq_printf(s, "pwr_cl_200_360 0x%02x\n", ext_csd[237]); > + seq_printf(s, "pwr_cl_200_195 0x%02x\n", ext_csd[236]); > + } > + > + seq_printf(s, "min_perf_ddr_w_8_52 0x%02x\n", ext_csd[235]); > + seq_printf(s, "min_perf_ddr_r_8_52 0x%02x\n", ext_csd[234]); > + /* A441: reserved [233] */ > + seq_printf(s, "trim_mult 0x%02x\n", ext_csd[232]); > + seq_printf(s, "sec_feature_support 0x%02x\n", ext_csd[231]); > + } > + if (ext_csd_rev == 5) { /* Obsolete in 4.5 */ > + seq_printf(s, "sec_erase_mult 0x%02x\n", ext_csd[230]); > + seq_printf(s, "sec_trim_mult 0x%02x\n", ext_csd[229]); > + } > + seq_printf(s, "boot_info 0x%02x\n", ext_csd[228]); > + /* A441/A43: reserved [227] */ > + seq_printf(s, "boot_size_multi 0x%02x\n", ext_csd[226]); > + seq_printf(s, "acc_size 0x%02x\n", ext_csd[225]); > + seq_printf(s, "hc_erase_grp_size 0x%02x\n", ext_csd[224]); > + seq_printf(s, "erase_timeout_mult 0x%02x\n", ext_csd[223]); > + seq_printf(s, "rel_wr_sec_c 0x%02x\n", ext_csd[222]); > + seq_printf(s, "hc_wp_grp_size 0x%02x\n", ext_csd[221]); > + seq_printf(s, "s_c_vcc 0x%02x\n", ext_csd[220]); > + seq_printf(s, "s_c_vccq 0x%02x\n", ext_csd[219]); > + /* A441/A43: reserved [218] */ > + seq_printf(s, "s_a_timeout 0x%02x\n", ext_csd[217]); > + /* A441/A43: reserved [216] */ > + seq_printf(s, "sec_count 0x%02x\n", (ext_csd[215] << 24) | 0x%08x or %d would be better I believe. > + (ext_csd[214] << 16) | (ext_csd[213] << 8) | > + ext_csd[212]); > + /* A441/A43: reserved [211] */ > + seq_printf(s, "min_perf_w_8_52 0x%02x\n", ext_csd[210]); > + seq_printf(s, "min_perf_r_8_52 0x%02x\n", ext_csd[209]); > + seq_printf(s, "min_perf_w_8_26_4_52 0x%02x\n", ext_csd[208]); > + seq_printf(s, "min_perf_r_8_26_4_52 0x%02x\n", ext_csd[207]); > + seq_printf(s, "min_perf_w_4_26 0x%02x\n", ext_csd[206]); > + seq_printf(s, "min_perf_r_4_26 0x%02x\n", ext_csd[205]); > + /* A441/A43: reserved [204] */ > + seq_printf(s, "pwr_cl_26_360 0x%02x\n", ext_csd[203]); > + seq_printf(s, "pwr_cl_52_360 0x%02x\n", ext_csd[202]); > + seq_printf(s, "pwr_cl_26_195 0x%02x\n", ext_csd[201]); > + seq_printf(s, "pwr_cl_52_195 0x%02x\n", ext_csd[200]); > + > + /* A43: reserved [199:198] */ > + if (ext_csd_rev >= 5) { > + seq_printf(s, "partition_switch_time 0x%02x\n", ext_csd[199]); > + seq_printf(s, "out_of_interrupt_time 0x%02x\n", ext_csd[198]); > + } > + > + /* A441/A43: reserved [197] [195] [193] [190] [188] > + * [186] [184] [182] [180] [176] */ > + > + if (ext_csd_rev >= 6) > + seq_printf(s, "driver_strength 0x%02x\n", ext_csd[197]); > + > + seq_printf(s, "card_type 0x%02x\n", ext_csd[196]); > + seq_printf(s, "csd_structure 0x%02x\n", ext_csd[194]); > + seq_printf(s, "ext_csd_rev 0x%02x\n", ext_csd[192]); > + seq_printf(s, "cmd_set 0x%02x\n", ext_csd[191]); > + seq_printf(s, "cmd_set_rev 0x%02x\n", ext_csd[189]); > + seq_printf(s, "power_class 0x%02x\n", ext_csd[187]); > + seq_printf(s, "hs_timing 0x%02x\n", ext_csd[185]); > + seq_printf(s, "bus_width 0x%02x\n", ext_csd[183]); hm.. spec 4.5 defines this as not readable. I wonder it it makes sense to print it? I guess that any card would transfer 0 or some other constant value in this property... > + seq_printf(s, "erased_mem_cont 0x%02x\n", ext_csd[181]); > + seq_printf(s, "partition_config 0x%02x\n", ext_csd[179]); > + seq_printf(s, "boot_config_prot 0x%02x\n", ext_csd[178]); > + seq_printf(s, "boot_bus_width 0x%02x\n", ext_csd[177]); boot_bus_conditions according to spec 4.5... > + seq_printf(s, "erase_group_def 0x%02x\n", ext_csd[175]); > + > + /* A43: reserved [174:0] / A441: reserved [174] */ maybe, but spec 4.5 seems to define (though I admit that the line in the table is curiously grayed out, maybe it's a typo in the spec since 174 used to be reserved in 4.41...): seq_printf(s, "boot_wp_status 0x%02x\n", ext_csd[174]); > + if (ext_csd_rev >= 5) { > + seq_printf(s, "boot_wp 0x%02x\n", ext_csd[173]); > + /* A441: reserved [172] */ > + seq_printf(s, "user_wp 0x%02x\n", ext_csd[171]); > + /* A441: reserved [170] */ > + seq_printf(s, "fw_config 0x%02x\n", ext_csd[169]); > + seq_printf(s, "rpmb_size_mult 0x%02x\n", ext_csd[168]); > + seq_printf(s, "wr_rel_set 0x%02x\n", ext_csd[167]); > + seq_printf(s, "wr_rel_param 0x%02x\n", ext_csd[166]); > + /* A441: reserved [165] */ spec 4.5 seems to define sanitize_start here, but as for bus_width above, it is not really readable. I don't know whether you should include it or not. it may just be confusing. but either way the comment should be updated to reflect that 4.5 does indeed have a property here. seq_printf(s, "sanitize_start: 0x%02x\n", ext_csd[165]); > + seq_printf(s, "bkops_start 0x%02x\n", ext_csd[164]); this is only writeable, same as for bus_width... > + seq_printf(s, "bkops_en 0x%02x\n", ext_csd[163]); > + seq_printf(s, "rst_n_function 0x%02x\n", ext_csd[162]); > + seq_printf(s, "hpi_mgmt 0x%02x\n", ext_csd[161]); > + seq_printf(s, "partitioning_support 0x%02x\n", ext_csd[160]); > + seq_printf(s, "max_enh_size_mult[2] 0x%02x\n", ext_csd[159]); > + seq_printf(s, "max_enh_size_mult[1] 0x%02x\n", ext_csd[158]); > + seq_printf(s, "max_enh_size_mult[0] 0x%02x\n", ext_csd[157]); seq_printf(s, "max_enh_size_mult: 0x%06x\n", (ext_csd[159] << 16) | (ext_csd[158] << 8) | ext_csd[157]); this seems more to fit with your handling of sec_count above. > + seq_printf(s, "partitions_attribute 0x%02x\n", ext_csd[156]); > + seq_printf(s, "partition_setting_completed 0x%02x\n", > + ext_csd[155]); > + seq_printf(s, "gp_size_mult_4[2] 0x%02x\n", ext_csd[154]); > + seq_printf(s, "gp_size_mult_4[1] 0x%02x\n", ext_csd[153]); > + seq_printf(s, "gp_size_mult_4[0] 0x%02x\n", ext_csd[152]); > + seq_printf(s, "gp_size_mult_3[2] 0x%02x\n", ext_csd[151]); > + seq_printf(s, "gp_size_mult_3[1] 0x%02x\n", ext_csd[150]); > + seq_printf(s, "gp_size_mult_3[0] 0x%02x\n", ext_csd[149]); > + seq_printf(s, "gp_size_mult_2[2] 0x%02x\n", ext_csd[148]); > + seq_printf(s, "gp_size_mult_2[1] 0x%02x\n", ext_csd[147]); > + seq_printf(s, "gp_size_mult_2[0] 0x%02x\n", ext_csd[146]); > + seq_printf(s, "gp_size_mult_1[2] 0x%02x\n", ext_csd[145]); > + seq_printf(s, "gp_size_mult_1[1] 0x%02x\n", ext_csd[144]); > + seq_printf(s, "gp_size_mult_1[0] 0x%02x\n", ext_csd[143]); > + seq_printf(s, "enh_size_mult[2] 0x%02x\n", ext_csd[142]); > + seq_printf(s, "enh_size_mult[1] 0x%02x\n", ext_csd[141]); > + seq_printf(s, "enh_size_mult[0] 0x%02x\n", ext_csd[140]); > + seq_printf(s, "enh_start_addr[3] 0x%02x\n", ext_csd[139]); > + seq_printf(s, "enh_start_addr[2] 0x%02x\n", ext_csd[138]); > + seq_printf(s, "enh_start_addr[1] 0x%02x\n", ext_csd[137]); > + seq_printf(s, "enh_start_addr[0] 0x%02x\n", ext_csd[136]); seq_printf(s, "gp_size_mult_4: 0x%06x\n", (ext_csd[154] << 16) | (ext_csd[153] << 8) | ext_csd[152]); seq_printf(s, "gp_size_mult_3: 0x%06x\n", (ext_csd[151] << 16) | (ext_csd[150] << 8) | ext_csd[149]); seq_printf(s, "gp_size_mult_2: 0x%06x\n", (ext_csd[148] << 16) | (ext_csd[147] << 8) | ext_csd[146]); seq_printf(s, "gp_size_mult_1: 0x%06x\n", (ext_csd[145] << 16) | (ext_csd[144] << 8) | ext_csd[143]); seq_printf(s, "enh_size_mult: 0x%06x\n", (ext_csd[142] << 16) | (ext_csd[141] << 8) | ext_csd[140]); seq_printf(s, "enh_start_addr: 0x%06x\n", (ext_csd[139] << 16) | (ext_csd[138] << 8) | ext_csd[137]); same comment as for max_enh_size_mult... > + /* A441: reserved [135] */ > + seq_printf(s, "sec_bad_blk_mgmnt 0x%02x\n", ext_csd[134]); > + /* A441: reserved [133:0] */ > + } > + /* B45 */ > + if (ext_csd_rev >= 6) { > + int j; > + seq_printf(s, "tcase_support 0x%02x\n", ext_csd[132]); not readable according to spec 4.5... also spec 4.5 defines which you may want to include: seq_printf(s, "periodic_wakeup: 0x%02x\n", ext_csd[131]); > + seq_printf(s, "program_cid_csd_ddr_support 0x%02x\n", > + ext_csd[130]); > + > + seq_printf(s, "vendor_specific_field:\n"); > + for (j = 127; j >= 64; j--) > + seq_printf(s, "\t[%d] 0x%02x\n", j, ext_csd[j]); printing an array here make sense (since it _is_ really a byte array), but what about replacing the last three lines with: for (j = 127; j >= 64; j--) seq_printf(s, "vendor_specific_field[%d]: 0x%02x\n", j, ext_csd[j]); that way all lines in the sysfs-file follow the same format without indentation. > + > + seq_printf(s, "native_sector_size 0x%02x\n", ext_csd[63]); > + seq_printf(s, "use_native_sector 0x%02x\n", ext_csd[62]); > + seq_printf(s, "data_sector_size 0x%02x\n", ext_csd[61]); > + seq_printf(s, "ini_timeout_emu 0x%02x\n", ext_csd[60]); > + seq_printf(s, "class_6_ctrl 0x%02x\n", ext_csd[59]); > + seq_printf(s, "dyncap_needed 0x%02x\n", ext_csd[58]); > + seq_printf(s, "exception_events_ctrl[1] 0x%02x\n", ext_csd[57]); > + seq_printf(s, "exception_events_ctrl[0] 0x%02x\n", ext_csd[56]); > + seq_printf(s, "exception_events_status[1] 0x%02x\n", > + ext_csd[55]); > + seq_printf(s, "exception_events_status[0] 0x%02x\n", > + ext_csd[54]); > + seq_printf(s, "ext_partition_attribute[1] 0x%02x\n", > + ext_csd[53]); > + seq_printf(s, "ext_partition_attribute[0] 0x%02x\n", > + ext_csd[52]); seq_printf(s, "exception_events_ctrl: 0x%04x\n", (ext_csd[57] << 8) | ext_csd[56]); seq_printf(s, "exception_events_status: 0x%04x\n", (ext_csd[55] << 8) | ext_csd[54]); seq_printf(s, "ext_partitions_attribute: 0x%04x\n", (ext_csd[53] << 8) | ext_csd[52]); notice the s in partitions... > + > + seq_printf(s, "context_conf:\n"); > + for (j = 51; j >= 37; j--) > + seq_printf(s, "\t[%d] 0x%02x\n", j, ext_csd[j]); same as for vendor_specific_field above, I would suggest doing for (j = 51; j >= 37; j--) seq_printf(s, "context_conf[%d]: 0x%02x\n", j, ext_csd[j]); > + > + seq_printf(s, "packed_command_status 0x%02x\n", ext_csd[36]); > + seq_printf(s, "packed_failure_index 0x%02x\n", ext_csd[35]); > + seq_printf(s, "power_off_notification 0x%02x\n", ext_csd[34]); > + seq_printf(s, "cache_ctrl 0x%02x\n", ext_csd[33]); > + seq_printf(s, "flush_cache 0x%02x\n", ext_csd[32]); this property is not readable. > + /*Reserved [31:0] */ > + } > > out_free: > - kfree(buf); > kfree(ext_csd); > return err; > } > > -static ssize_t mmc_ext_csd_read(struct file *filp, char __user *ubuf, > - size_t cnt, loff_t *ppos) > +static int mmc_ext_csd_open(struct inode *inode, struct file *file) > { > - char *buf = filp->private_data; > - > - return simple_read_from_buffer(ubuf, cnt, ppos, > - buf, EXT_CSD_STR_LEN); > -} > - > -static int mmc_ext_csd_release(struct inode *inode, struct file *file) > -{ > - kfree(file->private_data); > - return 0; > + return single_open(file, mmc_ext_csd_read, inode->i_private); > } > > static const struct file_operations mmc_dbg_ext_csd_fops = { > .open = mmc_ext_csd_open, > - .read = mmc_ext_csd_read, > - .release = mmc_ext_csd_release, > - .llseek = default_llseek, > + .read = seq_read, > + .llseek = seq_lseek, > + .release = single_release, > }; > > void mmc_add_card_debugfs(struct mmc_card *card) > -- > 1.7.4.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > / Sebastian ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] mmc: debugfs: parse all ext_csd via debug_fs 2011-10-25 11:43 ` Sebastian Rasmussen @ 2011-10-26 11:27 ` Giuseppe CAVALLARO 2011-10-27 7:20 ` Giuseppe CAVALLARO 2011-10-27 14:19 ` Sebastian Rasmussen 2011-11-12 1:12 ` Linus Walleij 1 sibling, 2 replies; 15+ messages in thread From: Giuseppe CAVALLARO @ 2011-10-26 11:27 UTC (permalink / raw) To: Sebastian Rasmussen; +Cc: linux-mmc On 10/25/2011 1:43 PM, Sebastian Rasmussen wrote: >> This patch enhances the debug information reported >> for the mmc card by parsing the extended CSD registers >> obviously according to all the current specifications. > > Does this belong kernel or in userspace? I'm not sure, and > I'm hoping that any of the old-timers here chime in on it. > Anyway I supply you with a few comments on you patch > below... > This is on kernel space. Before the patch the output from /sys/kernel/debug/mmc0/mmc0:0001/ext_csd was a big number and I had many problems parsing it in real-time. Maybe, there is some user-space application to do this job that I do not know. :-( In any case, the patch wants to help to directly get the ext_csd in a human format. > BTW, you are parsing EXT_CSD here, but then one really > should expand CSD, SCR, CID as well. One of those Yes we could parse CID and CSD too. I guess in another patch. Please consider this patch for the ext_csd entry in /sys. > contains a numerical customer id which leads me to believe > that it would require some kind of list of number->name to > make it accessible to users, something akin to the lspci > database. I did write an initial draft of such a userspace tool > at my old employers over at ST-Ericsson and tried to open > source it just before I resigned, but I don't know whether it > has made it through the legal barrier yet. I'll let you know > if I see it. Yes let me know. Thanks for the reviewing. I'll look and fix all the points below and resend the patch again. Peppe > >> I have no HW to test eMMC 4.5 at this moment. In any case, >> the patch supports JEDEC Standard No. 84-B45. >> No issues on JESD84-A441 and older specs raised on my side. >> >> Output from /sys/kernel/debug/mmc0/mmc0:0001/ext_csd >> looks like this: >> >> Extended CSD rev 1.5 (MMC 4.41) >> s_cmd_set: 0x01 >> hpi_features: 0x00 >> blops_support: 0x00 >> ini_timeout_ap: 0x0a >> pwr_cl_ddr_52_360 0x00 >> [snip] >> >> Reported-by: Youssef Triki <youssef.triki@st.com> >> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> >> --- >> drivers/mmc/core/debugfs.c | 266 ++++++++++++++++++++++++++++++++++++++------ >> 1 files changed, 232 insertions(+), 34 deletions(-) >> >> diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c >> index 0b9a4aa..3771624 100644 >> --- a/drivers/mmc/core/debugfs.c >> +++ b/drivers/mmc/core/debugfs.c >> @@ -223,19 +223,13 @@ static int mmc_dbg_card_status_get(void *data, u64 *val) >> DEFINE_SIMPLE_ATTRIBUTE(mmc_dbg_card_status_fops, mmc_dbg_card_status_get, >> NULL, "%08llx\n"); >> >> -#define EXT_CSD_STR_LEN 1025 >> - >> -static int mmc_ext_csd_open(struct inode *inode, struct file *filp) >> +static int mmc_ext_csd_read(struct seq_file *s, void *data) >> { >> - struct mmc_card *card = inode->i_private; >> - char *buf; >> - ssize_t n = 0; >> + struct mmc_card *card = s->private; >> u8 *ext_csd; >> - int err, i; >> - >> - buf = kmalloc(EXT_CSD_STR_LEN + 1, GFP_KERNEL); >> - if (!buf) >> - return -ENOMEM; >> + u8 ext_csd_rev; >> + int err; >> + const char *str; >> >> ext_csd = kmalloc(512, GFP_KERNEL); >> if (!ext_csd) { >> @@ -249,41 +243,245 @@ static int mmc_ext_csd_open(struct inode *inode, struct file *filp) >> if (err) >> goto out_free; >> >> - for (i = 511; i >= 0; i--) >> - n += sprintf(buf + n, "%02x", ext_csd[i]); >> - n += sprintf(buf + n, "\n"); >> - BUG_ON(n != EXT_CSD_STR_LEN); >> + ext_csd_rev = ext_csd[192]; >> >> - filp->private_data = buf; >> - kfree(ext_csd); >> - return 0; >> + if (ext_csd_rev > 6) >> + goto out_free; > > Isn't the goto in default case of the switch > below enough? > >> + >> + switch (ext_csd_rev) { >> + case 6: >> + str = "4.5"; >> + break; >> + case 5: >> + str = "4.41"; >> + break; >> + case 3: >> + str = "4.3"; >> + break; >> + case 2: >> + str = "4.2"; >> + break; >> + case 1: >> + str = "4.1"; >> + break; > > case 0: > str = "4.0"; > break; > >> + default: >> + goto out_free; >> + } >> + seq_printf(s, "Extended CSD rev 1.%d (MMC %s)\n", ext_csd_rev, str); >> + >> + if (ext_csd_rev < 3) >> + goto out_free; /* No ext_csd */ >> + >> + /* Parse the Extended CSD registers. >> + * Reserved bit should be read as "0" in case of spec older >> + * than A441. >> + */ >> + seq_printf(s, "s_cmd_set: 0x%02x\n", ext_csd[504]); >> + seq_printf(s, "hpi_features: 0x%02x\n", ext_csd[503]); >> + seq_printf(s, "blops_support: 0x%02x\n", ext_csd[502]); > > bkops > >> + >> + if (ext_csd_rev >= 6) { /* eMMC 4.5 */ >> + unsigned int cache_size = ext_csd[249] << 0 | > > should this be declared u32? > >> + ext_csd[250] << 8 | >> + ext_csd[251] << 16 | >> + ext_csd[252] << 24; >> + seq_printf(s, "max_packed_reads: 0x%02x\n", ext_csd[501]); >> + seq_printf(s, "max_packed_writes: 0x%02x\n", ext_csd[500]); >> + seq_printf(s, "data_tag_support: 0x%02x\n", ext_csd[499]); >> + seq_printf(s, "tag_unit_size: 0x%02x\n", ext_csd[498]); >> + seq_printf(s, "tag_res_size: 0x%02x\n", ext_csd[497]); >> + seq_printf(s, "context_capability: 0x%02x\n", ext_csd[496]); > > capabilities > >> + seq_printf(s, "large_unit_size_m1: 0x%02x\n", ext_csd[495]); >> + seq_printf(s, "ext_support: 0x%02x\n", ext_csd[494]); >> + if (cache_size) >> + seq_printf(s, "cache_size[]: %d KiB\n", cache_size); > > why the brackets? > >> + else >> + seq_printf(s, "No cache existing\n"); > > I think "cache_size: 0 KiB\n" be more appropriate. The fact that 0 should > be interpreted as "no cache exists" should be done by the one/sw reading > this file. Also just printing the cache_size as given is simpler. Also I think > you could treat cache_size the same as sec_count below and not declare > a local variable. > >> + >> + seq_printf(s, "generic_cmd6_time: 0x%02x\n", ext_csd[248]); >> + seq_printf(s, "power_off_long_time: 0x%02x\n", ext_csd[247]); >> + } >> + >> + /* A441: Reserved [501:247] >> + A43: reserved [246:229] */ >> + if (ext_csd_rev >= 5) { >> + seq_printf(s, "ini_timeout_ap: 0x%02x\n", ext_csd[241]); >> + /* A441: reserved [240] */ >> + seq_printf(s, "pwr_cl_ddr_52_360 0x%02x\n", ext_csd[239]); > > You lost the colon after the property name starting from this line. > I sugges you keep it. (I had to read the spec to know that these > were actually called properities, who knew?) > >> + seq_printf(s, "pwr_cl_ddr_52_195 0x%02x\n", ext_csd[238]); >> + >> + /* A441: reserved [237-236] */ >> + >> + if (ext_csd_rev >= 6) { >> + seq_printf(s, "pwr_cl_200_360 0x%02x\n", ext_csd[237]); >> + seq_printf(s, "pwr_cl_200_195 0x%02x\n", ext_csd[236]); >> + } >> + >> + seq_printf(s, "min_perf_ddr_w_8_52 0x%02x\n", ext_csd[235]); >> + seq_printf(s, "min_perf_ddr_r_8_52 0x%02x\n", ext_csd[234]); >> + /* A441: reserved [233] */ >> + seq_printf(s, "trim_mult 0x%02x\n", ext_csd[232]); >> + seq_printf(s, "sec_feature_support 0x%02x\n", ext_csd[231]); >> + } >> + if (ext_csd_rev == 5) { /* Obsolete in 4.5 */ >> + seq_printf(s, "sec_erase_mult 0x%02x\n", ext_csd[230]); >> + seq_printf(s, "sec_trim_mult 0x%02x\n", ext_csd[229]); >> + } >> + seq_printf(s, "boot_info 0x%02x\n", ext_csd[228]); >> + /* A441/A43: reserved [227] */ >> + seq_printf(s, "boot_size_multi 0x%02x\n", ext_csd[226]); >> + seq_printf(s, "acc_size 0x%02x\n", ext_csd[225]); >> + seq_printf(s, "hc_erase_grp_size 0x%02x\n", ext_csd[224]); >> + seq_printf(s, "erase_timeout_mult 0x%02x\n", ext_csd[223]); >> + seq_printf(s, "rel_wr_sec_c 0x%02x\n", ext_csd[222]); >> + seq_printf(s, "hc_wp_grp_size 0x%02x\n", ext_csd[221]); >> + seq_printf(s, "s_c_vcc 0x%02x\n", ext_csd[220]); >> + seq_printf(s, "s_c_vccq 0x%02x\n", ext_csd[219]); >> + /* A441/A43: reserved [218] */ >> + seq_printf(s, "s_a_timeout 0x%02x\n", ext_csd[217]); >> + /* A441/A43: reserved [216] */ >> + seq_printf(s, "sec_count 0x%02x\n", (ext_csd[215] << 24) | > > 0x%08x or %d would be better I believe. > >> + (ext_csd[214] << 16) | (ext_csd[213] << 8) | >> + ext_csd[212]); >> + /* A441/A43: reserved [211] */ >> + seq_printf(s, "min_perf_w_8_52 0x%02x\n", ext_csd[210]); >> + seq_printf(s, "min_perf_r_8_52 0x%02x\n", ext_csd[209]); >> + seq_printf(s, "min_perf_w_8_26_4_52 0x%02x\n", ext_csd[208]); >> + seq_printf(s, "min_perf_r_8_26_4_52 0x%02x\n", ext_csd[207]); >> + seq_printf(s, "min_perf_w_4_26 0x%02x\n", ext_csd[206]); >> + seq_printf(s, "min_perf_r_4_26 0x%02x\n", ext_csd[205]); >> + /* A441/A43: reserved [204] */ >> + seq_printf(s, "pwr_cl_26_360 0x%02x\n", ext_csd[203]); >> + seq_printf(s, "pwr_cl_52_360 0x%02x\n", ext_csd[202]); >> + seq_printf(s, "pwr_cl_26_195 0x%02x\n", ext_csd[201]); >> + seq_printf(s, "pwr_cl_52_195 0x%02x\n", ext_csd[200]); >> + >> + /* A43: reserved [199:198] */ >> + if (ext_csd_rev >= 5) { >> + seq_printf(s, "partition_switch_time 0x%02x\n", ext_csd[199]); >> + seq_printf(s, "out_of_interrupt_time 0x%02x\n", ext_csd[198]); >> + } >> + >> + /* A441/A43: reserved [197] [195] [193] [190] [188] >> + * [186] [184] [182] [180] [176] */ >> + >> + if (ext_csd_rev >= 6) >> + seq_printf(s, "driver_strength 0x%02x\n", ext_csd[197]); >> + >> + seq_printf(s, "card_type 0x%02x\n", ext_csd[196]); >> + seq_printf(s, "csd_structure 0x%02x\n", ext_csd[194]); >> + seq_printf(s, "ext_csd_rev 0x%02x\n", ext_csd[192]); >> + seq_printf(s, "cmd_set 0x%02x\n", ext_csd[191]); >> + seq_printf(s, "cmd_set_rev 0x%02x\n", ext_csd[189]); >> + seq_printf(s, "power_class 0x%02x\n", ext_csd[187]); >> + seq_printf(s, "hs_timing 0x%02x\n", ext_csd[185]); >> + seq_printf(s, "bus_width 0x%02x\n", ext_csd[183]); > > hm.. spec 4.5 defines this as not readable. I wonder it it makes > sense to print it? I guess that any card would transfer 0 or some > other constant value in this property... > >> + seq_printf(s, "erased_mem_cont 0x%02x\n", ext_csd[181]); >> + seq_printf(s, "partition_config 0x%02x\n", ext_csd[179]); >> + seq_printf(s, "boot_config_prot 0x%02x\n", ext_csd[178]); >> + seq_printf(s, "boot_bus_width 0x%02x\n", ext_csd[177]); > > boot_bus_conditions according to spec 4.5... > >> + seq_printf(s, "erase_group_def 0x%02x\n", ext_csd[175]); >> + >> + /* A43: reserved [174:0] / A441: reserved [174] */ > > maybe, but spec 4.5 seems to define (though I admit that the line > in the table is curiously grayed out, maybe it's a typo in the spec > since 174 used to be reserved in 4.41...): > > seq_printf(s, "boot_wp_status 0x%02x\n", ext_csd[174]); > >> + if (ext_csd_rev >= 5) { >> + seq_printf(s, "boot_wp 0x%02x\n", ext_csd[173]); >> + /* A441: reserved [172] */ >> + seq_printf(s, "user_wp 0x%02x\n", ext_csd[171]); >> + /* A441: reserved [170] */ >> + seq_printf(s, "fw_config 0x%02x\n", ext_csd[169]); >> + seq_printf(s, "rpmb_size_mult 0x%02x\n", ext_csd[168]); >> + seq_printf(s, "wr_rel_set 0x%02x\n", ext_csd[167]); >> + seq_printf(s, "wr_rel_param 0x%02x\n", ext_csd[166]); >> + /* A441: reserved [165] */ > > spec 4.5 seems to define sanitize_start here, but as for bus_width > above, it is not really readable. I don't know whether you should > include it or not. it may just be confusing. but either way the comment > should be updated to reflect that 4.5 does indeed have a property here. > > seq_printf(s, "sanitize_start: 0x%02x\n", ext_csd[165]); > >> + seq_printf(s, "bkops_start 0x%02x\n", ext_csd[164]); > > this is only writeable, same as for bus_width... > >> + seq_printf(s, "bkops_en 0x%02x\n", ext_csd[163]); >> + seq_printf(s, "rst_n_function 0x%02x\n", ext_csd[162]); >> + seq_printf(s, "hpi_mgmt 0x%02x\n", ext_csd[161]); >> + seq_printf(s, "partitioning_support 0x%02x\n", ext_csd[160]); >> + seq_printf(s, "max_enh_size_mult[2] 0x%02x\n", ext_csd[159]); >> + seq_printf(s, "max_enh_size_mult[1] 0x%02x\n", ext_csd[158]); >> + seq_printf(s, "max_enh_size_mult[0] 0x%02x\n", ext_csd[157]); > > seq_printf(s, "max_enh_size_mult: 0x%06x\n", (ext_csd[159] << 16) | > (ext_csd[158] << 8) | ext_csd[157]); > > this seems more to fit with your handling of sec_count above. > >> + seq_printf(s, "partitions_attribute 0x%02x\n", ext_csd[156]); >> + seq_printf(s, "partition_setting_completed 0x%02x\n", >> + ext_csd[155]); >> + seq_printf(s, "gp_size_mult_4[2] 0x%02x\n", ext_csd[154]); >> + seq_printf(s, "gp_size_mult_4[1] 0x%02x\n", ext_csd[153]); >> + seq_printf(s, "gp_size_mult_4[0] 0x%02x\n", ext_csd[152]); >> + seq_printf(s, "gp_size_mult_3[2] 0x%02x\n", ext_csd[151]); >> + seq_printf(s, "gp_size_mult_3[1] 0x%02x\n", ext_csd[150]); >> + seq_printf(s, "gp_size_mult_3[0] 0x%02x\n", ext_csd[149]); >> + seq_printf(s, "gp_size_mult_2[2] 0x%02x\n", ext_csd[148]); >> + seq_printf(s, "gp_size_mult_2[1] 0x%02x\n", ext_csd[147]); >> + seq_printf(s, "gp_size_mult_2[0] 0x%02x\n", ext_csd[146]); >> + seq_printf(s, "gp_size_mult_1[2] 0x%02x\n", ext_csd[145]); >> + seq_printf(s, "gp_size_mult_1[1] 0x%02x\n", ext_csd[144]); >> + seq_printf(s, "gp_size_mult_1[0] 0x%02x\n", ext_csd[143]); >> + seq_printf(s, "enh_size_mult[2] 0x%02x\n", ext_csd[142]); >> + seq_printf(s, "enh_size_mult[1] 0x%02x\n", ext_csd[141]); >> + seq_printf(s, "enh_size_mult[0] 0x%02x\n", ext_csd[140]); >> + seq_printf(s, "enh_start_addr[3] 0x%02x\n", ext_csd[139]); >> + seq_printf(s, "enh_start_addr[2] 0x%02x\n", ext_csd[138]); >> + seq_printf(s, "enh_start_addr[1] 0x%02x\n", ext_csd[137]); >> + seq_printf(s, "enh_start_addr[0] 0x%02x\n", ext_csd[136]); > > seq_printf(s, "gp_size_mult_4: 0x%06x\n", (ext_csd[154] << 16) | > (ext_csd[153] << 8) | ext_csd[152]); > seq_printf(s, "gp_size_mult_3: 0x%06x\n", (ext_csd[151] << 16) | > (ext_csd[150] << 8) | ext_csd[149]); > seq_printf(s, "gp_size_mult_2: 0x%06x\n", (ext_csd[148] << 16) | > (ext_csd[147] << 8) | ext_csd[146]); > seq_printf(s, "gp_size_mult_1: 0x%06x\n", (ext_csd[145] << 16) | > (ext_csd[144] << 8) | ext_csd[143]); > seq_printf(s, "enh_size_mult: 0x%06x\n", (ext_csd[142] << 16) | > (ext_csd[141] << 8) | ext_csd[140]); > seq_printf(s, "enh_start_addr: 0x%06x\n", (ext_csd[139] << 16) | > (ext_csd[138] << 8) | ext_csd[137]); > > same comment as for max_enh_size_mult... > >> + /* A441: reserved [135] */ >> + seq_printf(s, "sec_bad_blk_mgmnt 0x%02x\n", ext_csd[134]); >> + /* A441: reserved [133:0] */ >> + } >> + /* B45 */ >> + if (ext_csd_rev >= 6) { >> + int j; >> + seq_printf(s, "tcase_support 0x%02x\n", ext_csd[132]); > > not readable according to spec 4.5... > also spec 4.5 defines which you may want to include: > > seq_printf(s, "periodic_wakeup: 0x%02x\n", ext_csd[131]); > >> + seq_printf(s, "program_cid_csd_ddr_support 0x%02x\n", >> + ext_csd[130]); >> + >> + seq_printf(s, "vendor_specific_field:\n"); >> + for (j = 127; j >= 64; j--) >> + seq_printf(s, "\t[%d] 0x%02x\n", j, ext_csd[j]); > > printing an array here make sense (since it _is_ really a byte array), > but what about replacing the last three lines with: > > for (j = 127; j >= 64; j--) > seq_printf(s, "vendor_specific_field[%d]: 0x%02x\n", j, ext_csd[j]); > > that way all lines in the sysfs-file follow the same format without indentation. > >> + >> + seq_printf(s, "native_sector_size 0x%02x\n", ext_csd[63]); >> + seq_printf(s, "use_native_sector 0x%02x\n", ext_csd[62]); >> + seq_printf(s, "data_sector_size 0x%02x\n", ext_csd[61]); >> + seq_printf(s, "ini_timeout_emu 0x%02x\n", ext_csd[60]); >> + seq_printf(s, "class_6_ctrl 0x%02x\n", ext_csd[59]); >> + seq_printf(s, "dyncap_needed 0x%02x\n", ext_csd[58]); >> + seq_printf(s, "exception_events_ctrl[1] 0x%02x\n", ext_csd[57]); >> + seq_printf(s, "exception_events_ctrl[0] 0x%02x\n", ext_csd[56]); >> + seq_printf(s, "exception_events_status[1] 0x%02x\n", >> + ext_csd[55]); >> + seq_printf(s, "exception_events_status[0] 0x%02x\n", >> + ext_csd[54]); >> + seq_printf(s, "ext_partition_attribute[1] 0x%02x\n", >> + ext_csd[53]); >> + seq_printf(s, "ext_partition_attribute[0] 0x%02x\n", >> + ext_csd[52]); > > > seq_printf(s, "exception_events_ctrl: 0x%04x\n", (ext_csd[57] << 8) | > ext_csd[56]); > seq_printf(s, "exception_events_status: 0x%04x\n", (ext_csd[55] << 8) > | ext_csd[54]); > seq_printf(s, "ext_partitions_attribute: 0x%04x\n", (ext_csd[53] << 8) > | ext_csd[52]); > > notice the s in partitions... > >> + >> + seq_printf(s, "context_conf:\n"); >> + for (j = 51; j >= 37; j--) >> + seq_printf(s, "\t[%d] 0x%02x\n", j, ext_csd[j]); > > same as for vendor_specific_field above, I would suggest doing > > for (j = 51; j >= 37; j--) > seq_printf(s, "context_conf[%d]: 0x%02x\n", j, ext_csd[j]); > >> + >> + seq_printf(s, "packed_command_status 0x%02x\n", ext_csd[36]); >> + seq_printf(s, "packed_failure_index 0x%02x\n", ext_csd[35]); >> + seq_printf(s, "power_off_notification 0x%02x\n", ext_csd[34]); >> + seq_printf(s, "cache_ctrl 0x%02x\n", ext_csd[33]); >> + seq_printf(s, "flush_cache 0x%02x\n", ext_csd[32]); > > this property is not readable. > >> + /*Reserved [31:0] */ >> + } >> >> out_free: >> - kfree(buf); >> kfree(ext_csd); >> return err; >> } >> >> -static ssize_t mmc_ext_csd_read(struct file *filp, char __user *ubuf, >> - size_t cnt, loff_t *ppos) >> +static int mmc_ext_csd_open(struct inode *inode, struct file *file) >> { >> - char *buf = filp->private_data; >> - >> - return simple_read_from_buffer(ubuf, cnt, ppos, >> - buf, EXT_CSD_STR_LEN); >> -} >> - >> -static int mmc_ext_csd_release(struct inode *inode, struct file *file) >> -{ >> - kfree(file->private_data); >> - return 0; >> + return single_open(file, mmc_ext_csd_read, inode->i_private); >> } >> >> static const struct file_operations mmc_dbg_ext_csd_fops = { >> .open = mmc_ext_csd_open, >> - .read = mmc_ext_csd_read, >> - .release = mmc_ext_csd_release, >> - .llseek = default_llseek, >> + .read = seq_read, >> + .llseek = seq_lseek, >> + .release = single_release, >> }; >> >> void mmc_add_card_debugfs(struct mmc_card *card) >> -- >> 1.7.4.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > / Sebastian > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] mmc: debugfs: parse all ext_csd via debug_fs 2011-10-26 11:27 ` Giuseppe CAVALLARO @ 2011-10-27 7:20 ` Giuseppe CAVALLARO 2011-10-27 14:19 ` Sebastian Rasmussen 1 sibling, 0 replies; 15+ messages in thread From: Giuseppe CAVALLARO @ 2011-10-27 7:20 UTC (permalink / raw) To: Sebastian Rasmussen; +Cc: linux-mmc On 10/26/2011 1:27 PM, Giuseppe CAVALLARO wrote: > On 10/25/2011 1:43 PM, Sebastian Rasmussen wrote: [snip] >> contains a numerical customer id which leads me to believe >> that it would require some kind of list of number->name to >> make it accessible to users, something akin to the lspci >> database. I did write an initial draft of such a userspace tool >> at my old employers over at ST-Ericsson and tried to open >> source it just before I resigned, but I don't know whether it >> has made it through the legal barrier yet. I'll let you know >> if I see it. > > Yes let me know. > > Thanks for the reviewing. I'll look and fix all the points below and > resend the patch again. Hello Sebastian, thanks a lot for the excellent review! I have applied all your advice and re-send the patch (with you on CC) as V2. Let me know. Kind Regards Peppe ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] mmc: debugfs: parse all ext_csd via debug_fs 2011-10-26 11:27 ` Giuseppe CAVALLARO 2011-10-27 7:20 ` Giuseppe CAVALLARO @ 2011-10-27 14:19 ` Sebastian Rasmussen 2011-10-28 7:51 ` Giuseppe CAVALLARO 1 sibling, 1 reply; 15+ messages in thread From: Sebastian Rasmussen @ 2011-10-27 14:19 UTC (permalink / raw) To: Giuseppe CAVALLARO; +Cc: linux-mmc Hi! > Before the patch the output from /sys/kernel/debug/mmc0/mmc0:0001/ext_csd > was a big number and I had many problems parsing it in real-time. >[...] > In any case, the patch wants to help to directly get the ext_csd in a > human format. Yes, I realize this. However I'm unsure whether this parsing should be done in kernelspace at all. If your patch is accepted then it is obvious that people think this belongs in kernelspace rather than in userspace. In addition I wonder what the rationale is behind placing the CID, SCR and CSD registers under /sysfs and EXT_CSD under debugfs. Not that you have chosen this, but do you know why they are accessible at different locations? > Maybe, there is some user-space application to do this job that I do not > know. :-( I have not seen such a program myself, however I have been asking my former colleagues to make such a program open source. I will keep you uptodate if I hear from them and they provide me with the source. >> BTW, you are parsing EXT_CSD here, but then one really >> should expand CSD, SCR, CID as well. One of those > Yes we could parse CID and CSD too. I guess in another patch. I agree. > Please consider this patch for the ext_csd entry in /sys. I guess Chris Ball is the one to convince here, not me. :) >> contains a numerical customer id which leads me to believe >> I did write an initial draft of such a userspace tool at my old >> employers over at ST-Ericsson and tried to open source it just >> before I resigned, but I don't know whether it has made it >> through the legal barrier yet. I'll let you know if I see it. > Yes let me know. I have been in contact with my former colleagues how promised to try to get it through legal. As it stands I can only hope... > Thanks for the reviewing. I'll look and fix all the points below and > resend the patch again. Cool, I noticed that you have already sent v2. :) / Sebastian ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] mmc: debugfs: parse all ext_csd via debug_fs 2011-10-27 14:19 ` Sebastian Rasmussen @ 2011-10-28 7:51 ` Giuseppe CAVALLARO 2011-11-12 1:21 ` Chris Ball 0 siblings, 1 reply; 15+ messages in thread From: Giuseppe CAVALLARO @ 2011-10-28 7:51 UTC (permalink / raw) To: Sebastian Rasmussen; +Cc: linux-mmc, Chris Ball Hello Sebastian, On 10/27/2011 4:19 PM, Sebastian Rasmussen wrote: > Hi! > >> Before the patch the output from /sys/kernel/debug/mmc0/mmc0:0001/ext_csd >> was a big number and I had many problems parsing it in real-time. >> [...] >> In any case, the patch wants to help to directly get the ext_csd in a >> human format. > > Yes, I realize this. However I'm unsure whether this parsing should be > done in kernelspace at all. If your patch is accepted then it is obvious > that people think this belongs in kernelspace rather than in userspace. I've found really useful to have this kind of parsing in Kernel space because, fortunately, we are also using the kernel to validate the HW on our platforms. In my experience, on the validation side (where people are nor Linux Kernel developers although very skilled on other topics) is needed to have a simplified environment (for example a minimal RAM rootFS) so, instead of using user-space tools etc. (IMO), it can help to have all the necessary information from the Kernel itself. Somebody could also say that, for not a Linux expert, it is tricky to walk through a /sys FS ;-). At any rate, it's not a big problem to have user-space applications to parse this kind of information. I love tools like ethtool on network side. In that case, I do hope, the patch will be useful for the user-space. ;-) > In addition I wonder what the rationale is behind placing the CID, SCR > and CSD registers under /sysfs and EXT_CSD under debugfs. Not that you > have chosen this, but do you know why they are accessible at different > locations? Yes, we have seen this but, frankly, I cannot explain why ext_csd are in debugFS. Maybe, for historical reasons.... ext_csd are on new SPEC versions and will come later. /sys/kernel/debug/mmc0/mmc0\:0001/ext_csd /sys/devices/platform/sdhci.0/mmc_host/mmc0/mmc0:0001/cid /sys/devices/platform/sdhci.0/mmc_host/mmc0/mmc0:0001/csd If we accept to have the ext_csd parsed in /sys/kernel/debug I agree with you that we could also have csd and cid treated in the same way. In that case, I promise you to work on that and post new patches asap. >> Maybe, there is some user-space application to do this job that I do not >> know. :-( > > I have not seen such a program myself, however I have been asking > my former colleagues to make such a program open source. I will keep > you uptodate if I hear from them and they provide me with the source. > >>> BTW, you are parsing EXT_CSD here, but then one really >>> should expand CSD, SCR, CID as well. One of those >> Yes we could parse CID and CSD too. I guess in another patch. > > I agree. > >> Please consider this patch for the ext_csd entry in /sys. > > I guess Chris Ball is the one to convince here, not me. :) I added Chris on CC. Welcome yours advice. >>> contains a numerical customer id which leads me to believe >>> I did write an initial draft of such a userspace tool at my old >>> employers over at ST-Ericsson and tried to open source it just >>> before I resigned, but I don't know whether it has made it >>> through the legal barrier yet. I'll let you know if I see it. >> Yes let me know. > > I have been in contact with my former colleagues how promised to > try to get it through legal. As it stands I can only hope... > >> Thanks for the reviewing. I'll look and fix all the points below and >> resend the patch again. > > Cool, I noticed that you have already sent v2. :) :-) Regards Peppe > > / Sebastian > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] mmc: debugfs: parse all ext_csd via debug_fs 2011-10-28 7:51 ` Giuseppe CAVALLARO @ 2011-11-12 1:21 ` Chris Ball 2011-11-12 10:25 ` Linus Walleij 0 siblings, 1 reply; 15+ messages in thread From: Chris Ball @ 2011-11-12 1:21 UTC (permalink / raw) To: Giuseppe CAVALLARO; +Cc: Sebastian Rasmussen, linux-mmc Hi Giuseppe, On Fri, Oct 28 2011, Giuseppe CAVALLARO wrote: > On 10/27/2011 4:19 PM, Sebastian Rasmussen wrote: >> Hi! >> >>> Before the patch the output from /sys/kernel/debug/mmc0/mmc0:0001/ext_csd >>> was a big number and I had many problems parsing it in real-time. >>> [...] >>> In any case, the patch wants to help to directly get the ext_csd in a >>> human format. >> >> Yes, I realize this. However I'm unsure whether this parsing should be >> done in kernelspace at all. If your patch is accepted then it is obvious >> that people think this belongs in kernelspace rather than in userspace. > > I've found really useful to have this kind of parsing in Kernel space > because, fortunately, we are also using the kernel to validate the HW on > our platforms. sysfs has a strict one-value-per-file rule which this patch breaks, but I can see putting something like this in debugfs instead. I'm wary of committing to maintaining a parser for this information in the kernel, though -- does anyone have advice on where this ought to be done? I wonder if we should start an MMC userspace tools repository containing code for features like the cmd passthrough ioctl, secure erase/trim/discard requests, and debugging output of the type this patch provides. On the other hand, maybe existing similar tools should just be modified to learn about how to deal with MMC? Thanks, - Chris. -- Chris Ball <cjb@laptop.org> <http://printf.net/> One Laptop Per Child ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] mmc: debugfs: parse all ext_csd via debug_fs 2011-11-12 1:21 ` Chris Ball @ 2011-11-12 10:25 ` Linus Walleij 0 siblings, 0 replies; 15+ messages in thread From: Linus Walleij @ 2011-11-12 10:25 UTC (permalink / raw) To: Chris Ball; +Cc: Giuseppe CAVALLARO, Sebastian Rasmussen, linux-mmc On Sat, Nov 12, 2011 at 2:21 AM, Chris Ball <cjb@laptop.org> wrote: > I wonder if we should start an MMC userspace tools repository containing > code for features like the cmd passthrough ioctl, secure erase/trim/discard > requests, and debugging output of the type this patch provides. On the > other hand, maybe existing similar tools should just be modified to > learn about how to deal with MMC? Go for mmc-tools.git People might have a lot of useful stuff to throw in there... And I easily see this thing being picked up by distros. If for nothing else it's an opportunity to exercise using Pöttering and Sievers libabc as basis for some kind of userspace lib. http://lwn.net/Articles/465093/ Just my €0.01. Linus Walleij ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] mmc: debugfs: parse all ext_csd via debug_fs 2011-10-25 11:43 ` Sebastian Rasmussen 2011-10-26 11:27 ` Giuseppe CAVALLARO @ 2011-11-12 1:12 ` Linus Walleij 2011-11-21 7:39 ` Giuseppe CAVALLARO 1 sibling, 1 reply; 15+ messages in thread From: Linus Walleij @ 2011-11-12 1:12 UTC (permalink / raw) To: Sebastian Rasmussen; +Cc: Giuseppe CAVALLARO, linux-mmc On Tue, Oct 25, 2011 at 1:43 PM, Sebastian Rasmussen <sebras@gmail.com> wrote: >[Giuseppe] >> This patch enhances the debug information reported >> for the mmc card by parsing the extended CSD registers >> obviously according to all the current specifications. > > Does this belong kernel or in userspace? I'm not sure, and > I'm hoping that any of the old-timers here chime in on it. > Anyway I supply you with a few comments on you patch > below... Since it's in debugfs we can have it as verbose and whatever weird structure we wish. Userspace tools usually don't depend on debugfs ... except for some :-/ (see recent ftrace vs perf debates etc etc) To implement getting at this data in a future-proof way from userspace we should put it in sysfs. And if it was in sysfs we would have to follow the rule "one value per file" with files named after each CSD/etc field. Then to make that human-readable you would need a userspace tool, and preferrably it should also be documented in Documentation/ABI/testing/* And nothing really prevents us from doing both :-) Yours, Linus Walleij ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] mmc: debugfs: parse all ext_csd via debug_fs 2011-11-12 1:12 ` Linus Walleij @ 2011-11-21 7:39 ` Giuseppe CAVALLARO 2011-11-21 10:08 ` Linus Walleij 0 siblings, 1 reply; 15+ messages in thread From: Giuseppe CAVALLARO @ 2011-11-21 7:39 UTC (permalink / raw) To: Linus Walleij, Chris Ball; +Cc: Sebastian Rasmussen, linux-mmc Hello Linus, Chris, On 11/12/2011 2:12 AM, Linus Walleij wrote: > On Tue, Oct 25, 2011 at 1:43 PM, Sebastian Rasmussen<sebras@gmail.com> wrote: >> [Giuseppe] >>> This patch enhances the debug information reported >>> for the mmc card by parsing the extended CSD registers >>> obviously according to all the current specifications. >> >> Does this belong kernel or in userspace? I'm not sure, and >> I'm hoping that any of the old-timers here chime in on it. >> Anyway I supply you with a few comments on you patch >> below... > > Since it's in debugfs we can have it as verbose and whatever > weird structure we wish. Userspace tools usually don't > depend on debugfs ... except for some :-/ (see recent > ftrace vs perf debates etc etc) > > To implement getting at this data in a future-proof way > from userspace we should put it in sysfs. > > And if it was in sysfs we would have to follow the rule > "one value per file" with files named after each CSD/etc > field. Then to make that human-readable you would need > a userspace tool, and preferrably it should also be > documented in Documentation/ABI/testing/* > > And nothing really prevents us from doing both :-) Thanks for all advice and review, I've not clear if at this stage the patch will be added in mmc-next. Just to summarize: the patch works in debugfs context so the parsing doesn't break the sys rules. I agree with Chris this has to be maintained for the next mmc standards but IMO we can pay this waiting for having both a user-space application (mmc-tool) and the ext_csd in /sys (after that the ext_csd in debugfs could be completely removed). Let me know. Best Regards Giuseppe > > Yours, > Linus Walleij > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] mmc: debugfs: parse all ext_csd via debug_fs 2011-11-21 7:39 ` Giuseppe CAVALLARO @ 2011-11-21 10:08 ` Linus Walleij 2011-12-06 5:52 ` Giuseppe CAVALLARO 0 siblings, 1 reply; 15+ messages in thread From: Linus Walleij @ 2011-11-21 10:08 UTC (permalink / raw) To: Giuseppe CAVALLARO; +Cc: Chris Ball, Sebastian Rasmussen, linux-mmc On Mon, Nov 21, 2011 at 8:39 AM, Giuseppe CAVALLARO <peppe.cavallaro@st.com> wrote: > Just to summarize: the patch works in debugfs context so the parsing doesn't > break the sys rules. I agree with Chris this has to be maintained for the > next mmc standards but IMO we can pay this waiting for having both a > user-space application (mmc-tool) and the ext_csd in /sys (after that the > ext_csd in debugfs could be completely removed). I'm all for this patch so it gets visible in debugfs atleast, since people seem to need to know these things, so take that as an Acked-by: Linus Walleij <linus.walleij@linaro.org> Those who want to writ userspace tools can proceed to implement the proper sysfs interfaces and document them. Thanks, Linus Walleij ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] mmc: debugfs: parse all ext_csd via debug_fs 2011-11-21 10:08 ` Linus Walleij @ 2011-12-06 5:52 ` Giuseppe CAVALLARO 2011-12-13 16:35 ` Chris Ball 0 siblings, 1 reply; 15+ messages in thread From: Giuseppe CAVALLARO @ 2011-12-06 5:52 UTC (permalink / raw) To: Chris Ball; +Cc: Linus Walleij, Sebastian Rasmussen, linux-mmc On 11/21/2011 11:08 AM, Linus Walleij wrote: > On Mon, Nov 21, 2011 at 8:39 AM, Giuseppe CAVALLARO > <peppe.cavallaro@st.com> wrote: > >> Just to summarize: the patch works in debugfs context so the parsing doesn't >> break the sys rules. I agree with Chris this has to be maintained for the >> next mmc standards but IMO we can pay this waiting for having both a >> user-space application (mmc-tool) and the ext_csd in /sys (after that the >> ext_csd in debugfs could be completely removed). > > I'm all for this patch so it gets visible in debugfs atleast, > since people seem to need to know these things, so take that as an > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > Those who want to writ userspace tools can proceed to > implement the proper sysfs interfaces and document them. Hello Chris. Sorry if I disturb you, any news about the patch: mmc: debugfs: parse ext_csd via debug_fs (v2) Reviewed-by Sebastian and Acked-by Linus? Please let me know if I need to do some other work on this or if it can be considered for mmc-next. Best Regards Peppe ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] mmc: debugfs: parse all ext_csd via debug_fs 2011-12-06 5:52 ` Giuseppe CAVALLARO @ 2011-12-13 16:35 ` Chris Ball 2011-12-15 13:08 ` Giuseppe CAVALLARO 0 siblings, 1 reply; 15+ messages in thread From: Chris Ball @ 2011-12-13 16:35 UTC (permalink / raw) To: Giuseppe CAVALLARO; +Cc: Linus Walleij, Sebastian Rasmussen, linux-mmc Hi Peppe, On Tue, Dec 06 2011, Giuseppe CAVALLARO wrote: >> I'm all for this patch so it gets visible in debugfs atleast, >> since people seem to need to know these things, so take that as an >> Acked-by: Linus Walleij <linus.walleij@linaro.org> >> >> Those who want to writ userspace tools can proceed to >> implement the proper sysfs interfaces and document them. > > Hello Chris. > > Sorry if I disturb you, any news about the patch: > > mmc: debugfs: parse ext_csd via debug_fs (v2) > > Reviewed-by Sebastian and Acked-by Linus? > > Please let me know if I need to do some other work on this or if it can > be considered for mmc-next. I'm still leaning towards doing this in userspace instead -- once we have a userspace binary that can do this I don't think there'll be any reason to keep a debugfs interface for the same thing around, and that tells me that we should just avoid merging the debugfs interface and move to userspace straight away. I'm hoping to get the userspace tools repository running soon. Thanks, - Chris. -- Chris Ball <cjb@laptop.org> <http://printf.net/> One Laptop Per Child ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] mmc: debugfs: parse all ext_csd via debug_fs 2011-12-13 16:35 ` Chris Ball @ 2011-12-15 13:08 ` Giuseppe CAVALLARO 0 siblings, 0 replies; 15+ messages in thread From: Giuseppe CAVALLARO @ 2011-12-15 13:08 UTC (permalink / raw) To: Chris Ball; +Cc: Linus Walleij, Sebastian Rasmussen, linux-mmc Hi Chris On 12/13/2011 5:35 PM, Chris Ball wrote: > Hi Peppe, > > On Tue, Dec 06 2011, Giuseppe CAVALLARO wrote: >>> I'm all for this patch so it gets visible in debugfs atleast, >>> since people seem to need to know these things, so take that as an >>> Acked-by: Linus Walleij <linus.walleij@linaro.org> >>> >>> Those who want to writ userspace tools can proceed to >>> implement the proper sysfs interfaces and document them. >> >> Hello Chris. >> >> Sorry if I disturb you, any news about the patch: >> >> mmc: debugfs: parse ext_csd via debug_fs (v2) >> >> Reviewed-by Sebastian and Acked-by Linus? >> >> Please let me know if I need to do some other work on this or if it can >> be considered for mmc-next. > > I'm still leaning towards doing this in userspace instead -- once we > have a userspace binary that can do this I don't think there'll be any > reason to keep a debugfs interface for the same thing around, and that > tells me that we should just avoid merging the debugfs interface and > move to userspace straight away. > > I'm hoping to get the userspace tools repository running soon. that sounds good to me. As soon as the tool is available I'll contribute with these changes. Let me know Peppe > > Thanks, > > - Chris. ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] mmc: debugfs: parse ext_csd via debug_fs (v2) 2011-10-24 15:04 [PATCH] mmc: debugfs: parse all ext_csd via debug_fs Giuseppe CAVALLARO 2011-10-25 11:43 ` Sebastian Rasmussen @ 2011-10-27 7:16 ` Giuseppe CAVALLARO 1 sibling, 0 replies; 15+ messages in thread From: Giuseppe CAVALLARO @ 2011-10-27 7:16 UTC (permalink / raw) To: linux-mmc; +Cc: sebras, Giuseppe Cavallaro This patch enhances the debug information reported for the mmc card by parsing the extended CSD registers obviously according to all the current specifications. I have no HW to test eMMC 4.5 at this moment. In any case, the patch supports JEDEC Standard No. 84-B45. No issues on JESD84-A441 and older specs raised on my side. Output from /sys/kernel/debug/mmc0/mmc0:0001/ext_csd looks like this: Extended CSD rev 1.5 (MMC 4.41) s_cmd_set: 0x01 hpi_features: 0x00 blops_support: 0x00 ini_timeout_ap: 0x0a pwr_cl_ddr_52_360 0x00 [snip] Reported-by: Youssef Triki <youssef.triki@st.com> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> --- drivers/mmc/core/debugfs.c | 252 ++++++++++++++++++++++++++++++++++++++------ 1 files changed, 218 insertions(+), 34 deletions(-) diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c index 0b9a4aa..fa26cf9 100644 --- a/drivers/mmc/core/debugfs.c +++ b/drivers/mmc/core/debugfs.c @@ -223,19 +223,13 @@ static int mmc_dbg_card_status_get(void *data, u64 *val) DEFINE_SIMPLE_ATTRIBUTE(mmc_dbg_card_status_fops, mmc_dbg_card_status_get, NULL, "%08llx\n"); -#define EXT_CSD_STR_LEN 1025 - -static int mmc_ext_csd_open(struct inode *inode, struct file *filp) +static int mmc_ext_csd_read(struct seq_file *s, void *data) { - struct mmc_card *card = inode->i_private; - char *buf; - ssize_t n = 0; + struct mmc_card *card = s->private; u8 *ext_csd; - int err, i; - - buf = kmalloc(EXT_CSD_STR_LEN + 1, GFP_KERNEL); - if (!buf) - return -ENOMEM; + u8 ext_csd_rev; + int err; + const char *str; ext_csd = kmalloc(512, GFP_KERNEL); if (!ext_csd) { @@ -249,41 +243,231 @@ static int mmc_ext_csd_open(struct inode *inode, struct file *filp) if (err) goto out_free; - for (i = 511; i >= 0; i--) - n += sprintf(buf + n, "%02x", ext_csd[i]); - n += sprintf(buf + n, "\n"); - BUG_ON(n != EXT_CSD_STR_LEN); + ext_csd_rev = ext_csd[192]; - filp->private_data = buf; - kfree(ext_csd); - return 0; + switch (ext_csd_rev) { + case 6: + str = "4.5"; + break; + case 5: + str = "4.41"; + break; + case 3: + str = "4.3"; + break; + case 2: + str = "4.2"; + break; + case 1: + str = "4.1"; + break; + case 0: + str = "4.0"; + break; + default: + goto out_free; + } + seq_printf(s, "Extended CSD rev 1.%d (MMC %s)\n", ext_csd_rev, str); + + if (ext_csd_rev < 3) + goto out_free; /* No ext_csd */ + + /* Parse the Extended CSD registers. + * Reserved bit should be read as "0" in case of spec older + * than A441. + */ + seq_printf(s, "s_cmd_set: 0x%02x\n", ext_csd[504]); + seq_printf(s, "hpi_features: 0x%02x\n", ext_csd[503]); + seq_printf(s, "bkops_support: 0x%02x\n", ext_csd[502]); + + if (ext_csd_rev >= 6) { + seq_printf(s, "max_packed_reads: 0x%02x\n", ext_csd[501]); + seq_printf(s, "max_packed_writes: 0x%02x\n", ext_csd[500]); + seq_printf(s, "data_tag_support: 0x%02x\n", ext_csd[499]); + seq_printf(s, "tag_unit_size: 0x%02x\n", ext_csd[498]); + seq_printf(s, "tag_res_size: 0x%02x\n", ext_csd[497]); + seq_printf(s, "context_capabilities: 0x%02x\n", ext_csd[496]); + seq_printf(s, "large_unit_size_m1: 0x%02x\n", ext_csd[495]); + seq_printf(s, "ext_support: 0x%02x\n", ext_csd[494]); + seq_printf(s, "generic_cmd6_time: 0x%02x\n", ext_csd[248]); + seq_printf(s, "power_off_long_time: 0x%02x\n", ext_csd[247]); + seq_printf(s, "cache_size %d KiB\n", ext_csd[249] << 0 | + (ext_csd[250] << 8) | (ext_csd[251] << 16) | + (ext_csd[252] << 24)); + } + + /* A441: Reserved [501:247] + A43: reserved [246:229] */ + if (ext_csd_rev >= 5) { + seq_printf(s, "ini_timeout_ap: 0x%02x\n", ext_csd[241]); + /* A441: reserved [240] */ + seq_printf(s, "pwr_cl_ddr_52_360: 0x%02x\n", ext_csd[239]); + seq_printf(s, "pwr_cl_ddr_52_195: 0x%02x\n", ext_csd[238]); + + /* A441: reserved [237-236] */ + + if (ext_csd_rev >= 6) { + seq_printf(s, "pwr_cl_200_360: 0x%02x\n", ext_csd[237]); + seq_printf(s, "pwr_cl_200_195: 0x%02x\n", ext_csd[236]); + } + + seq_printf(s, "min_perf_ddr_w_8_52: 0x%02x\n", ext_csd[235]); + seq_printf(s, "min_perf_ddr_r_8_52: 0x%02x\n", ext_csd[234]); + /* A441: reserved [233] */ + seq_printf(s, "trim_mult: 0x%02x\n", ext_csd[232]); + seq_printf(s, "sec_feature_support: 0x%02x\n", ext_csd[231]); + } + if (ext_csd_rev == 5) { /* Obsolete in 4.5 */ + seq_printf(s, "sec_erase_mult: 0x%02x\n", ext_csd[230]); + seq_printf(s, "sec_trim_mult: 0x%02x\n", ext_csd[229]); + } + seq_printf(s, "boot_info: 0x%02x\n", ext_csd[228]); + /* A441/A43: reserved [227] */ + seq_printf(s, "boot_size_multi: 0x%02x\n", ext_csd[226]); + seq_printf(s, "acc_size: 0x%02x\n", ext_csd[225]); + seq_printf(s, "hc_erase_grp_size: 0x%02x\n", ext_csd[224]); + seq_printf(s, "erase_timeout_mult: 0x%02x\n", ext_csd[223]); + seq_printf(s, "rel_wr_sec_c: 0x%02x\n", ext_csd[222]); + seq_printf(s, "hc_wp_grp_size: 0x%02x\n", ext_csd[221]); + seq_printf(s, "s_c_vcc: 0x%02x\n", ext_csd[220]); + seq_printf(s, "s_c_vccq: 0x%02x\n", ext_csd[219]); + /* A441/A43: reserved [218] */ + seq_printf(s, "s_a_timeout: 0x%02x\n", ext_csd[217]); + /* A441/A43: reserved [216] */ + seq_printf(s, "sec_count: 0x%08x\n", (ext_csd[215] << 24) | + (ext_csd[214] << 16) | (ext_csd[213] << 8) | + ext_csd[212]); + /* A441/A43: reserved [211] */ + seq_printf(s, "min_perf_w_8_52: 0x%02x\n", ext_csd[210]); + seq_printf(s, "min_perf_r_8_52: 0x%02x\n", ext_csd[209]); + seq_printf(s, "min_perf_w_8_26_4_52: 0x%02x\n", ext_csd[208]); + seq_printf(s, "min_perf_r_8_26_4_52: 0x%02x\n", ext_csd[207]); + seq_printf(s, "min_perf_w_4_26: 0x%02x\n", ext_csd[206]); + seq_printf(s, "min_perf_r_4_26: 0x%02x\n", ext_csd[205]); + /* A441/A43: reserved [204] */ + seq_printf(s, "pwr_cl_26_360: 0x%02x\n", ext_csd[203]); + seq_printf(s, "pwr_cl_52_360: 0x%02x\n", ext_csd[202]); + seq_printf(s, "pwr_cl_26_195: 0x%02x\n", ext_csd[201]); + seq_printf(s, "pwr_cl_52_195: 0x%02x\n", ext_csd[200]); + + /* A43: reserved [199:198] */ + if (ext_csd_rev >= 5) { + seq_printf(s, "partition_switch_time: 0x%02x\n", ext_csd[199]); + seq_printf(s, "out_of_interrupt_time: 0x%02x\n", ext_csd[198]); + } + + /* A441/A43: reserved [197] [195] [193] [190] [188] + * [186] [184] [182] [180] [176] */ + + if (ext_csd_rev >= 6) + seq_printf(s, "driver_strength: 0x%02x\n", ext_csd[197]); + + seq_printf(s, "card_type: 0x%02x\n", ext_csd[196]); + seq_printf(s, "csd_structure: 0x%02x\n", ext_csd[194]); + seq_printf(s, "ext_csd_rev: 0x%02x\n", ext_csd[192]); + seq_printf(s, "cmd_set: 0x%02x\n", ext_csd[191]); + seq_printf(s, "cmd_set_rev: 0x%02x\n", ext_csd[189]); + seq_printf(s, "power_class: 0x%02x\n", ext_csd[187]); + seq_printf(s, "hs_timing: 0x%02x\n", ext_csd[185]); + /* bus_width: ext_csd[183] not readable */ + seq_printf(s, "erased_mem_cont: 0x%02x\n", ext_csd[181]); + seq_printf(s, "partition_config: 0x%02x\n", ext_csd[179]); + seq_printf(s, "boot_config_prot: 0x%02x\n", ext_csd[178]); + seq_printf(s, "boot_bus_conditions: 0x%02x\n", ext_csd[177]); + seq_printf(s, "erase_group_def: 0x%02x\n", ext_csd[175]); + + /* A43: reserved [174:0] */ + if (ext_csd_rev >= 5) { + seq_printf(s, "boot_wp_status: 0x%02x\n", ext_csd[174]); + seq_printf(s, "boot_wp: 0x%02x\n", ext_csd[173]); + /* A441: reserved [172] */ + seq_printf(s, "user_wp: 0x%02x\n", ext_csd[171]); + /* A441: reserved [170] */ + seq_printf(s, "fw_config: 0x%02x\n", ext_csd[169]); + seq_printf(s, "rpmb_size_mult: 0x%02x\n", ext_csd[168]); + seq_printf(s, "wr_rel_set: 0x%02x\n", ext_csd[167]); + seq_printf(s, "wr_rel_param: 0x%02x\n", ext_csd[166]); + /* sanitize_start ext_csd[165]: not readable + * bkops_start ext_csd[164]: only writable */ + seq_printf(s, "bkops_en: 0x%02x\n", ext_csd[163]); + seq_printf(s, "rst_n_function: 0x%02x\n", ext_csd[162]); + seq_printf(s, "hpi_mgmt: 0x%02x\n", ext_csd[161]); + seq_printf(s, "partitioning_support: 0x%02x\n", ext_csd[160]); + seq_printf(s, "max_enh_size_mult: 0x%06x\n", + (ext_csd[159] << 16) | (ext_csd[158] << 8) | + ext_csd[157]); + seq_printf(s, "partitions_attribute: 0x%02x\n", ext_csd[156]); + seq_printf(s, "partition_setting_completed: 0x%02x\n", + ext_csd[155]); + seq_printf(s, "gp_size_mult_4: 0x%06x\n", (ext_csd[154] << 16) | + (ext_csd[153] << 8) | ext_csd[152]); + seq_printf(s, "gp_size_mult_3: 0x%06x\n", (ext_csd[151] << 16) | + (ext_csd[150] << 8) | ext_csd[149]); + seq_printf(s, "gp_size_mult_2: 0x%06x\n", (ext_csd[148] << 16) | + (ext_csd[147] << 8) | ext_csd[146]); + seq_printf(s, "gp_size_mult_1: 0x%06x\n", (ext_csd[145] << 16) | + (ext_csd[144] << 8) | ext_csd[143]); + seq_printf(s, "enh_size_mult: 0x%06x\n", (ext_csd[142] << 16) | + (ext_csd[141] << 8) | ext_csd[140]); + seq_printf(s, "enh_start_addr: 0x%06x\n", (ext_csd[139] << 16) | + (ext_csd[138] << 8) | ext_csd[137]); + + /* A441: reserved [135] */ + seq_printf(s, "sec_bad_blk_mgmnt: 0x%02x\n", ext_csd[134]); + /* A441: reserved [133:0] */ + } + /* B45 */ + if (ext_csd_rev >= 6) { + int j; + /* tcase_support ext_csd[132] not readable */ + seq_printf(s, "periodic_wakeup: 0x%02x\n", ext_csd[131]); + seq_printf(s, "program_cid_csd_ddr_support: 0x%02x\n", + ext_csd[130]); + + for (j = 127; j >= 64; j--) + seq_printf(s, "vendor_specific_field[%d]: 0x%02x\n", + j, ext_csd[j]); + + seq_printf(s, "native_sector_size: 0x%02x\n", ext_csd[63]); + seq_printf(s, "use_native_sector: 0x%02x\n", ext_csd[62]); + seq_printf(s, "data_sector_size: 0x%02x\n", ext_csd[61]); + seq_printf(s, "ini_timeout_emu: 0x%02x\n", ext_csd[60]); + seq_printf(s, "class_6_ctrl: 0x%02x\n", ext_csd[59]); + seq_printf(s, "dyncap_needed: 0x%02x\n", ext_csd[58]); + seq_printf(s, "exception_events_ctrl: 0x%04x\n", + (ext_csd[57] << 8) | ext_csd[56]); + seq_printf(s, "exception_events_status: 0x%04x\n", + (ext_csd[55] << 8) | ext_csd[54]); + seq_printf(s, "ext_partitions_attribute: 0x%04x\n", + (ext_csd[53] << 8) | ext_csd[52]); + + for (j = 51; j >= 37; j--) + seq_printf(s, "context_conf[%d]: 0x%02x\n", j, + ext_csd[j]); + + seq_printf(s, "packed_command_status: 0x%02x\n", ext_csd[36]); + seq_printf(s, "packed_failure_index: 0x%02x\n", ext_csd[35]); + seq_printf(s, "power_off_notification: 0x%02x\n", ext_csd[34]); + seq_printf(s, "cache_ctrl: 0x%02x\n", ext_csd[33]); + /* flush_cache ext_csd[32] not readable */ + /*Reserved [31:0] */ + } out_free: - kfree(buf); kfree(ext_csd); return err; } -static ssize_t mmc_ext_csd_read(struct file *filp, char __user *ubuf, - size_t cnt, loff_t *ppos) +static int mmc_ext_csd_open(struct inode *inode, struct file *file) { - char *buf = filp->private_data; - - return simple_read_from_buffer(ubuf, cnt, ppos, - buf, EXT_CSD_STR_LEN); -} - -static int mmc_ext_csd_release(struct inode *inode, struct file *file) -{ - kfree(file->private_data); - return 0; + return single_open(file, mmc_ext_csd_read, inode->i_private); } static const struct file_operations mmc_dbg_ext_csd_fops = { .open = mmc_ext_csd_open, - .read = mmc_ext_csd_read, - .release = mmc_ext_csd_release, - .llseek = default_llseek, + .read = seq_read, + .llseek = seq_lseek, + .release = single_release, }; void mmc_add_card_debugfs(struct mmc_card *card) -- 1.7.4.4 ^ permalink raw reply related [flat|nested] 15+ messages in thread
end of thread, other threads:[~2011-12-15 13:08 UTC | newest] Thread overview: 15+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-10-24 15:04 [PATCH] mmc: debugfs: parse all ext_csd via debug_fs Giuseppe CAVALLARO 2011-10-25 11:43 ` Sebastian Rasmussen 2011-10-26 11:27 ` Giuseppe CAVALLARO 2011-10-27 7:20 ` Giuseppe CAVALLARO 2011-10-27 14:19 ` Sebastian Rasmussen 2011-10-28 7:51 ` Giuseppe CAVALLARO 2011-11-12 1:21 ` Chris Ball 2011-11-12 10:25 ` Linus Walleij 2011-11-12 1:12 ` Linus Walleij 2011-11-21 7:39 ` Giuseppe CAVALLARO 2011-11-21 10:08 ` Linus Walleij 2011-12-06 5:52 ` Giuseppe CAVALLARO 2011-12-13 16:35 ` Chris Ball 2011-12-15 13:08 ` Giuseppe CAVALLARO 2011-10-27 7:16 ` [PATCH] mmc: debugfs: parse ext_csd via debug_fs (v2) Giuseppe CAVALLARO
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.