Re: [Qemu-devel] [PATCH] qxl: create slots on post_load in vga state

[Gerd Hoffmann <kraxel@redhat.com>]

On 10/25/11 15:39, Alon Levy wrote:
> RHBZ 740547
> 
> If we migrate when the device is in vga state the guest
> still believes the slots are created, and will cause operations
> that reference the slots, causing a "panic: virtual address out of range"
> on the first of them. Easy to see by migrating in vga mode with
> a driver loaded, for instance windows cmd window in full screen mode,
> and then exiting vga mode back to native mode will cause said panic.
> 
> Fixed by doing the slot recreation in post_load for vga mode as well.
> Note that compat does not require any changes because it creates it's
> only slot by a side effect of QXL_IO_SET_MODE.
> 
> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
> v4:
>  don't print unused delta in qxl_create_memslots
> v3:
>  no need to create slots in compat mode, they are created by qxl_set_mode.
> 

Patch added to spice patch queue.

thanks,
  Gerd