From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [bug] Wrong machtype argument passed for fuloong-2f
Date: Sun, 30 Oct 2011 04:29:50 +0100 [thread overview]
Message-ID: <4EACC4AE.5030504@gmail.com> (raw)
In-Reply-To: <20111029205434.GQ4110@mails.so.argh.org>
[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]
On 29.10.2011 22:54, Andreas Barth wrote:
> * David Kuehling (dvdkhlng@gmx.de) [111029 22:46]:
>> BTW it looks like it is impossible to override machtype= parameter from
>> the kernel command line configured in boot/grub/grub.cfg, since linux
>> code in loongson/common/machtype.c uses the first occurence of
>> "machtype=" in arcs_cmdline[]. Is this behaviour by design or by
>> accident? Is this linux' fault or grub's fault? One could change grub
>> to append machtype= rather than prepend it to the command line...
> I would consider it more appropriate to add a flag "suppress pmon
> command line" to the grub configuration - if you want to overwrite it,
> it should fully disappear, and not just be not parsed because there is
> another one first.
>
As I already said: machtype isn't only about pmon. And I consider it as
part of protocol on loongson so no, it won't be overrideable. Moreover
it's fundamentally wrong to make bugs configurable (bugs=on). Please try
the following patch:
=== modified file 'grub-core/loader/mips/linux.c'
--- grub-core/loader/mips/linux.c 2011-08-19 20:46:11 +0000
+++ grub-core/loader/mips/linux.c 2011-10-30 03:28:36 +0000
@@ -41,7 +41,7 @@
const char loongson_machtypes[][60] =
{
[GRUB_ARCH_MACHINE_YEELOONG] = "machtype=lemote-yeeloong-2f-8.9inches",
- [GRUB_ARCH_MACHINE_FULOONG2F] = "machtype=lemote-fuloong-2f-unknown",
+ [GRUB_ARCH_MACHINE_FULOONG2F] = "machtype=lemote-fuloong-2f-box",
[GRUB_ARCH_MACHINE_FULOONG2E] = "machtype=lemote-fuloong-2e-unknown"
};
#endif
> Andi
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2011-10-30 3:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-29 9:36 [bug] Wrong machtype argument passed for fuloong-2f David Kuehling
2011-10-29 10:37 ` Andreas Barth
2011-10-29 10:41 ` Vladimir 'φ-coder/phcoder' Serbinenko
2011-10-29 10:45 ` Andreas Barth
2011-10-29 10:54 ` Vladimir 'φ-coder/phcoder' Serbinenko
2011-10-29 13:56 ` Andreas Barth
2011-10-29 11:43 ` David Kuehling
2011-10-29 11:48 ` Andreas Barth
2011-10-29 20:46 ` David Kuehling
2011-10-29 20:54 ` Andreas Barth
2011-10-30 3:29 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2011-10-30 13:06 ` David Kuehling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EACC4AE.5030504@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.