* [U-Boot] [PATCH]: davinci: Replace CONFIG_PRELOADER with CONFIG_SPL_BUILD in board/davinci/common/misc.c
@ 2011-09-13 12:42 Sughosh Ganu
2011-09-13 12:45 ` Stefano Babic
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Sughosh Ganu @ 2011-09-13 12:42 UTC (permalink / raw)
To: u-boot
Make the conditional compilation in misc.c based on
CONFIG_SPL_BUILD, replacing CONFIG_PRELOADER which was removed as part
of commit 401bb30b6d.
Making this change, we no longer need to compile memsize.c for
hawkboard's nand_spl.
Signed-off-by: Sughosh Ganu <urwithsughosh@gmail.com>
---
Tested the changes on hawkboard.
Build tested on davinci boards with a 'MAKEALL -v davinci'
board/davinci/common/misc.c | 2 +-
nand_spl/board/davinci/da8xxevm/Makefile | 6 ------
2 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/board/davinci/common/misc.c b/board/davinci/common/misc.c
index 89ae111..5aa7605 100644
--- a/board/davinci/common/misc.c
+++ b/board/davinci/common/misc.c
@@ -33,7 +33,7 @@
DECLARE_GLOBAL_DATA_PTR;
-#ifndef CONFIG_PRELOADER
+#ifndef CONFIG_SPL_BUILD
int dram_init(void)
{
/* dram_init must store complete ramsize in gd->ram_size */
diff --git a/nand_spl/board/davinci/da8xxevm/Makefile b/nand_spl/board/davinci/da8xxevm/Makefile
index accf716..1df5c62 100644
--- a/nand_spl/board/davinci/da8xxevm/Makefile
+++ b/nand_spl/board/davinci/da8xxevm/Makefile
@@ -45,7 +45,6 @@ COBJS = cpu.o \
davinci_pinmux.o \
div0.o \
hawkboard_nand_spl.o \
- memsize.o \
misc.o \
nand_boot.o \
ns16550.o \
@@ -136,11 +135,6 @@ $(obj)psc.c:
@rm -f $@
ln -s $(TOPDIR)/arch/arm/cpu/arm926ejs/davinci/psc.c $@
-# from common directory
-$(obj)memsize.c:
- @rm -f $@
- ln -s $(TOPDIR)/common/memsize.c $@
-
#########################################################################
$(obj)%.o: $(obj)%.S
--
1.7.4.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [U-Boot] [PATCH]: davinci: Replace CONFIG_PRELOADER with CONFIG_SPL_BUILD in board/davinci/common/misc.c
2011-09-13 12:42 [U-Boot] [PATCH]: davinci: Replace CONFIG_PRELOADER with CONFIG_SPL_BUILD in board/davinci/common/misc.c Sughosh Ganu
@ 2011-09-13 12:45 ` Stefano Babic
2011-09-14 5:53 ` Heiko Schocher
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Stefano Babic @ 2011-09-13 12:45 UTC (permalink / raw)
To: u-boot
On 09/13/2011 02:42 PM, Sughosh Ganu wrote:
> Make the conditional compilation in misc.c based on
> CONFIG_SPL_BUILD, replacing CONFIG_PRELOADER which was removed as part
> of commit 401bb30b6d.
>
> Making this change, we no longer need to compile memsize.c for
> hawkboard's nand_spl.
>
> Signed-off-by: Sughosh Ganu <urwithsughosh@gmail.com>
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 7+ messages in thread* [U-Boot] [PATCH]: davinci: Replace CONFIG_PRELOADER with CONFIG_SPL_BUILD in board/davinci/common/misc.c
2011-09-13 12:42 [U-Boot] [PATCH]: davinci: Replace CONFIG_PRELOADER with CONFIG_SPL_BUILD in board/davinci/common/misc.c Sughosh Ganu
2011-09-13 12:45 ` Stefano Babic
@ 2011-09-14 5:53 ` Heiko Schocher
2011-09-19 7:30 ` Sughosh Ganu
2011-12-06 13:45 ` [U-Boot] [PATCH V2] davinci: Remove unwanted memsize.c from hawkboard's nand spl build Sughosh Ganu
3 siblings, 0 replies; 7+ messages in thread
From: Heiko Schocher @ 2011-09-14 5:53 UTC (permalink / raw)
To: u-boot
Hello Ganu,
Sughosh Ganu wrote:
> Make the conditional compilation in misc.c based on
> CONFIG_SPL_BUILD, replacing CONFIG_PRELOADER which was removed as part
> of commit 401bb30b6d.
>
> Making this change, we no longer need to compile memsize.c for
> hawkboard's nand_spl.
>
> Signed-off-by: Sughosh Ganu <urwithsughosh@gmail.com>
> ---
>
> Tested the changes on hawkboard.
> Build tested on davinci boards with a 'MAKEALL -v davinci'
>
>
> board/davinci/common/misc.c | 2 +-
> nand_spl/board/davinci/da8xxevm/Makefile | 6 ------
> 2 files changed, 1 insertions(+), 7 deletions(-)
Hehe, have similiar patch in my queue, so:
Acked-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH]: davinci: Replace CONFIG_PRELOADER with CONFIG_SPL_BUILD in board/davinci/common/misc.c
2011-09-13 12:42 [U-Boot] [PATCH]: davinci: Replace CONFIG_PRELOADER with CONFIG_SPL_BUILD in board/davinci/common/misc.c Sughosh Ganu
2011-09-13 12:45 ` Stefano Babic
2011-09-14 5:53 ` Heiko Schocher
@ 2011-09-19 7:30 ` Sughosh Ganu
2011-10-31 10:44 ` Sughosh Ganu
2011-12-06 13:45 ` [U-Boot] [PATCH V2] davinci: Remove unwanted memsize.c from hawkboard's nand spl build Sughosh Ganu
3 siblings, 1 reply; 7+ messages in thread
From: Sughosh Ganu @ 2011-09-19 7:30 UTC (permalink / raw)
To: u-boot
On Tue Sep 13, 2011 at 06:12:08PM +0530, Sughosh Ganu wrote:
> Make the conditional compilation in misc.c based on
> CONFIG_SPL_BUILD, replacing CONFIG_PRELOADER which was removed as part
> of commit 401bb30b6d.
>
> Making this change, we no longer need to compile memsize.c for
> hawkboard's nand_spl.
>
> Signed-off-by: Sughosh Ganu <urwithsughosh@gmail.com>
> ---
>
> Tested the changes on hawkboard.
> Build tested on davinci boards with a 'MAKEALL -v davinci'
>
>
> board/davinci/common/misc.c | 2 +-
> nand_spl/board/davinci/da8xxevm/Makefile | 6 ------
> 2 files changed, 1 insertions(+), 7 deletions(-)
Will this not go through ti next branch. I don't see this patch
included in the u-boot-ti/next pull request by Sandeep.
-sughosh
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH]: davinci: Replace CONFIG_PRELOADER with CONFIG_SPL_BUILD in board/davinci/common/misc.c
2011-09-19 7:30 ` Sughosh Ganu
@ 2011-10-31 10:44 ` Sughosh Ganu
2011-10-31 11:20 ` Heiko Schocher
0 siblings, 1 reply; 7+ messages in thread
From: Sughosh Ganu @ 2011-10-31 10:44 UTC (permalink / raw)
To: u-boot
On Mon Sep 19, 2011 at 01:00:25PM +0530, Sughosh Ganu wrote:
> On Tue Sep 13, 2011 at 06:12:08PM +0530, Sughosh Ganu wrote:
> > Make the conditional compilation in misc.c based on
> > CONFIG_SPL_BUILD, replacing CONFIG_PRELOADER which was removed as part
> > of commit 401bb30b6d.
> >
> > Making this change, we no longer need to compile memsize.c for
> > hawkboard's nand_spl.
> >
> > Signed-off-by: Sughosh Ganu <urwithsughosh@gmail.com>
> > ---
> >
> > Tested the changes on hawkboard.
> > Build tested on davinci boards with a 'MAKEALL -v davinci'
> >
> >
> > board/davinci/common/misc.c | 2 +-
> > nand_spl/board/davinci/da8xxevm/Makefile | 6 ------
> > 2 files changed, 1 insertions(+), 7 deletions(-)
>
> Will this not go through ti next branch. I don't see this patch
> included in the u-boot-ti/next pull request by Sandeep.
Sandeep, can this be included in the ti tree. This has been pending
for some time now. Thanks.
-sughosh
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH]: davinci: Replace CONFIG_PRELOADER with CONFIG_SPL_BUILD in board/davinci/common/misc.c
2011-10-31 10:44 ` Sughosh Ganu
@ 2011-10-31 11:20 ` Heiko Schocher
0 siblings, 0 replies; 7+ messages in thread
From: Heiko Schocher @ 2011-10-31 11:20 UTC (permalink / raw)
To: u-boot
Hello Sughosh Ganu,
Sughosh Ganu wrote:
> On Mon Sep 19, 2011 at 01:00:25PM +0530, Sughosh Ganu wrote:
>> On Tue Sep 13, 2011 at 06:12:08PM +0530, Sughosh Ganu wrote:
>>> Make the conditional compilation in misc.c based on
>>> CONFIG_SPL_BUILD, replacing CONFIG_PRELOADER which was removed as part
>>> of commit 401bb30b6d.
>>>
>>> Making this change, we no longer need to compile memsize.c for
>>> hawkboard's nand_spl.
>>>
>>> Signed-off-by: Sughosh Ganu <urwithsughosh@gmail.com>
>>> ---
>>>
>>> Tested the changes on hawkboard.
>>> Build tested on davinci boards with a 'MAKEALL -v davinci'
>>>
>>>
>>> board/davinci/common/misc.c | 2 +-
>>> nand_spl/board/davinci/da8xxevm/Makefile | 6 ------
>>> 2 files changed, 1 insertions(+), 7 deletions(-)
>> Will this not go through ti next branch. I don't see this patch
>> included in the u-boot-ti/next pull request by Sandeep.
>
> Sandeep, can this be included in the ti tree. This has been pending
> for some time now. Thanks.
@Sandeep: if you apply this patch, can you please remove my patch
http://patchwork.ozlabs.org/patch/106983/
pending since 2011-07-27 from patchworks?
Thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH V2] davinci: Remove unwanted memsize.c from hawkboard's nand spl build
2011-09-13 12:42 [U-Boot] [PATCH]: davinci: Replace CONFIG_PRELOADER with CONFIG_SPL_BUILD in board/davinci/common/misc.c Sughosh Ganu
` (2 preceding siblings ...)
2011-09-19 7:30 ` Sughosh Ganu
@ 2011-12-06 13:45 ` Sughosh Ganu
3 siblings, 0 replies; 7+ messages in thread
From: Sughosh Ganu @ 2011-12-06 13:45 UTC (permalink / raw)
To: u-boot
dram_init function in board/davinci/common/misc.c does not get
compiled for spl builds, thus rendering inclusion of memsize.c
useless.
Signed-off-by: Sughosh Ganu <urwithsughosh@gmail.com>
---
Changes since V1:
Rebased to current master branch
nand_spl/board/davinci/da8xxevm/Makefile | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/nand_spl/board/davinci/da8xxevm/Makefile b/nand_spl/board/davinci/da8xxevm/Makefile
index accf716..1df5c62 100644
--- a/nand_spl/board/davinci/da8xxevm/Makefile
+++ b/nand_spl/board/davinci/da8xxevm/Makefile
@@ -45,7 +45,6 @@ COBJS = cpu.o \
davinci_pinmux.o \
div0.o \
hawkboard_nand_spl.o \
- memsize.o \
misc.o \
nand_boot.o \
ns16550.o \
@@ -136,11 +135,6 @@ $(obj)psc.c:
@rm -f $@
ln -s $(TOPDIR)/arch/arm/cpu/arm926ejs/davinci/psc.c $@
-# from common directory
-$(obj)memsize.c:
- @rm -f $@
- ln -s $(TOPDIR)/common/memsize.c $@
-
#########################################################################
$(obj)%.o: $(obj)%.S
--
1.7.5.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-12-06 13:45 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-13 12:42 [U-Boot] [PATCH]: davinci: Replace CONFIG_PRELOADER with CONFIG_SPL_BUILD in board/davinci/common/misc.c Sughosh Ganu
2011-09-13 12:45 ` Stefano Babic
2011-09-14 5:53 ` Heiko Schocher
2011-09-19 7:30 ` Sughosh Ganu
2011-10-31 10:44 ` Sughosh Ganu
2011-10-31 11:20 ` Heiko Schocher
2011-12-06 13:45 ` [U-Boot] [PATCH V2] davinci: Remove unwanted memsize.c from hawkboard's nand spl build Sughosh Ganu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.