From: Anthony Liguori <anthony@codemonkey.ws>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-barrier: Fix build failure on PowerPC Mac OS X
Date: Tue, 01 Nov 2011 13:04:35 -0500 [thread overview]
Message-ID: <4EB034B3.2060108@codemonkey.ws> (raw)
In-Reply-To: <1320140389-22079-1-git-send-email-sunshine@sunshineco.com>
On 11/01/2011 04:39 AM, Eric Sunshine wrote:
> qemu-barrier.h tests if macro __powerpc__ is defined, however, the
> preprocessor on PowerPC Mac OS X defines only __POWERPC__, not
> __powerpc__. Resolve by testing instead for qemu-provided _ARCH_PPC.
>
> Signed-off-by: Eric Sunshine<sunshine@sunshineco.com>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
>
> The anomalous __powerpc__ test appears only in qemu-barrier.h.
> No other source files reference this name.
>
> Cc: David Gibson<david@gibson.dropbear.id.au>
>
> qemu-barrier.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-barrier.h b/qemu-barrier.h
> index 735eea6..c11bb2b 100644
> --- a/qemu-barrier.h
> +++ b/qemu-barrier.h
> @@ -14,7 +14,7 @@
> */
> #define smp_wmb() barrier()
>
> -#elif defined(__powerpc__)
> +#elif defined(_ARCH_PPC)
>
> /*
> * We use an eieio() for a wmb() on powerpc. This assumes we don't
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH] qemu-barrier: Fix build failure on PowerPC Mac OS X
Date: Tue, 01 Nov 2011 13:04:35 -0500 [thread overview]
Message-ID: <4EB034B3.2060108@codemonkey.ws> (raw)
In-Reply-To: <1320140389-22079-1-git-send-email-sunshine@sunshineco.com>
On 11/01/2011 04:39 AM, Eric Sunshine wrote:
> qemu-barrier.h tests if macro __powerpc__ is defined, however, the
> preprocessor on PowerPC Mac OS X defines only __POWERPC__, not
> __powerpc__. Resolve by testing instead for qemu-provided _ARCH_PPC.
>
> Signed-off-by: Eric Sunshine<sunshine@sunshineco.com>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
>
> The anomalous __powerpc__ test appears only in qemu-barrier.h.
> No other source files reference this name.
>
> Cc: David Gibson<david@gibson.dropbear.id.au>
>
> qemu-barrier.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-barrier.h b/qemu-barrier.h
> index 735eea6..c11bb2b 100644
> --- a/qemu-barrier.h
> +++ b/qemu-barrier.h
> @@ -14,7 +14,7 @@
> */
> #define smp_wmb() barrier()
>
> -#elif defined(__powerpc__)
> +#elif defined(_ARCH_PPC)
>
> /*
> * We use an eieio() for a wmb() on powerpc. This assumes we don't
next prev parent reply other threads:[~2011-11-01 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 9:39 [Qemu-trivial] [PATCH] qemu-barrier: Fix build failure on PowerPC Mac OS X Eric Sunshine
2011-11-01 9:39 ` [Qemu-devel] " Eric Sunshine
2011-11-01 18:04 ` Anthony Liguori [this message]
2011-11-01 18:04 ` Anthony Liguori
2011-11-01 18:39 ` [Qemu-trivial] " Andreas Färber
2011-11-01 18:39 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB034B3.2060108@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.