From: David Henningsson <david.henningsson@canonical.com>
To: Raymond Yau <superquad.vortex2@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>
Subject: Re: [RFC] hda - is_jack_detectable()
Date: Tue, 01 Nov 2011 17:03:29 -0400 [thread overview]
Message-ID: <4EB05EA1.1060701@canonical.com> (raw)
In-Reply-To: <CAN8ccia3XSQ0TxD2CqH7bSv=stf4Z8qbdeo=sOt_NUZ5+GNM=w@mail.gmail.com>
2011-10-24 23:31, Raymond Yau skrev:
> sorry, it should be
>
> static inline bool is_jack_detectable(struct hda_codec *codec, hda_nid_t nid)
> {
> return (snd_hda_query_pin_caps(codec, nid)& AC_PINCAP_PRES_DETECT)&&
> + !(get_defcfg_misc(snd_hda_codec_get_pincfg(codec, nid)
> & AC_DEFCFG_MISC_NO_PRESENCE))&&
> (get_wcaps(codec, nid)& AC_WCAP_UNSOL_CAP);
> }
>
I also think it is a good idea, in fact I thought it was this way
already. Can we merge this patch?
// David
next prev parent reply other threads:[~2011-11-01 21:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 3:02 [RFC] hda - is_jack_detectable() Raymond Yau
2011-10-25 3:31 ` Raymond Yau
2011-10-25 11:31 ` Takashi Iwai
2011-11-01 21:03 ` David Henningsson [this message]
2011-11-02 7:02 ` Takashi Iwai
2011-11-05 5:30 ` Raymond Yau
2011-11-06 13:12 ` Takashi Iwai
2011-11-09 4:06 ` Raymond Yau
2011-11-09 7:08 ` Takashi Iwai
2011-11-09 7:50 ` Takashi Iwai
[not found] ` <CAN8ccibAoNQfDNWJ-zE_DGH6mc-ipmmdhBDQW+fjOMT8xHcD+Q@mail.gmail.com>
[not found] ` <s5h4ny76naa.wl%tiwai@suse.de>
2011-11-16 7:14 ` Raymond Yau
2011-11-17 15:17 ` Takashi Iwai
2011-12-23 2:37 ` Raymond Yau
2011-12-23 9:26 ` Takashi Iwai
2011-12-27 1:45 ` Raymond Yau
2011-11-06 11:46 ` Raymond Yau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB05EA1.1060701@canonical.com \
--to=david.henningsson@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=superquad.vortex2@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.