From: Anthony Liguori <anthony@codemonkey.ws>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Suppress messages from pkg_config probe for check
Date: Tue, 01 Nov 2011 17:22:02 -0500 [thread overview]
Message-ID: <4EB0710A.6000607@codemonkey.ws> (raw)
In-Reply-To: <1320172375-28019-1-git-send-email-peter.maydell@linaro.org>
On 11/01/2011 01:32 PM, Peter Maydell wrote:
> Suppress confusing messages from pkg_config when probing for
> 'check' by sending them to /dev/null as we do with other
> similar probes.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> We didn't notice this before because we only recently
> changed the default for whether configure probed for this.
> I think that makes this a regression we should fix for 1.0.
>
> configure | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index 28667fe..9661b0e 100755
> --- a/configure
> +++ b/configure
> @@ -1828,7 +1828,7 @@ if test "$check_utests" != "no" ; then
> #include<check.h>
> int main(void) { suite_create("qemu test"); return 0; }
> EOF
> - check_libs=`$pkg_config --libs check`
> + check_libs=`$pkg_config --libs check 2>/dev/null`
> if compile_prog "" $check_libs ; then
> check_utests=yes
> libs_tools="$check_libs $libs_tools"
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: Suppress messages from pkg_config probe for check
Date: Tue, 01 Nov 2011 17:22:02 -0500 [thread overview]
Message-ID: <4EB0710A.6000607@codemonkey.ws> (raw)
In-Reply-To: <1320172375-28019-1-git-send-email-peter.maydell@linaro.org>
On 11/01/2011 01:32 PM, Peter Maydell wrote:
> Suppress confusing messages from pkg_config when probing for
> 'check' by sending them to /dev/null as we do with other
> similar probes.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> We didn't notice this before because we only recently
> changed the default for whether configure probed for this.
> I think that makes this a regression we should fix for 1.0.
>
> configure | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index 28667fe..9661b0e 100755
> --- a/configure
> +++ b/configure
> @@ -1828,7 +1828,7 @@ if test "$check_utests" != "no" ; then
> #include<check.h>
> int main(void) { suite_create("qemu test"); return 0; }
> EOF
> - check_libs=`$pkg_config --libs check`
> + check_libs=`$pkg_config --libs check 2>/dev/null`
> if compile_prog "" $check_libs ; then
> check_utests=yes
> libs_tools="$check_libs $libs_tools"
next prev parent reply other threads:[~2011-11-01 22:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 18:32 [Qemu-trivial] [PATCH] configure: Suppress messages from pkg_config probe for check Peter Maydell
2011-11-01 18:32 ` [Qemu-devel] " Peter Maydell
2011-11-01 22:22 ` Anthony Liguori [this message]
2011-11-01 22:22 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB0710A.6000607@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.