All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-devel@nongnu.org, Thomas Schmitt <scdbackup@gmx.net>
Subject: Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?
Date: Wed, 02 Nov 2011 13:08:51 +0100	[thread overview]
Message-ID: <4EB132D3.7070700@redhat.com> (raw)
In-Reply-To: <CAJSP0QV2rMgyhrzA8NvD2utAT9XgF7vM0Z6e==KJGgs4Se69VQ@mail.gmail.com>

On 11/02/2011 12:25 PM, Stefan Hajnoczi wrote:
>> Now i have two drives by one option.
>> xorriso -devices reports
>>   0  -dev '/dev/sr0' rwrw-- :  'TSSTcorp' 'CDDVDW SH-S223B'
>>   1  -dev '/dev/sr1' rwrw-- :  'QEMU    ' 'QEMU DVD-ROM'
>> with /dev/sr1 being an empty drive. (Is this a known bug ?)
>
> Off the top of my head I'd say this is an empty IDE CD-ROM drive which
> is added by default.  Would need to check the code to be sure though.

Yes, that's correct.

That empty IDE CD-ROM was the same that you were getting with 
virtio-blk.  With virtio-blk you get a /dev/vda drive that will respond 
to SG_IO, so it doesn't look like a pass-through CD-ROM but it is one.

>> The window where i ran qemu says:
>>
>>   qemu: ./qemu_dir/qemu-0.15.1/hw/lsi53c895a.c:540:
>>         lsi_do_dma: Assertion `s->current' failed.
>
> That's a bug in the LSI SCSI HBA emulation or a generic SCSI emulation
> problem in QEMU.  I have CCed Paolo and Kevin who have recently been
> working on SCSI and IDE much more than me and know more.

I suggest trying with 1.0-rc (origin/master).  No guarantee that it 
works, but definitely a lot of bugs have been fixed.  It is also 
possible that a few new ones were introduced.  I can also provide an 
updated version of my vmw_pvscsi device model, which is simpler and more 
stable than the lsi device model.

Also, with 1.0-rc you can do passthrough in two ways: with scsi-generic 
as you did, which always uses SG_IO, and with scsi-block.  scsi-block 
uses read+write for READ/WRITE CDBs and SG_IO for everything else.  You 
can define a scsi-block disk like this:

   -drive file=/dev/sr0,if=none,id=hostcd -device scsi-block,drive=hostcd

The advantage of scsi-block is that it doesn't need a bounce buffer as 
big as the whole request; in virtio-scsi it will not require a bounce 
buffer at all.  From the spec I don't understand how this will fail to 
burn CDs.  It's possible that some modes work and others don't.  I 
planned to test this on test day (Nov 7th).

> Thanks for the extensive testing.  I actually suggest focussing just
> on qemu.git/master because that is where developers mostly invest
> their time.  The data points on older versions can be interesting but
> my guess is folks won't have time to debug them - instead let's make
> qemu.git/master work.

Agreed.

Paolo

  reply	other threads:[~2011-11-02 12:09 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-01 17:27 [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ? Thomas Schmitt
2011-11-01 21:03 ` Thomas Schmitt
2011-11-02 11:25   ` Stefan Hajnoczi
2011-11-02 12:08     ` Paolo Bonzini [this message]
2011-11-02 16:26       ` Thomas Schmitt
2011-11-02 16:34         ` Paolo Bonzini
2011-11-02 18:05           ` Thomas Schmitt
2011-11-02 19:50             ` Paolo Bonzini
2011-11-02 21:22               ` Thomas Schmitt
2011-11-02 22:08                 ` Thomas Schmitt
2011-11-02 22:16                   ` [Qemu-devel] Compile error Frans de Boer
2011-11-02 22:19                     ` Anthony Liguori
2011-11-02 22:31                       ` Frans de Boer
2011-11-03  7:49                 ` [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ? Paolo Bonzini
2011-11-03  9:15                   ` Thomas Schmitt
2011-11-03  9:36                     ` Paolo Bonzini
2011-11-03 13:10                   ` Thomas Schmitt
2011-11-03 22:30                     ` Thomas Schmitt
2011-11-04  9:18                       ` Thomas Schmitt
2011-11-04  9:38                         ` Paolo Bonzini
2011-11-04 11:09                           ` Thomas Schmitt
2011-11-04 11:31                             ` Paolo Bonzini
2011-11-04 13:03                               ` Thomas Schmitt
2011-11-04 20:28                                 ` Thomas Schmitt
2011-11-05  8:33                                   ` Paolo Bonzini
2011-11-05 13:00                                     ` Thomas Schmitt
2011-11-05 14:37                                   ` Thomas Schmitt
2011-11-05 15:53                                     ` Paolo Bonzini
2011-11-05 16:38                                       ` Thomas Schmitt
2011-11-05 20:47                                     ` Thomas Schmitt
2011-11-06  8:17                                       ` Paolo Bonzini
2011-11-06 10:35                                         ` Thomas Schmitt
2011-11-06 20:14                                         ` Thomas Schmitt
2011-11-07  8:02                                           ` Paolo Bonzini
2011-11-07 10:04                                             ` Thomas Schmitt
2011-11-07 11:13                                               ` Paolo Bonzini
2011-11-07 11:24                                                 ` Zhi Yong Wu
2011-11-07 11:29                                                   ` Paolo Bonzini
2011-11-07 11:40                                                     ` Zhi Yong Wu
2011-11-06  9:31                                       ` Thomas Schmitt
2011-11-04 13:26                       ` Andreas Färber
2011-11-04 14:46                         ` Thomas Schmitt
2011-11-07  8:48             ` Zhi Yong Wu
2011-11-02 15:15     ` Thomas Schmitt
2011-11-02 16:22       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EB132D3.7070700@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=scdbackup@gmx.net \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.