From: "Andreas Färber" <afaerber@suse.de>
To: Thomas Schmitt <scdbackup@gmx.net>
Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?
Date: Fri, 04 Nov 2011 14:26:23 +0100 [thread overview]
Message-ID: <4EB3E7FF.4020908@suse.de> (raw)
In-Reply-To: <9745359965177@192.168.2.69>
Hi Thomas,
Am 03.11.2011 23:30, schrieb Thomas Schmitt:
> I tried to activate DPRINTF in hw/scsi-generic.c by removing the "//"
> before
> #define DEBUG_SCSI
>
> make yields:
> .../hw/scsi-generic.c: In function 'scsi_send_command':
> .../hw/scsi-generic.c:286: error: 'lun' undeclared (first use in this function)
> .../hw/scsi-generic.c:286: error: 'tag' undeclared (first use in this function)
We're about to release QEMU 1.0(-rc1) and you've just spotted a
compilation issue...
> So i had to change in scsi_send_command():
>
> - DPRINTF("Command: lun=%d tag=0x%x len %zd data=0x%02x", lun, tag,
> + DPRINTF("Command: len %zd data=0x%02x",
You've solved this issue 50%! What's missing now is for you to put this
fix into a self-contained patch (without the enabling of DEBUG_SCSI,
etc.) and to submit it using the git-send-email command, so that your
fix can be applied. :)
http://wiki.qemu.org/Contribute/SubmitAPatch
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2011-11-04 13:26 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 17:27 [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ? Thomas Schmitt
2011-11-01 21:03 ` Thomas Schmitt
2011-11-02 11:25 ` Stefan Hajnoczi
2011-11-02 12:08 ` Paolo Bonzini
2011-11-02 16:26 ` Thomas Schmitt
2011-11-02 16:34 ` Paolo Bonzini
2011-11-02 18:05 ` Thomas Schmitt
2011-11-02 19:50 ` Paolo Bonzini
2011-11-02 21:22 ` Thomas Schmitt
2011-11-02 22:08 ` Thomas Schmitt
2011-11-02 22:16 ` [Qemu-devel] Compile error Frans de Boer
2011-11-02 22:19 ` Anthony Liguori
2011-11-02 22:31 ` Frans de Boer
2011-11-03 7:49 ` [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ? Paolo Bonzini
2011-11-03 9:15 ` Thomas Schmitt
2011-11-03 9:36 ` Paolo Bonzini
2011-11-03 13:10 ` Thomas Schmitt
2011-11-03 22:30 ` Thomas Schmitt
2011-11-04 9:18 ` Thomas Schmitt
2011-11-04 9:38 ` Paolo Bonzini
2011-11-04 11:09 ` Thomas Schmitt
2011-11-04 11:31 ` Paolo Bonzini
2011-11-04 13:03 ` Thomas Schmitt
2011-11-04 20:28 ` Thomas Schmitt
2011-11-05 8:33 ` Paolo Bonzini
2011-11-05 13:00 ` Thomas Schmitt
2011-11-05 14:37 ` Thomas Schmitt
2011-11-05 15:53 ` Paolo Bonzini
2011-11-05 16:38 ` Thomas Schmitt
2011-11-05 20:47 ` Thomas Schmitt
2011-11-06 8:17 ` Paolo Bonzini
2011-11-06 10:35 ` Thomas Schmitt
2011-11-06 20:14 ` Thomas Schmitt
2011-11-07 8:02 ` Paolo Bonzini
2011-11-07 10:04 ` Thomas Schmitt
2011-11-07 11:13 ` Paolo Bonzini
2011-11-07 11:24 ` Zhi Yong Wu
2011-11-07 11:29 ` Paolo Bonzini
2011-11-07 11:40 ` Zhi Yong Wu
2011-11-06 9:31 ` Thomas Schmitt
2011-11-04 13:26 ` Andreas Färber [this message]
2011-11-04 14:46 ` Thomas Schmitt
2011-11-07 8:48 ` Zhi Yong Wu
2011-11-02 15:15 ` Thomas Schmitt
2011-11-02 16:22 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB3E7FF.4020908@suse.de \
--to=afaerber@suse.de \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=scdbackup@gmx.net \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.