From: Felix Fietkau <nbd@openwrt.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: preserve DFS flags in calcrxfilter
Date: Wed, 02 Nov 2011 14:19:33 +0100 [thread overview]
Message-ID: <4EB14365.6000505@openwrt.org> (raw)
In-Reply-To: <1320235803-12190-1-git-send-email-zefir.kurtisi@neratec.com>
On 2011-11-02 1:10 PM, Zefir Kurtisi wrote:
> RX filter flags previously set for DFS radar detection were not
> preserved after "ath9k: disable unnecessary PHY error reporting".
>
> This patch ensures that the flags required for DFS support are
> kept set.
>
> Signed-off-by: Zefir Kurtisi<zefir.kurtisi@neratec.com>
I think preserving the existing register values is a bit fragile wrt.
hardware resets, register clobbering, etc.
How about just adding an internal flag or bool in the softc?
- Felix
WARNING: multiple messages have this Message-ID (diff)
From: Felix Fietkau <nbd@openwrt.org>
To: Zefir Kurtisi <zefir.kurtisi@neratec.com>
Cc: linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org,
rodrigue@qca.qualcomm.com, linville@tuxdriver.com
Subject: Re: [PATCH] ath9k: preserve DFS flags in calcrxfilter
Date: Wed, 02 Nov 2011 14:19:33 +0100 [thread overview]
Message-ID: <4EB14365.6000505@openwrt.org> (raw)
In-Reply-To: <1320235803-12190-1-git-send-email-zefir.kurtisi@neratec.com>
On 2011-11-02 1:10 PM, Zefir Kurtisi wrote:
> RX filter flags previously set for DFS radar detection were not
> preserved after "ath9k: disable unnecessary PHY error reporting".
>
> This patch ensures that the flags required for DFS support are
> kept set.
>
> Signed-off-by: Zefir Kurtisi<zefir.kurtisi@neratec.com>
I think preserving the existing register values is a bit fragile wrt.
hardware resets, register clobbering, etc.
How about just adding an internal flag or bool in the softc?
- Felix
next prev parent reply other threads:[~2011-11-02 13:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 12:10 [ath9k-devel] [PATCH] ath9k: preserve DFS flags in calcrxfilter Zefir Kurtisi
2011-11-02 12:10 ` Zefir Kurtisi
2011-11-02 13:19 ` Felix Fietkau [this message]
2011-11-02 13:19 ` Felix Fietkau
2011-11-02 16:23 ` [ath9k-devel] " Zefir Kurtisi
2011-11-02 16:23 ` Zefir Kurtisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB14365.6000505@openwrt.org \
--to=nbd@openwrt.org \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.