From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH 1.0] virtio-blk: pass full status to the guest
Date: Wed, 02 Nov 2011 14:20:15 +0100 [thread overview]
Message-ID: <4EB1438F.4080602@redhat.com> (raw)
In-Reply-To: <20111102130033.GB8549@redhat.com>
On 11/02/2011 02:00 PM, Michael S. Tsirkin wrote:
> > When SCSI passthrough is being used by the guest with virtio-blk, the
> > guest is not able to detect disk failures. This is because the status
> > field is expected by the guest driver to include also the msg_status,
> > host_status and driver_status fields, but the device is only passing
> > down the SCSI status.
> >
> > The patch fixes this, and also makes sure that the guest always sees a
> > CHECK_CONDITION status when there is valid sense data.
>
> Do the bit offsets happen to be defined in some header?
Nope, the closest match is
#define msg_byte(result) (((result) >> 8) & 0xff)
#define host_byte(result) (((result) >> 16) & 0xff)
#define driver_byte(result) (((result) >> 24) & 0xff)
in Linux scsi/scsi.h
> Also, Signed-off-by is missing?
Ugh.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 1.0] virtio-blk: pass full status to the guest
Date: Wed, 02 Nov 2011 14:20:15 +0100 [thread overview]
Message-ID: <4EB1438F.4080602@redhat.com> (raw)
In-Reply-To: <20111102130033.GB8549@redhat.com>
On 11/02/2011 02:00 PM, Michael S. Tsirkin wrote:
> > When SCSI passthrough is being used by the guest with virtio-blk, the
> > guest is not able to detect disk failures. This is because the status
> > field is expected by the guest driver to include also the msg_status,
> > host_status and driver_status fields, but the device is only passing
> > down the SCSI status.
> >
> > The patch fixes this, and also makes sure that the guest always sees a
> > CHECK_CONDITION status when there is valid sense data.
>
> Do the bit offsets happen to be defined in some header?
Nope, the closest match is
#define msg_byte(result) (((result) >> 8) & 0xff)
#define host_byte(result) (((result) >> 16) & 0xff)
#define driver_byte(result) (((result) >> 24) & 0xff)
in Linux scsi/scsi.h
> Also, Signed-off-by is missing?
Ugh.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
next prev parent reply other threads:[~2011-11-02 13:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 12:19 [PATCH 1.0] virtio-blk: pass full status to the guest Paolo Bonzini
2011-11-02 12:19 ` [Qemu-devel] " Paolo Bonzini
2011-11-02 12:56 ` Anthony Liguori
2011-11-02 13:00 ` Michael S. Tsirkin
2011-11-02 13:00 ` [Qemu-devel] " Michael S. Tsirkin
2011-11-02 13:20 ` Paolo Bonzini [this message]
2011-11-02 13:20 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB1438F.4080602@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.