From: Stefan Weil <sw@weilnetz.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer
Date: Wed, 02 Nov 2011 14:31:27 +0100 [thread overview]
Message-ID: <4EB1462F.3070005@weilnetz.de> (raw)
In-Reply-To: <4EB13DA0.5050100@redhat.com>
Am 02.11.2011 13:54, schrieb Paolo Bonzini:
> On 10/31/2011 06:13 PM, Stefan Weil wrote:
>>>
>>
>> They can't be more broken: I noticed today that QEMU on W32 aborts
>> with the default timer (mmtimer) very quickly.
>
> Is there any reason why mmtimer2 is not the default (or indeed why
> mmtimer and win32 exist)?
>
> Paolo
>
Commit 68c23e5520e8286d79d96ab47c0ea722ceb75041 removed
the multimedia timers, so only timer "win32" was left:
use win32 timer queues
Multimedia timers are only useful for compatibility with Windows NT 4.0
and earlier. Plus, the implementation in Wine is extremely
heavyweight.
Commit 2f9cba0c148af32fad6813480f5c92efe17c2d49 re-added
mmtimer2 because it had existed before (it was called "dynticks" and
the default for w32) and was needed for Linux. It also added mmtimer,
a multimedia timer without rearm.
qemu-timer: Fix timers for w32
Commit 68c23e5520e8286d79d96ab47c0ea722ceb75041 removed the
multimedia timer, but this timer is needed for certain
Linux kernels. Otherwise Linux boot stops with this error:
MP-BIOS bug: 8254 timer not connected to IO-APIC
So the multimedia timer is added again here.
Now timers without rearm no longer work (abort in assertion).
I think mmtimer2 would be sufficient. For QEMU 1.0, it should be
the default, because otherwise w32 users won't be able to use it.
The arguments from the first patch are still valid, I suppose,
so removing the other timers (mmtimer and win32) should be
delayed until you, I (not before end of next week) or someone
else has done more tests on w32 and wine.
Regards
Stefan
next prev parent reply other threads:[~2011-11-02 13:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-21 16:26 [Qemu-devel] [PULL v3 00/13] allow tools to use the QEMU main loop Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 01/13] remove unused function Paolo Bonzini
2011-10-31 18:10 ` Anthony Liguori
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 02/13] qemu-timer: remove active_timers array Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer Paolo Bonzini
2011-10-31 7:23 ` TeLeMan
2011-10-31 10:05 ` Paolo Bonzini
2011-10-31 17:13 ` Stefan Weil
2011-11-02 12:54 ` Paolo Bonzini
2011-11-02 13:31 ` Stefan Weil [this message]
2011-11-02 13:37 ` Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 04/13] qemu-timer: more clock functions Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 05/13] qemu-timer: move icount to cpus.c Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 06/13] qemu-timer: do not refer to runstate_is_running() Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 07/13] qemu-timer: use atexit for quit_timers Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 08/13] qemu-timer: move more stuff out of qemu-timer.c Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 09/13] qemu-timer: do not use RunState change handlers Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 10/13] main-loop: create main-loop.h Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 11/13] main-loop: create main-loop.c Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 12/13] Revert to a hand-made select loop Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 13/13] simplify main loop functions Paolo Bonzini
2011-10-24 16:19 ` [Qemu-devel] [PULL v3 00/13] allow tools to use the QEMU main loop Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB1462F.3070005@weilnetz.de \
--to=sw@weilnetz.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.