From: Vasily Averin <vvs@parallels.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
"David S. Miller" <davem@davemloft.net>,
devel@openvz.org, Herbert Xu <herbert@gondor.hengli.com.au>
Subject: Re: [Bridge] [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish()
Date: Wed, 02 Nov 2011 20:03:26 -0000 [thread overview]
Message-ID: <4EB1A229.9030602@parallels.com> (raw)
In-Reply-To: <20111102123106.107f4cb8@nehalam.linuxnetplumber.net>
On 11/02/2011 11:31 PM, Stephen Hemminger wrote:
> On Wed, 02 Nov 2011 23:08:57 +0400
> Vasily Averin <vvs@parallels.com> wrote:
>
>> if dst is not local br_handle_frame_finish() does not clone original skb and
>> forgets to reset IPCB before return to IP stack. it can lead to stack corruption
>> in icmp_send()
> What kernel version are you using? There were several previous fixes
> in br_netfilter to deal with this type of issue over the last year.
Originally it was noticed on RHEL6-based kernel
You are right, in mainline this issue was fixed in br_nf_forward_ip() long time ago.
thank you,
Vasily Averin
WARNING: multiple messages have this Message-ID (diff)
From: Vasily Averin <vvs@parallels.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: "David S. Miller" <davem@davemloft.net>,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
Herbert Xu <herbert@gondor.hengli.com.au>,
devel@openvz.org
Subject: Re: [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish()
Date: Thu, 03 Nov 2011 00:03:53 +0400 [thread overview]
Message-ID: <4EB1A229.9030602@parallels.com> (raw)
In-Reply-To: <20111102123106.107f4cb8@nehalam.linuxnetplumber.net>
On 11/02/2011 11:31 PM, Stephen Hemminger wrote:
> On Wed, 02 Nov 2011 23:08:57 +0400
> Vasily Averin <vvs@parallels.com> wrote:
>
>> if dst is not local br_handle_frame_finish() does not clone original skb and
>> forgets to reset IPCB before return to IP stack. it can lead to stack corruption
>> in icmp_send()
> What kernel version are you using? There were several previous fixes
> in br_netfilter to deal with this type of issue over the last year.
Originally it was noticed on RHEL6-based kernel
You are right, in mainline this issue was fixed in br_nf_forward_ip() long time ago.
thank you,
Vasily Averin
next prev parent reply other threads:[~2011-11-02 20:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 19:08 [Bridge] [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish() Vasily Averin
2011-11-02 19:08 ` Vasily Averin
2011-11-02 19:11 ` [Bridge] " Vasily Averin
2011-11-02 19:11 ` Vasily Averin
2011-11-02 19:31 ` [Bridge] " Stephen Hemminger
2011-11-02 19:31 ` Stephen Hemminger
2011-11-02 19:45 ` [Bridge] " Daniel Robbins
2011-11-02 19:45 ` Daniel Robbins
2011-11-02 20:14 ` [Bridge] " Stephen Hemminger
2011-11-02 20:14 ` Stephen Hemminger
2011-11-02 20:16 ` David Miller
2011-11-02 20:16 ` David Miller
2011-11-02 20:23 ` [Bridge] " Daniel Robbins
2011-11-02 20:23 ` Daniel Robbins
2011-11-02 20:03 ` Vasily Averin [this message]
2011-11-02 20:03 ` Vasily Averin
2011-11-02 20:09 ` [Bridge] " David Miller
2011-11-02 20:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB1A229.9030602@parallels.com \
--to=vvs@parallels.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=herbert@gondor.hengli.com.au \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.