All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: jadecpu: Readd MACH_TYPE_JADECPU
Date: Sat, 05 Nov 2011 11:49:43 +0100	[thread overview]
Message-ID: <4EB514C7.9000503@aribaud.net> (raw)
In-Reply-To: <1320045986-3282-1-git-send-email-weisserm@arcor.de>

Hi Matthias,

Le 31/10/2011 08:26, Matthias Weisser a ?crit :
> MACH_TYPE_JADECPU was removed from mach-types.h. Add it to board
> config file.
>
> Signed-off-by: Matthias Weisser<weisserm@arcor.de>
> ---
>   board/syteco/jadecpu/jadecpu.c |    1 -
>   include/configs/jadecpu.h      |    6 ++++++
>   2 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/board/syteco/jadecpu/jadecpu.c b/board/syteco/jadecpu/jadecpu.c
> index 63a0d33..72288fe 100644
> --- a/board/syteco/jadecpu/jadecpu.c
> +++ b/board/syteco/jadecpu/jadecpu.c
> @@ -40,7 +40,6 @@ int board_init(void)
>   	writel(0x00000010,&ccnt->cmux_md);
>
>   	gd->flags = 0;
> -	gd->bd->bi_arch_number = MACH_TYPE_JADECPU;
>   	gd->bd->bi_boot_params = PHYS_SDRAM + PHYS_SDRAM_SIZE - 0x10000;
>
>   	icache_enable();
> diff --git a/include/configs/jadecpu.h b/include/configs/jadecpu.h
> index a239efc..42cb858 100644
> --- a/include/configs/jadecpu.h
> +++ b/include/configs/jadecpu.h
> @@ -37,6 +37,12 @@
>   #define CONFIG_USE_ARCH_MEMCPY
>   #define CONFIG_USE_ARCH_MEMSET
>
> +#ifndef MACH_TYPE_JADECPU
> +#define MACH_TYPE_JADECPU	2636
> +#endif

NAK -- remove ifndef/endif around definition. This way, if/when mach 
type reappears in official mach-type.h, we will get a warning about your 
mach-type being defined twice.

> +#define CONFIG_MACH_TYPE MACH_TYPE_JADECPU
> +
>   /*
>    * Environment settings
>    */

Amicalement,
-- 
Albert.

  parent reply	other threads:[~2011-11-05 10:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-31  7:26 [U-Boot] [PATCH] arm: jadecpu: Readd MACH_TYPE_JADECPU Matthias Weisser
2011-10-31  7:41 ` Igor Grinberg
2011-11-05 10:49 ` Albert ARIBAUD [this message]
2011-11-05 13:26   ` Wolfgang Denk
2011-11-05 14:09     ` Albert ARIBAUD
2011-11-05 14:56       ` Wolfgang Denk
2011-11-05 15:04         ` Albert ARIBAUD
2011-11-05 12:15 ` [U-Boot] [PATCH v2] " Matthias Weisser
2011-11-05 12:36   ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EB514C7.9000503@aribaud.net \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.