From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: jadecpu: Readd MACH_TYPE_JADECPU
Date: Sat, 05 Nov 2011 16:04:35 +0100 [thread overview]
Message-ID: <4EB55083.4040304@aribaud.net> (raw)
In-Reply-To: <20111105145605.642851893013@gemini.denx.de>
Le 05/11/2011 15:56, Wolfgang Denk a ?crit :
> Dear Albert ARIBAUD,
>
> In message<4EB543AF.7010006@aribaud.net> you wrote:
>>
>>> Note that you will only get a warning if a _different_ value get's
>>> defined (``warning: "VAR" redefined''). If both values are the same,
>>> no warning will be raised.
>>
>> Hmm, correct. In order to catch the mach-type creeping back in
>> mach-types.h, we'd need to define something like
>>
>> #define MACH_TYPE_JADECPU (2636)
>>
>> I'll post an ARM-global patch for this, but as it will obviously not be
>> a bugfix, it'll wait until next merge window.
>
> Please save the effort. Waht would it be good for? As long as the
> values are the same, it's OK anyway. And if they should be different,
> we get a bunch of warnings.
Just wanted to make sure we know when the temporary MACH_TYPE addition
in the config header becomes obsolete. But then, I can also run a grep
on include/configs/*.h whenever mach-types.h is updated.
> Best regards,
>
> Wolfgang Denk
Amicalement,
--
Albert.
next prev parent reply other threads:[~2011-11-05 15:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 7:26 [U-Boot] [PATCH] arm: jadecpu: Readd MACH_TYPE_JADECPU Matthias Weisser
2011-10-31 7:41 ` Igor Grinberg
2011-11-05 10:49 ` Albert ARIBAUD
2011-11-05 13:26 ` Wolfgang Denk
2011-11-05 14:09 ` Albert ARIBAUD
2011-11-05 14:56 ` Wolfgang Denk
2011-11-05 15:04 ` Albert ARIBAUD [this message]
2011-11-05 12:15 ` [U-Boot] [PATCH v2] " Matthias Weisser
2011-11-05 12:36 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB55083.4040304@aribaud.net \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.