[Drbd-dev] fix missing directory creation in "make install"

[Drbd-dev] fix missing directory creation in "make install"

[Florian Haas]

Lars/Phil,

please consider the following patch, which ensures that "make install"
creates DRBD_RUN_DIR. Issue highlighted by Eric Robinson, see:

http://lists.linux-ha.org/pipermail/linux-ha/2011-November/044198.html

The fix to DRBD_LIB_DIR is merely cosmetic I guess; I strongly doubt
anyone ever overrides the PACKAGE_TARNAME. But it doesn't hurt not
to hard-code "drbd" here.

The patch is in my repo at git://github.com/fghaas/drbd-8.4.git --
feel free to pull from there.

Thanks,
Florian

[Drbd-dev] [PATCH] build: properly create DRBD_LIB_DIR and DRBD_RUN_DIR

[Florian Haas]

configure defines DRBD_LIB_DIR and DRBD_RUN_DIR to be
$localstatedir/{lib,run}/${PACKAGE_TARNAME), but "make install"

- does not create DRBD_RUN_DIR at all,
- does not define DRBD_LIB_DIR in terms of $(PACKAGE_TARNAME).

Bring the Makefile into sync with what the userland tools expect.
---
 user/Makefile.in |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/user/Makefile.in b/user/Makefile.in
index 8252f01..4a26752 100644
--- a/user/Makefile.in
+++ b/user/Makefile.in
@@ -113,7 +113,8 @@ distclean: clean
 install:
 ifeq ($(WITH_UTILS),yes)
 	install -d $(DESTDIR)/sbin/
-	install -d $(DESTDIR)$(localstatedir)/lib/drbd
+	install -d $(DESTDIR)$(localstatedir)/lib/$(PACKAGE_TARNAME)
+	install -d $(DESTDIR)$(localstatedir)/run/$(PACKAGE_TARNAME)
 	install -d $(DESTDIR)$(localstatedir)/lock
 	if getent group haclient > /dev/null 2> /dev/null ; then	\
 		install -g haclient -m 4750 drbdsetup $(DESTDIR)/sbin/ ;	\
-- 
1.7.4.1

Re: [Drbd-dev] fix missing directory creation in "make install"

[Lars Ellenberg]

On Sun, Nov 06, 2011 at 05:09:55PM +0100, Florian Haas wrote:
> Lars/Phil,
> 
> please consider the following patch, which ensures that "make install"
> creates DRBD_RUN_DIR. Issue highlighted by Eric Robinson, see:
> 
> http://lists.linux-ha.org/pipermail/linux-ha/2011-November/044198.html

Can we just drop the configure nonsense again instead?

As /var/run/ is a tmpfs on many distros now, subdirs and other things in
it need to be recreated anyways as needed, which drbdsetup is actually
supposed to be doing.

And "someone" (the OS) is supposed to cleanup those dirs on reboot,
which won't happen with the braindead configure autofoo defautls,
which again may (or may not) confuse some things.

Ah, well, thanks for the patch, anyways ;)

-- 
: Lars Ellenberg
: LINBIT | Your Way to High Availability
: DRBD/HA support and consulting http://www.linbit.com

Re: [Drbd-dev] fix missing directory creation in "make install"

[Florian Haas]

On 2011-11-07 10:32, Lars Ellenberg wrote:
> On Sun, Nov 06, 2011 at 05:09:55PM +0100, Florian Haas wrote:
>> Lars/Phil,
>>
>> please consider the following patch, which ensures that "make install"
>> creates DRBD_RUN_DIR. Issue highlighted by Eric Robinson, see:
>>
>> http://lists.linux-ha.org/pipermail/linux-ha/2011-November/044198.html
> 
> Can we just drop the configure nonsense again instead?

You're not asking _me_ in earnest, are you?

> As /var/run/ is a tmpfs on many distros now, subdirs and other things in
> it need to be recreated anyways as needed, which drbdsetup is actually
> supposed to be doing.

Then you might want to look into drbdsetup, because at least on 8.4.0 it
does not do so.

Florian

Re: [Drbd-dev] fix missing directory creation in "make install"

[Lars Ellenberg]

On Mon, Nov 07, 2011 at 10:35:27AM +0100, Florian Haas wrote:
> > As /var/run/ is a tmpfs on many distros now, subdirs and other things in
> > it need to be recreated anyways as needed, which drbdsetup is actually
> > supposed to be doing.
> 
> Then you might want to look into drbdsetup,
> because at least on 8.4.0 it does not do so.

There is some mkdir() in there.

It obviously only mkdir */run/drbd, not */run/ itself
(which, I think, it should not).
So an other reason not to use the braindead autofoo "defaults".

Should we paint it pink?

	Lars

Re: [Drbd-dev] fix missing directory creation in "make install"

[Florian Haas]

On 2011-11-07 10:48, Lars Ellenberg wrote:
> On Mon, Nov 07, 2011 at 10:35:27AM +0100, Florian Haas wrote:
>>> As /var/run/ is a tmpfs on many distros now, subdirs and other things in
>>> it need to be recreated anyways as needed, which drbdsetup is actually
>>> supposed to be doing.
>>
>> Then you might want to look into drbdsetup,
>> because at least on 8.4.0 it does not do so.
> 
> There is some mkdir() in there.
> 
> It obviously only mkdir */run/drbd, not */run/ itself
> (which, I think, it should not).
>
> So an other reason not to use the braindead autofoo "defaults".
> 
> Should we paint it pink?

Grumpy Developer Day today? Please do as you wish.

Florian