From: "Andreas Färber" <afaerber@suse.de>
To: "Hervé Poussineau" <hpoussin@reactos.org>
Cc: qemu-trivial@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/3] sonic: fix typo
Date: Mon, 07 Nov 2011 12:15:21 +0100 [thread overview]
Message-ID: <4EB7BDC9.6050305@suse.de> (raw)
In-Reply-To: <1320616132-21864-1-git-send-email-hpoussin@reactos.org>
Would be nice to add description:
Remove a doubled semicolon.
Am 06.11.2011 22:48, schrieb Hervé Poussineau:
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
> ---
> hw/dp8393x.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/dp8393x.c b/hw/dp8393x.c
> index f66844b..cfec4cb 100644
> --- a/hw/dp8393x.c
> +++ b/hw/dp8393x.c
> @@ -515,7 +515,7 @@ static void write_register(dp8393xState *s, int reg, uint16_t val)
> switch (reg) {
> /* Command register */
> case SONIC_CR:
> - do_command(s, val);;
> + do_command(s, val);
> break;
> /* Prevent write to read-only registers */
> case SONIC_CAP2:
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: "Hervé Poussineau" <hpoussin@reactos.org>
Cc: qemu-trivial@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] sonic: fix typo
Date: Mon, 07 Nov 2011 12:15:21 +0100 [thread overview]
Message-ID: <4EB7BDC9.6050305@suse.de> (raw)
In-Reply-To: <1320616132-21864-1-git-send-email-hpoussin@reactos.org>
Would be nice to add description:
Remove a doubled semicolon.
Am 06.11.2011 22:48, schrieb Hervé Poussineau:
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
> ---
> hw/dp8393x.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/dp8393x.c b/hw/dp8393x.c
> index f66844b..cfec4cb 100644
> --- a/hw/dp8393x.c
> +++ b/hw/dp8393x.c
> @@ -515,7 +515,7 @@ static void write_register(dp8393xState *s, int reg, uint16_t val)
> switch (reg) {
> /* Command register */
> case SONIC_CR:
> - do_command(s, val);;
> + do_command(s, val);
> break;
> /* Prevent write to read-only registers */
> case SONIC_CAP2:
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2011-11-07 11:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-06 21:48 [Qemu-devel] [PATCH 1/3] sonic: fix typo Hervé Poussineau
2011-11-06 21:48 ` [Qemu-devel] [PATCH 2/3] sonic: fix netcard reset Hervé Poussineau
2011-11-07 11:16 ` Andreas Färber
2011-11-06 21:48 ` [Qemu-devel] [PATCH 3/3] sonic: reset all bits of in_use field when required Hervé Poussineau
2011-11-07 11:15 ` Andreas Färber [this message]
2011-11-07 11:15 ` [Qemu-devel] [PATCH 1/3] sonic: fix typo Andreas Färber
2011-11-08 10:46 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB7BDC9.6050305@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=hpoussin@reactos.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.