From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, Takashi Iwai <tiwai@suse.de>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id
Date: Mon, 07 Nov 2011 08:44:45 -0600 [thread overview]
Message-ID: <4EB7EEDD.4090604@codemonkey.ws> (raw)
In-Reply-To: <4EB7EE62.7070805@redhat.com>
On 11/07/2011 08:42 AM, Avi Kivity wrote:
> On 11/07/2011 04:33 PM, Gerd Hoffmann wrote:
>> On 11/07/11 15:17, Avi Kivity wrote:
>>> On 11/07/2011 01:00 PM, Gerd Hoffmann wrote:
>>>> This patch removes the code lines which set the subsystem id for the
>>>> emulated ac97 card to 8086:0000. Due to the device id being zero the
>>>> subsystem id isn't vaild anyway. With the patch applied the sound card
>>>> gets the default qemu subsystem id (1af4:1100) instead.
>>>
>>> This a guest ABI change. Do we want -M support for it?
>>
>> Given that the old subsystem id isn't valid I'd say no unless someone
>> comes up with a good reason.
>
> Do we know that Windows won't complain about it?
I thought the original motivation for the default subsystem ids was that some
Windows test suite was explicitly complaining about having invalid subsystem ids?
Regards,
Anthony Liguori
>
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@redhat.com>
Cc: Takashi Iwai <tiwai@suse.de>, Gerd Hoffmann <kraxel@redhat.com>,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id
Date: Mon, 07 Nov 2011 08:44:45 -0600 [thread overview]
Message-ID: <4EB7EEDD.4090604@codemonkey.ws> (raw)
In-Reply-To: <4EB7EE62.7070805@redhat.com>
On 11/07/2011 08:42 AM, Avi Kivity wrote:
> On 11/07/2011 04:33 PM, Gerd Hoffmann wrote:
>> On 11/07/11 15:17, Avi Kivity wrote:
>>> On 11/07/2011 01:00 PM, Gerd Hoffmann wrote:
>>>> This patch removes the code lines which set the subsystem id for the
>>>> emulated ac97 card to 8086:0000. Due to the device id being zero the
>>>> subsystem id isn't vaild anyway. With the patch applied the sound card
>>>> gets the default qemu subsystem id (1af4:1100) instead.
>>>
>>> This a guest ABI change. Do we want -M support for it?
>>
>> Given that the old subsystem id isn't valid I'd say no unless someone
>> comes up with a good reason.
>
> Do we know that Windows won't complain about it?
I thought the original motivation for the default subsystem ids was that some
Windows test suite was explicitly complaining about having invalid subsystem ids?
Regards,
Anthony Liguori
>
next prev parent reply other threads:[~2011-11-07 14:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 11:00 [PATCH 1.0] ac97: don't override the pci subsystem id Gerd Hoffmann
2011-11-07 11:00 ` [Qemu-devel] " Gerd Hoffmann
2011-11-07 14:17 ` Avi Kivity
2011-11-07 14:17 ` [Qemu-devel] " Avi Kivity
2011-11-07 14:33 ` Gerd Hoffmann
2011-11-07 14:33 ` [Qemu-devel] " Gerd Hoffmann
2011-11-07 14:39 ` Anthony Liguori
2011-11-07 14:39 ` Anthony Liguori
2011-11-07 14:42 ` Avi Kivity
2011-11-07 14:42 ` [Qemu-devel] " Avi Kivity
2011-11-07 14:44 ` Anthony Liguori [this message]
2011-11-07 14:44 ` Anthony Liguori
2011-11-07 14:50 ` Avi Kivity
2011-11-07 14:50 ` Avi Kivity
2011-11-07 14:53 ` Anthony Liguori
2011-11-07 15:00 ` Avi Kivity
2011-11-07 15:00 ` [Qemu-devel] " Avi Kivity
2011-11-07 15:10 ` Gerd Hoffmann
2011-11-07 15:10 ` Gerd Hoffmann
2011-11-07 15:15 ` Avi Kivity
2011-11-07 15:15 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB7EEDD.4090604@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.