do all recipes really need LIC_FILES_CHKSUM?

do all recipes really need LIC_FILES_CHKSUM?

[Robert P. J. Day]

  current poky ref manual seems pretty adamant about need for
LIC_FILES_CHKSUM:

"Note that this variable is mandatory for all recipes, unless the
LICENSE variable is set to "CLOSED".

but there's at least one counter-example,
meta-demoapps/recipes-graphics/pong-clock/pong-clock_1.0.bb:

=====

DESCRIPTION = "A clock combined with a game of pong"
LICENSE = "GPLv2+"
DEPENDS = "virtual/libx11 xdmcp xau"

SRC_URI = "file://pong-clock-no-flicker.c"

S = "${WORKDIR}"

do_compile () {
        ${CC} -o pong-clock pong-clock-no-flicker.c `pkg-config --cflags --libs x11 xau xdmcp`
}

do_install () {
        install -d ${D}${bindir}
        install -m 0755 pong-clock ${D}${bindir}
}

=====

so what's the story here?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: do all recipes really need LIC_FILES_CHKSUM?

[Gary Thomas]

On 2011-11-07 09:01, Robert P. J. Day wrote:
>
>    current poky ref manual seems pretty adamant about need for
> LIC_FILES_CHKSUM:
>
> "Note that this variable is mandatory for all recipes, unless the
> LICENSE variable is set to "CLOSED".
>
> but there's at least one counter-example,
> meta-demoapps/recipes-graphics/pong-clock/pong-clock_1.0.bb:
>
> =====
>
> DESCRIPTION = "A clock combined with a game of pong"
> LICENSE = "GPLv2+"
> DEPENDS = "virtual/libx11 xdmcp xau"
>
> SRC_URI = "file://pong-clock-no-flicker.c"
>
> S = "${WORKDIR}"
>
> do_compile () {
>          ${CC} -o pong-clock pong-clock-no-flicker.c `pkg-config --cflags --libs x11 xau xdmcp`
> }
>
> do_install () {
>          install -d ${D}${bindir}
>          install -m 0755 pong-clock ${D}${bindir}
> }
>
> =====
>
> so what's the story here?

I thought I saw an email saying that meta-demoapps was deprecated?
This recipe certainly should not build as is.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: do all recipes really need LIC_FILES_CHKSUM?

[Mark Hatle]

On 11/7/11 10:01 AM, Robert P. J. Day wrote:
> 
>   current poky ref manual seems pretty adamant about need for
> LIC_FILES_CHKSUM:
> 
> "Note that this variable is mandatory for all recipes, unless the
> LICENSE variable is set to "CLOSED".
> 
> but there's at least one counter-example,
> meta-demoapps/recipes-graphics/pong-clock/pong-clock_1.0.bb:

Bug in the example.. it should be fixed.

--Mark

> =====
> 
> DESCRIPTION = "A clock combined with a game of pong"
> LICENSE = "GPLv2+"
> DEPENDS = "virtual/libx11 xdmcp xau"
> 
> SRC_URI = "file://pong-clock-no-flicker.c"
> 
> S = "${WORKDIR}"
> 
> do_compile () {
>         ${CC} -o pong-clock pong-clock-no-flicker.c `pkg-config --cflags --libs x11 xau xdmcp`
> }
> 
> do_install () {
>         install -d ${D}${bindir}
>         install -m 0755 pong-clock ${D}${bindir}
> }
> 
> =====
> 
> so what's the story here?
> 
> rday
> 

Re: do all recipes really need LIC_FILES_CHKSUM?

[Robert P. J. Day]

On Mon, 7 Nov 2011, Mark Hatle wrote:

> On 11/7/11 10:01 AM, Robert P. J. Day wrote:
> >
> >   current poky ref manual seems pretty adamant about need for
> > LIC_FILES_CHKSUM:
> >
> > "Note that this variable is mandatory for all recipes, unless the
> > LICENSE variable is set to "CLOSED".
> >
> > but there's at least one counter-example,
> > meta-demoapps/recipes-graphics/pong-clock/pong-clock_1.0.bb:
>
> Bug in the example.. it should be fixed.

  oooookay, but it's really not hard to find more examples like that,
such as meta-demoapps/recipes-graphics/libxklavier/libxklavier_3.9.bb:

DESCRIPTION = "Utility library to make using XKB easier"
SECTION = "x11/libs"
DEPENDS = "iso-codes libxml2 glib-2.0 libxkbfile"
LICENSE = "LGPL"
PR = "r2"

SRC_URI = "${SOURCEFORGE_MIRROR}/gswitchit/libxklavier-${PV}.tar.bz2 \
           file://pkgconfigfix.patch;patch=1"

inherit autotools

  or "xournal" in the same directory, etc, etc.  i'm not trying to be
annoyingly pedantic (he lied), just pointing out the inconsistencies.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: do all recipes really need LIC_FILES_CHKSUM?

[Mark Hatle]

On 11/7/11 10:24 AM, Robert P. J. Day wrote:
> On Mon, 7 Nov 2011, Mark Hatle wrote:
> 
>> On 11/7/11 10:01 AM, Robert P. J. Day wrote:
>>>
>>>   current poky ref manual seems pretty adamant about need for
>>> LIC_FILES_CHKSUM:
>>>
>>> "Note that this variable is mandatory for all recipes, unless the
>>> LICENSE variable is set to "CLOSED".
>>>
>>> but there's at least one counter-example,
>>> meta-demoapps/recipes-graphics/pong-clock/pong-clock_1.0.bb:
>>
>> Bug in the example.. it should be fixed.

I'm not surprised that meta-demoapps is missing this stuff..  AFAIK the stuff
here isn't run though the normal build/QA process.

If this information isn't deprecated as Gary thought it might be... then it
absolutely should be fixed.

>   oooookay, but it's really not hard to find more examples like that,
> such as meta-demoapps/recipes-graphics/libxklavier/libxklavier_3.9.bb:
> 
> DESCRIPTION = "Utility library to make using XKB easier"
> SECTION = "x11/libs"
> DEPENDS = "iso-codes libxml2 glib-2.0 libxkbfile"
> LICENSE = "LGPL"
> PR = "r2"
> 
> SRC_URI = "${SOURCEFORGE_MIRROR}/gswitchit/libxklavier-${PV}.tar.bz2 \
>            file://pkgconfigfix.patch;patch=1"
> 
> inherit autotools
> 
>   or "xournal" in the same directory, etc, etc.  i'm not trying to be
> annoyingly pedantic (he lied), just pointing out the inconsistencies.
> 
> rday
>