From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: rientjes@google.com
Cc: mhocko@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org,
oleg@redhat.com, yinghan@google.com, akpm@linux-foundation.org
Subject: Re: [PATCH] oom: do not kill tasks with oom_score_adj OOM_SCORE_ADJ_MIN
Date: Mon, 07 Nov 2011 14:22:33 -0800 [thread overview]
Message-ID: <4EB85A29.3010604@jp.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1111071353140.27419@chino.kir.corp.google.com>
(11/7/2011 1:54 PM), David Rientjes wrote:
> On Fri, 4 Nov 2011, Michal Hocko wrote:
>
>> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
>> index e916168..4883514 100644
>> --- a/mm/oom_kill.c
>> +++ b/mm/oom_kill.c
>> @@ -185,6 +185,9 @@ unsigned int oom_badness(struct task_struct *p, struct mem_cgroup *mem,
>> if (!p)
>> return 0;
>>
>> + if (p->signal->oom_score_adj == OOM_SCORE_ADJ_MIN)
>> + return 0;
>> +
>> /*
>> * The memory controller may have a limit of 0 bytes, so avoid a divide
>> * by zero, if necessary.
>
> This leaves p locked, you need to do task_unlock(p) first.
>
> Once that's fixed, please add my
>
> Acked-by: David Rientjes <rientjes@google.com>
Agreed.
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
WARNING: multiple messages have this Message-ID (diff)
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: rientjes@google.com
Cc: mhocko@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org,
oleg@redhat.com, yinghan@google.com, akpm@linux-foundation.org
Subject: Re: [PATCH] oom: do not kill tasks with oom_score_adj OOM_SCORE_ADJ_MIN
Date: Mon, 07 Nov 2011 14:22:33 -0800 [thread overview]
Message-ID: <4EB85A29.3010604@jp.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1111071353140.27419@chino.kir.corp.google.com>
(11/7/2011 1:54 PM), David Rientjes wrote:
> On Fri, 4 Nov 2011, Michal Hocko wrote:
>
>> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
>> index e916168..4883514 100644
>> --- a/mm/oom_kill.c
>> +++ b/mm/oom_kill.c
>> @@ -185,6 +185,9 @@ unsigned int oom_badness(struct task_struct *p, struct mem_cgroup *mem,
>> if (!p)
>> return 0;
>>
>> + if (p->signal->oom_score_adj == OOM_SCORE_ADJ_MIN)
>> + return 0;
>> +
>> /*
>> * The memory controller may have a limit of 0 bytes, so avoid a divide
>> * by zero, if necessary.
>
> This leaves p locked, you need to do task_unlock(p) first.
>
> Once that's fixed, please add my
>
> Acked-by: David Rientjes <rientjes@google.com>
Agreed.
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-11-07 22:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 11:59 [PATCH] oom: do not kill tasks with oom_score_adj OOM_SCORE_ADJ_MIN Michal Hocko
2011-11-07 21:54 ` David Rientjes
2011-11-07 21:54 ` David Rientjes
2011-11-07 22:18 ` Michal Hocko
2011-11-07 22:18 ` Michal Hocko
2011-11-07 22:22 ` KOSAKI Motohiro [this message]
2011-11-07 22:22 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB85A29.3010604@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=oleg@redhat.com \
--cc=rientjes@google.com \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.