From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Takashi Iwai <tiwai@suse.de>, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] ac97: don't override the pci subsystem id
Date: Tue, 08 Nov 2011 09:08:45 +0100 [thread overview]
Message-ID: <4EB8E38D.6040804@redhat.com> (raw)
In-Reply-To: <4EB80099.8050304@codemonkey.ws>
On 11/07/11 17:00, Anthony Liguori wrote:
> On 11/07/2011 09:33 AM, Gerd Hoffmann wrote:
>> This patch removes the code lines which set the subsystem id for the
>> emulated ac97 card to 8086:0000. Due to the device id being zero the
>> subsystem id isn't vaild anyway. With the patch applied the sound card
>> gets the default qemu subsystem id (1af4:1100) instead.
>
> I don't like having a property of "use broken".
Well, it *is* broken.
Suggestions for a better name?
> Wouldn't it be better to have the subsystem vendor and device id be
> configurable, set the default to the qemu subsystem ids, and then set it
> to 8086:0000 for < 1.0?
I don't want this being fully configurable just for the snake of
backward compatibility with old qemu versions.
cheers,
Gerd
WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Takashi Iwai <tiwai@suse.de>, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 2/2] ac97: don't override the pci subsystem id
Date: Tue, 08 Nov 2011 09:08:45 +0100 [thread overview]
Message-ID: <4EB8E38D.6040804@redhat.com> (raw)
In-Reply-To: <4EB80099.8050304@codemonkey.ws>
On 11/07/11 17:00, Anthony Liguori wrote:
> On 11/07/2011 09:33 AM, Gerd Hoffmann wrote:
>> This patch removes the code lines which set the subsystem id for the
>> emulated ac97 card to 8086:0000. Due to the device id being zero the
>> subsystem id isn't vaild anyway. With the patch applied the sound card
>> gets the default qemu subsystem id (1af4:1100) instead.
>
> I don't like having a property of "use broken".
Well, it *is* broken.
Suggestions for a better name?
> Wouldn't it be better to have the subsystem vendor and device id be
> configurable, set the default to the qemu subsystem ids, and then set it
> to 8086:0000 for < 1.0?
I don't want this being fully configurable just for the snake of
backward compatibility with old qemu versions.
cheers,
Gerd
next prev parent reply other threads:[~2011-11-08 8:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 15:33 [PATCH 1/2] pc: add 1.0 machine type Gerd Hoffmann
2011-11-07 15:33 ` [Qemu-devel] " Gerd Hoffmann
2011-11-07 15:33 ` [PATCH 2/2] ac97: don't override the pci subsystem id Gerd Hoffmann
2011-11-07 15:33 ` [Qemu-devel] " Gerd Hoffmann
2011-11-07 16:00 ` Anthony Liguori
2011-11-07 16:00 ` Anthony Liguori
2011-11-08 8:08 ` Gerd Hoffmann [this message]
2011-11-08 8:08 ` Gerd Hoffmann
2011-11-08 10:00 ` Avi Kivity
2011-11-08 10:00 ` [Qemu-devel] " Avi Kivity
2011-11-08 10:18 ` Gerd Hoffmann
2011-11-08 10:18 ` [Qemu-devel] " Gerd Hoffmann
2011-11-08 17:25 ` [Qemu-devel] [PATCH 1/2] pc: add 1.0 machine type Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB8E38D.6040804@redhat.com \
--to=kraxel@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.